mirrors/node
0
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-10-28 10:15:07 +08:00
Code Activity
49,265 Commits 74 Branches 969 Tags
main
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Guy Bedford ec7a28f2e0 module: cache compiled WebAssembly modules in the compile cache 
Extends the module compile cache to WebAssembly modules loaded through
the ES module integration. A new kWasm entry type is keyed on the module
URL with the wire bytes as the hashed source, and stores the serialized
CompiledWasmModule. On load, cached code is deserialized through
v8::WasmModuleCompilation with the same compile options the translator
uses (js-string builtins and imported string constants), falling back
to compilation when V8 rejects it.

As for JavaScript, the cache entry is generated right after compilation.
V8 only serializes optimized tier code, so with the default lazy
baseline compilation there is nothing to cache and no entry is written;
a complete cache requires --no-liftoff --no-wasm-lazy-compilation, which
is documented as the way to use the compile cache for WebAssembly.

Signed-off-by: Guy Bedford <guybedford@gmail.com>
Assisted-by: Claude Code
PR-URL: https://github.com/nodejs/node/pull/66191
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2026-10-28 01:46:44 +00:00
Guy Bedford 8ae0ad0683 module: add "worker" condition for Web Worker threads 
Adds a "worker" package condition that is applied within Web Worker
threads created via the `Worker` global, for the worker entry point,
its dependencies, `import()`, `require()` and `import.meta.resolve()`.
Threads created via `worker_threads`, including from within a Web
Worker, do not apply the condition. Other conditions are unaffected.

Assisted-by: OpenCode
Signed-off-by: Guy Bedford <guybedford@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66635
Reviewed-By: James M Snell <jasnell@gmail.com>
 2026-10-19 17:09:42 +00:00
Guy Bedford 1d5f8e6cba wasi: accept wasm i32 pointers with high bit set 
Wasm i32 arguments with the high bit set are passed to JS as negative
Int32 numbers, so WASI functions taking uint32_t pointers rejected
them with EINVAL. Accept Int32 in CheckType<uint32_t> and reinterpret
as uint32_t on conversion, fixing all WASI functions at once.

Fixes: https://github.com/nodejs/node/issues/62671
Refs: https://github.com/nodejs/node/pull/62822
Assisted-by: OpenCode
Signed-off-by: Guy Bedford <guybedford@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66636
Reviewed-By: James M Snell <jasnell@gmail.com>
 2026-10-19 16:56:07 +00:00
Guy Bedford f955c20dd1 net: support sending net.BoundSocket to threads and child processes 
This adds support for transferring net.BoundSocket instances to other
threads via the worker_threads postMessage() transfer list, and for
sending them to child processes as the sendHandle argument of
subprocess.send(), following on from the BoundSocket introduction.

A BoundSocket reserves a port synchronously at construction time.
Making it transferable means a port can be reserved on one thread or
process and the bound (but not yet listening or connected) TCP handle
handed off to another to listen or connect on, without racing on the
bind.

For threads, BoundSocket implements kTransfer/kTransferList/
kDeserialize, moving the underlying TCP handle with the same mechanism
used for net.Socket and net.Server transfer. For child processes, the
handleConversion entry reuses the same transfer protocol on the
sending side and the same _TransferredBoundSocket deserialization path
on the receiving side; the underlying transport is that of cluster's
shared-handle scheduling: SCM_RIGHTS on Unix and WSADuplicateSocket on
Windows, both of which carry bind state.

In both cases the source instance is left in the adopted state:
address(), fd() and close() throw ERR_SOCKET_HANDLE_ADOPTED. Transfer
requires an un-adopted, open TCP handle, otherwise
ERR_WORKER_HANDLE_NOT_TRANSFERABLE is thrown; pipe (path) binds are
not transferable and throw ERR_INVALID_HANDLE_TYPE when sent over IPC.
On the receiving side the local address is re-derived from the handle
rather than trusted from serialized state.

Signed-off-by: Guy Bedford <guybedford@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/64725
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2026-09-08 16:05:22 +02:00
Guy Bedford b420cb649d net: support AF_UNIX paths in net.BoundSocket 
Signed-off-by: Guy Bedford <guybedford@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/64399
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2026-07-24 16:11:39 -07:00
Guy Bedford e3cdb14678 net: early TCP binding via synchronous net.BoundSocket 
Signed-off-by: Guy Bedford <guybedford@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63951
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2026-06-20 14:40:48 -07:00
Guy Bedford 0df15188d7 esm: unflag --experimental-wasm-modules 
PR-URL: https://github.com/nodejs/node/pull/57038
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2025-07-22 13:24:06 -07:00
Guy Bedford 35e599b3d0 esm: js-string Wasm builtins in ESM Integration 
PR-URL: https://github.com/nodejs/node/pull/59020
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2025-07-18 15:50:52 -07:00
Guy Bedford a7e4a40298 esm: unwrap WebAssembly.Global on Wasm Namespaces 
PR-URL: https://github.com/nodejs/node/pull/57525
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2025-05-27 11:40:28 -07:00
Guy Bedford f5ac35ee15 esm: add support for dynamic source phase hook 
PR-URL: https://github.com/nodejs/node/pull/58147
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2025-05-22 07:42:28 -07:00
Guy Bedford 870dec25f7 esm: support top-level Wasm without package type 
PR-URL: https://github.com/nodejs/node/pull/57610
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2025-04-03 19:38:40 -07:00
Guy Bedford fbe37d501e esm: fix module.exports export on CJS modules 
PR-URL: https://github.com/nodejs/node/pull/57366
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2025-03-09 13:51:04 -07:00
Guy Bedford 1d5ed725e9 esm: export 'module.exports' on ESM CJS wrapper 
PR-URL: https://github.com/nodejs/node/pull/53848
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2024-10-02 12:30:23 -07:00
Guy Bedford d24c7313f7 module: support 'module.exports' interop export in require(esm) 
PR-URL: https://github.com/nodejs/node/pull/54563
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2024-10-01 21:13:03 -07:00
Guy Bedford c813de46fc doc: mark --conditions CLI flag as stable 
PR-URL: https://github.com/nodejs/node/pull/54209
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-09-07 01:37:19 +02:00
Guy Bedford ee8b7f1f18 esm: unflag import.meta.resolve 
PR-URL: https://github.com/nodejs/node/pull/49028
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2023-08-13 05:42:25 +00:00
Guy Bedford 569267d048 esm: import.meta.resolve exact module not found errors should return 
PR-URL: https://github.com/nodejs/node/pull/49038
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
 2023-08-13 00:02:03 +00:00
Guy Bedford 15f10515e3 module: fix segment deprecation for imports field 
PR-URL: https://github.com/nodejs/node/pull/44883
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-10-13 07:31:31 -07:00
Guy Bedford 7dd2f41c73 module: runtime deprecate exports double slash maps 
PR-URL: https://github.com/nodejs/node/pull/44495
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2022-09-11 23:48:22 +00:00
Guy Bedford 53633c033d module: exports & imports map invalid slash deprecation 
PR-URL: https://github.com/nodejs/node/pull/44477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
 2022-09-11 12:01:37 +02:00
Guy Bedford 10ed3e8dca module: cjs-module-lexer WebAssembly fallback 
PR-URL: https://github.com/nodejs/node/pull/43612
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
 2022-07-03 18:33:54 +01:00
Guy Bedford 74716ada2e doc: packages documentation updates for 12 EOL 
PR-URL: https://github.com/nodejs/node/pull/43375
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-06-15 13:44:02 -07:00
Guy Bedford dfa896f926 esm: refactor responseURL handling 
PR-URL: https://github.com/nodejs/node/pull/43164
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
 2022-06-03 14:29:09 -07:00
Guy Bedford e31d1cb55d doc: define "types", "deno" community conditions 
PR-URL: https://github.com/nodejs/node/pull/40708
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2021-11-20 16:41:06 -08:00
Guy Bedford 2e2a6fecd9 doc: update cjs-module-lexer repo link 
PR-URL: https://github.com/nodejs/node/pull/40707
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-11-02 21:01:50 -07:00
Guy Bedford 687debbf0a doc: correct esm spec scope lookup definition 
PR-URL: https://github.com/nodejs/node/pull/40592
Fixes: https://github.com/nodejs/node/issues/40578
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
 2021-10-26 16:02:54 -07:00
Guy Bedford f0dcac89c7 module: resolver & spec hardening /w refactoring 
PR-URL: https://github.com/nodejs/node/pull/40510
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-10-24 14:44:59 -07:00
Guy Bedford ccee352630 doc: esm resolver spec refactoring for deprecations 
PR-URL: https://github.com/nodejs/node/pull/40314
Refs: https://github.com/nodejs/node/pull/37206
Refs: https://github.com/nodejs/node/pull/40117
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-10-08 07:35:02 -07:00
Guy Bedford 481c1609d8 module: fix ERR_REQUIRE_ESM for parentPath null 
PR-URL: https://github.com/nodejs/node/pull/40145
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-09-28 07:30:23 -07:00
Guy Bedford 36e2ffe6dc module: subpath folder mappings EOL 
PR-URL: https://github.com/nodejs/node/pull/40121
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-09-21 23:15:02 -07:00
Guy Bedford 64287e4d45 module: runtime deprecate trailing slash patterns 
PR-URL: https://github.com/nodejs/node/pull/40117
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-09-18 21:03:20 -07:00
Guy Bedford bea8a90e1d module: support pattern trailers for imports field 
PR-URL: https://github.com/nodejs/node/pull/40041
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
 2021-09-15 01:51:29 -07:00
Guy Bedford 7216fb118d module: deprecate trailing slash pattern mappings 
PR-URL: https://github.com/nodejs/node/pull/40039
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
 2021-09-14 23:58:56 -07:00
Guy Bedford 5c1adda0ae module: fix $ pattern replacements 
PR-URL: https://github.com/nodejs/node/pull/40044
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
 2021-09-12 13:46:14 -07:00
Guy Bedford 162f07b7af doc: update WASI example to use import.meta.url 
PR-URL: https://github.com/nodejs/node/pull/39925
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-08-31 08:07:35 -07:00
Guy Bedford 18bb2cef83 module: support pattern trailers 
PR-URL: https://github.com/nodejs/node/pull/39635
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
 2021-08-25 12:49:33 -07:00
Guy Bedford b0a6ade3bd module: fix ERR_REQUIRE_ESM error for null frames 
PR-URL: https://github.com/nodejs/node/pull/39593
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-07-31 02:32:19 +00:00
Guy Bedford fdf625bae8 deps: update to cjs-module-lexer@1.2.2 
PR-URL: https://github.com/nodejs/node/pull/39402
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-07-17 12:59:21 -07:00
Guy Bedford e2a6399be7 esm: refine ERR_REQUIRE_ESM errors 
PR-URL: https://github.com/nodejs/node/pull/39175
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-15 08:52:37 -07:00
Guy Bedford 8189dcc52a repl: ensure correct syntax err for await parsing 
PR-URL: https://github.com/nodejs/node/pull/39154
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2021-07-02 15:52:11 -07:00
Guy Bedford f4d0a6a07b doc: esm examples /w imports for process, Buffer 
PR-URL: https://github.com/nodejs/node/pull/39043
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
 2021-06-25 11:26:49 -07:00
Guy Bedford 3ad4fa01eb cli: add -C alias for --conditions flag 
PR-URL: https://github.com/nodejs/node/pull/38755
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
 2021-05-25 15:13:36 +02:00
Guy Bedford 01940ee285 doc: document null target pattern 
PR-URL: https://github.com/nodejs/node/pull/38724
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-05-20 18:53:45 +02:00
Guy Bedford 50991df0f7 deps: update to cjs-module-lexer@1.2.1 
PR-URL: https://github.com/nodejs/node/pull/38450
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-04-30 14:43:48 +02:00
Guy Bedford 0d66317cec deps: update to cjs-module-lexer@1.1.1 
PR-URL: https://github.com/nodejs/node/pull/37992
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2021-04-01 19:57:41 +02:00
Guy Bedford 8e46568b1e deps: backport v8 f19142e6 
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: https://github.com/v8/v8/commit/f19142e6139979da3a177cb0b9f382e459f5ccec
PR-URL: https://github.com/nodejs/node/pull/37864
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-03-29 23:33:22 +02:00
Guy Bedford 10a8dc075b deps: update to cjs-module-lexer@1.1.0 
PR-URL: https://github.com/nodejs/node/pull/37712
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-03-17 14:37:34 +02:00
Guy Bedford 255d6337cd esm: deprecate legacy main lookup for modules 
PR-URL: https://github.com/nodejs/node/pull/36918
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-01-30 16:31:49 +02:00
Guy Bedford efa6e1d651 doc: list Unsupported Directory Import resolve err 
PR-URL: https://github.com/nodejs/node/pull/37032
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-01-25 13:03:17 +02:00
Guy Bedford ac2c8c530d doc: fixup http.IncomingMessage deprecation code 
PR-URL: https://github.com/nodejs/node/pull/36917
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-01-18 11:58:56 +01:00
Guy Bedford 088a7e5247 doc: define "browser", "production", "development" 
Defines the above exports conditions by convention
as well as some guidance for further conditions
definitions in future

PR-URL: https://github.com/nodejs/node/pull/36856
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
 2021-01-12 16:50:11 -05:00
Guy Bedford 2e909c4fcc module: fix Windows folder exports deprecation warning 
PR-URL: https://github.com/nodejs/node/pull/36859
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2021-01-12 14:45:51 +01:00
Guy Bedford 0c3e10005e doc: stabilize subpath patterns 
PR-URL: https://github.com/nodejs/node/pull/36177
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-11-23 12:58:40 -05:00
Guy Bedford 73ea670152 doc: mark modules implementation as stable 
PR-URL: https://github.com/nodejs/node/pull/35781
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
 2020-11-18 17:42:49 -05:00
Guy Bedford 187ce5bd06 doc: esm docs consolidation and reordering 
PR-URL: https://github.com/nodejs/node/pull/36046
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
 2020-11-15 13:04:06 -08:00
Guy Bedford a5f99b8d20 deps: upgrade to cjs-module-lexer@1.0.0 
PR-URL: https://github.com/nodejs/node/pull/35928
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2020-11-02 10:24:04 -08:00
Guy Bedford 5735525404 deps: update to cjs-module-lexer@0.5.2 
PR-URL: https://github.com/nodejs/node/pull/35901
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-10-31 18:42:47 -07:00
Guy Bedford c9acb9e5b3 module: runtime deprecate subpath folder mappings 
PR-URL: https://github.com/nodejs/node/pull/35747
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2020-10-30 12:12:56 -04:00
Guy Bedford b92d2e4b78 deps: upgrade to cjs-module-lexer@0.5.0 
PR-URL: https://github.com/nodejs/node/pull/35871
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2020-10-29 16:45:50 -07:00
Guy Bedford fdaf9cbfe3 deps: update to cjs-module-lexer@0.4.3 
PR-URL: https://github.com/nodejs/node/pull/35745
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2020-10-23 18:19:35 -07:00
Guy Bedford ab0af50ef8 module: cjs-module-lexer@0.4.1 big endian fix 
PR-URL: https://github.com/nodejs/node/pull/35634
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
 2020-10-14 16:15:32 -04:00
Guy Bedford f3ce2811dd module: use Wasm CJS lexer when available 
PR-URL: https://github.com/nodejs/node/pull/35583
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
 2020-10-12 04:24:41 -07:00
Guy Bedford db4b0ecda7 module: update to cjs-module-lexer@0.4.0 
PR-URL: https://github.com/nodejs/node/pull/35501
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-10-05 11:53:19 -04:00
Guy Bedford 5e605c0dd9 module: fix builtin reexport tracing 
PR-URL: https://github.com/nodejs/node/pull/35500
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2020-10-04 10:30:13 -07:00
Guy Bedford 9e0bc3330e doc: unhide resolver spec 
PR-URL: https://github.com/nodejs/node/pull/35358
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-10-02 01:47:55 -07:00
Guy Bedford 726143e683 module: refine module type mismatch error cases 
PR-URL: https://github.com/nodejs/node/pull/35426
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2020-09-30 20:46:01 -07:00
Guy Bedford ee9e3e75aa esm: use "node:" namespace for builtins 
PR-URL: https://github.com/nodejs/node/pull/35387
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2020-09-29 18:20:28 -07:00
Guy Bedford 4d7015f401 doc: packages docs feedback 
PR-URL: https://github.com/nodejs/node/pull/35370
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-09-29 11:49:24 -04:00
Guy Bedford 1e8cb08edc module: named exports for CJS via static analysis 
PR-URL: https://github.com/nodejs/node/pull/35249
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
 2020-09-28 18:27:25 -07:00
Guy Bedford 226b186a93 doc: refine require/import conditions constraints 
PR-URL: https://github.com/nodejs/node/pull/35311
Reviewed-By: Jan Krems <jan.krems@gmail.com>
 2020-09-25 20:48:23 -07:00
Guy Bedford 2d868fe822 module: exports pattern support 
PR-URL: https://github.com/nodejs/node/pull/34718
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2020-09-17 18:56:17 -07:00
Guy Bedford 3fb7fcd821 esm: better package.json parser errors 
PR-URL: https://github.com/nodejs/node/pull/35117
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-09-11 05:09:44 -07:00
Guy Bedford 04865cf6f0 bootstrap: correct --frozen-intrinsics override fix 
PR-URL: https://github.com/nodejs/node/pull/35041
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-09-06 16:48:14 -07:00
Guy Bedford ef4e3b5f69 doc: error code fix in resolver spec 
PR-URL: https://github.com/nodejs/node/pull/34998
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
 2020-09-03 16:33:04 -07:00
Guy Bedford f8976a76bb module: share CJS/ESM resolver fns, refactoring 
PR-URL: https://github.com/nodejs/node/pull/34744
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-08-13 11:04:24 -07:00
Guy Bedford 77a515c31a module: custom --conditions flag option 
PR-URL: https://github.com/nodejs/node/pull/34637
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
 2020-08-11 14:35:44 -07:00
Guy Bedford 0f4b4ea5c6 module: use cjsCache over esm injection 
PR-URL: https://github.com/nodejs/node/pull/34605
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-08-09 16:33:30 -07:00
Guy Bedford 1fe39f0b4b module: disable cjs snapshotting into esm loader 
PR-URL: https://github.com/nodejs/node/pull/34467
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
 2020-07-29 16:29:18 -07:00
Guy Bedford e212955e8a doc: clarify conditional exports guidance 
PR-URL: https://github.com/nodejs/node/pull/34306
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
 2020-07-14 08:04:49 -07:00
Guy Bedford 1237955d41 module: package "imports" field 
PR-URL: https://github.com/nodejs/node/pull/34117
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
 2020-07-09 19:19:35 -07:00
Guy Bedford f89530fccc doc: clarify require/import mutual exclusivity 
PR-URL: https://github.com/nodejs/node/pull/33832
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
 2020-06-27 21:18:54 -07:00
Guy Bedford e88d098e50 doc: correct CommonJS self-resolve spec 
PR-URL: https://github.com/nodejs/node/pull/33391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
 2020-05-22 18:00:40 -07:00
Guy Bedford 2496db8e09 module: no type module resolver side effects 
PR-URL: https://github.com/nodejs/node/pull/33086
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
 2020-04-29 22:10:35 -07:00
Guy Bedford e767ed0558 module: exports not exported for null resolutions 
PR-URL: https://github.com/nodejs/node/pull/32838
Reviewed-By: Jan Krems <jan.krems@gmail.com>
 2020-04-22 15:48:44 -07:00
Guy Bedford 22b6997aba module: remove experimental modules warning 
PR-URL: https://github.com/nodejs/node/pull/31974
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2020-04-17 12:26:12 -04:00
Guy Bedford 534c204e22 module: path-only CJS exports extension searching 
PR-URL: https://github.com/nodejs/node/pull/32351
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2020-03-31 20:39:01 -06:00
Guy BedfordandGeoffrey Booth 04028aac3a doc: update conditional exports recommendations 
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/32098
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
 2020-03-13 10:08:37 +01:00
Guy Bedford 49ad16104f module: disable conditional exports, self resolve warnings 
PR-URL: https://github.com/nodejs/node/pull/31845
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
 2020-02-26 23:21:56 +02:00
Guy Bedford 58de9b46b8 module: package "exports" error refinements 
PR-URL: https://github.com/nodejs/node/pull/31625
Reviewed-By: Jan Krems <jan.krems@gmail.com>
 2020-02-18 13:34:40 +02:00
Guy Bedford 0f96dc266f esm: import.meta.resolve with nodejs: builtins 
PR-URL: https://github.com/nodejs/node/pull/31032
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2020-02-03 18:31:02 +02:00
Guy Bedford c2c3274631 module: fix check exports issue in cjs module loading 
Refs: https://github.com/nodejs/node/pull/31001#issuecomment-576353389

PR-URL: https://github.com/nodejs/node/pull/31427
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-01-20 21:32:52 -08:00
Guy Bedford fc4e413554 module: unflag conditional exports 
PR-URL: https://github.com/nodejs/node/pull/31001
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2020-01-15 20:48:52 -05:00
Guy Bedford 405e7b4557 module: logical conditional exports ordering 
PR-URL: https://github.com/nodejs/node/pull/31008
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
 2020-01-07 06:14:19 +02:00
Guy Bedford c7f328f0df module: unflag resolve self 
PR-URL: https://github.com/nodejs/node/pull/31002
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2020-01-02 17:53:47 +01:00
Guy Bedford 8a96d05ec7 module: self resolve bug fix and esm ordering 
PR-URL: https://github.com/nodejs/node/pull/31009
Reviewed-By: Jan Krems <jan.krems@gmail.com>
 2019-12-29 11:17:21 -05:00
Guy Bedford 357a99293e module: conditional exports import condition 
PR-URL: https://github.com/nodejs/node/pull/30799
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2019-12-12 17:35:08 -05:00
Guy Bedford 781e41df61 module: fixup lint and test regressions 
PR-URL: https://github.com/nodejs/node/pull/30802
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2019-12-05 02:49:17 -05:00
Guy Bedford 50ab2e3a77 doc: fixup incorrect flag name reference 
PR-URL: https://github.com/nodejs/node/pull/30651
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-11-28 00:13:54 +01:00
Guy Bedford 250a995656 esm: disable non-js exts outside package scopes 
PR-URL: https://github.com/nodejs/node/pull/30501
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2019-11-16 23:26:49 -08:00
Guy Bedford 796f3d0af4 esm: unflag --experimental-modules 
PR-URL: https://github.com/nodejs/node/pull/29866
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2019-11-12 14:04:55 -08:00