mirrors/node
0
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-10-28 10:15:07 +08:00
Code Activity

doc: fix typos and grammar in BUILDING.md & onboarding.md

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/61267
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This commit is contained in:
Hardanish Singh authored and Antoine du Hamel committed 2026-02-24 00:37:14 +01:00
1 parent db59c35ed8
commit 9a0a40d1ed
2 files changed
+6 -6
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

BUILDING.md
+4 -4
View File
@@ -564,7 +564,7 @@ on Linux, you can try [Docker](https://www.docker.com/products/docker-desktop/)
(using an image like `gengjiawen/node-build:2020-02-14`).
The `--debug` is not necessary and will slow down build and testing, but it can
show clear stacktrace if ASan hits an issue.
show a clear stack trace if ASan hits an issue.
```bash
./configure --debug --enable-asan && make -j4
@@ -642,8 +642,8 @@ the number of parallel build tasks (`-j<n>`).
#### Tips
You may need disable vcpkg integration if you got link error about symbol
redefine related to zlib.lib(zlib1.dll), even you never install it by hand,
You may need to disable vcpkg integration if you encounter a link error about symbol
redefinition related to zlib.lib(zlib1.dll), even if you never installed it by hand,
as vcpkg is part of CLion and Visual Studio now.
```powershell
@@ -819,7 +819,7 @@ cp c:\ccache\ccache.exe c:\ccache\cl.exe
```
With newer version of Visual Studio, it may need the copy to be `clang-cl.exe`
instead. If the output of `vcbuild.bat` suggestion missing `clang-cl.exe`, copy
instead. If the output of `vcbuild.bat` suggests missing `clang-cl.exe`, copy
it differently:
```powershell
onboarding.md
+2 -2
View File
@@ -286,7 +286,7 @@ needs to be pointed out separately during the onboarding.
* If you are interested in helping to fix coverity reports consider requesting
access to the projects coverity project as outlined in [static-analysis][].
* If you are interested in helping out with CI reliability, check out the
[reliability respository][] and [guide on how to deal with CI flakes][].
[reliability repository][] and [guide on how to deal with CI flakes][].
[Code of Conduct]: https://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md
[Labels]: doc/contributing/collaborator-guide.md#labels
@@ -299,7 +299,7 @@ needs to be pointed out separately during the onboarding.
[`node-test-pull-request`]: https://ci.nodejs.org/job/node-test-pull-request/
[guide on how to deal with CI flakes]: https://github.com/nodejs/test?tab=readme-ov-file#protocols-in-improving-ci-reliability
[participants' expenses]: https://github.com/openjs-foundation/cross-project-council/blob/main/community-fund/COMMUNITY_FUND_POLICY.md#community-fund-rules
[reliability respository]: https://github.com/nodejs/reliability
[reliability repository]: https://github.com/nodejs/reliability
[set up the credentials]: https://github.com/nodejs/node-core-utils#setting-up-github-credentials
[static-analysis]: doc/contributing/static-analysis.md
[two-factor authentication]: https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/