From 9a0a40d1ed6e57b892e0886791efc669cf7beb73 Mon Sep 17 00:00:00 2001 From: Hardanish Singh <61027578+Hardanish-Singh@users.noreply.github.com> Date: Tue, 6 Jan 2026 03:52:15 -0500 Subject: [PATCH] doc: fix typos and grammar in `BUILDING.md` & `onboarding.md` PR-URL: https://github.com/nodejs/node/pull/61267 Reviewed-By: Gireesh Punathil Reviewed-By: Antoine du Hamel Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: Rafael Gonzaga --- BUILDING.md | 8 ++++---- onboarding.md | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index 7c417325ad0..fa3816c3492 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -564,7 +564,7 @@ on Linux, you can try [Docker](https://www.docker.com/products/docker-desktop/) (using an image like `gengjiawen/node-build:2020-02-14`). The `--debug` is not necessary and will slow down build and testing, but it can -show clear stacktrace if ASan hits an issue. +show a clear stack trace if ASan hits an issue. ```bash ./configure --debug --enable-asan && make -j4 @@ -642,8 +642,8 @@ the number of parallel build tasks (`-j`). #### Tips -You may need disable vcpkg integration if you got link error about symbol -redefine related to zlib.lib(zlib1.dll), even you never install it by hand, +You may need to disable vcpkg integration if you encounter a link error about symbol +redefinition related to zlib.lib(zlib1.dll), even if you never installed it by hand, as vcpkg is part of CLion and Visual Studio now. ```powershell @@ -819,7 +819,7 @@ cp c:\ccache\ccache.exe c:\ccache\cl.exe ``` With newer version of Visual Studio, it may need the copy to be `clang-cl.exe` -instead. If the output of `vcbuild.bat` suggestion missing `clang-cl.exe`, copy +instead. If the output of `vcbuild.bat` suggests missing `clang-cl.exe`, copy it differently: ```powershell diff --git a/onboarding.md b/onboarding.md index 46731e5a0e8..7d447163885 100644 --- a/onboarding.md +++ b/onboarding.md @@ -286,7 +286,7 @@ needs to be pointed out separately during the onboarding. * If you are interested in helping to fix coverity reports consider requesting access to the projects coverity project as outlined in [static-analysis][]. * If you are interested in helping out with CI reliability, check out the - [reliability respository][] and [guide on how to deal with CI flakes][]. + [reliability repository][] and [guide on how to deal with CI flakes][]. [Code of Conduct]: https://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md [Labels]: doc/contributing/collaborator-guide.md#labels @@ -299,7 +299,7 @@ needs to be pointed out separately during the onboarding. [`node-test-pull-request`]: https://ci.nodejs.org/job/node-test-pull-request/ [guide on how to deal with CI flakes]: https://github.com/nodejs/test?tab=readme-ov-file#protocols-in-improving-ci-reliability [participants' expenses]: https://github.com/openjs-foundation/cross-project-council/blob/main/community-fund/COMMUNITY_FUND_POLICY.md#community-fund-rules -[reliability respository]: https://github.com/nodejs/reliability +[reliability repository]: https://github.com/nodejs/reliability [set up the credentials]: https://github.com/nodejs/node-core-utils#setting-up-github-credentials [static-analysis]: doc/contributing/static-analysis.md [two-factor authentication]: https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/