Fix typos in comments and rename VALKEY_SANITAIZER_* CMake variables (#2250)

---------

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
This commit is contained in:
Josh Soref authored and GitHub committed 2026-10-21 07:56:04 -07:00
1 parent 4a698691cf
commit c1ed73bfc0
10 files changed
+19 -19

No files matched your search

+8 -8
View File
@@ -261,17 +261,17 @@ endif ()
# Sanitizer
if (BUILD_SANITIZER)
# Common CFLAGS
list(APPEND VALKEY_SANITAIZER_CFLAGS "-fno-sanitize-recover=all")
list(APPEND VALKEY_SANITAIZER_CFLAGS "-fno-omit-frame-pointer")
list(APPEND VALKEY_SANITIZER_CFLAGS "-fno-sanitize-recover=all")
list(APPEND VALKEY_SANITIZER_CFLAGS "-fno-omit-frame-pointer")
if ("${BUILD_SANITIZER}" STREQUAL "address")
list(APPEND VALKEY_SANITAIZER_CFLAGS "-fsanitize=address")
list(APPEND VALKEY_SANITAIZER_LDFLAGS "-fsanitize=address")
list(APPEND VALKEY_SANITIZER_CFLAGS "-fsanitize=address")
list(APPEND VALKEY_SANITIZER_LDFLAGS "-fsanitize=address")
elseif ("${BUILD_SANITIZER}" STREQUAL "thread")
list(APPEND VALKEY_SANITAIZER_CFLAGS "-fsanitize=thread")
list(APPEND VALKEY_SANITAIZER_LDFLAGS "-fsanitize=thread")
list(APPEND VALKEY_SANITIZER_CFLAGS "-fsanitize=thread")
list(APPEND VALKEY_SANITIZER_LDFLAGS "-fsanitize=thread")
elseif ("${BUILD_SANITIZER}" STREQUAL "undefined")
list(APPEND VALKEY_SANITAIZER_CFLAGS "-fsanitize=undefined")
list(APPEND VALKEY_SANITAIZER_LDFLAGS "-fsanitize=undefined")
list(APPEND VALKEY_SANITIZER_CFLAGS "-fsanitize=undefined")
list(APPEND VALKEY_SANITIZER_LDFLAGS "-fsanitize=undefined")
else ()
message(FATAL_ERROR "Unknown sanitizer: ${BUILD_SANITIZER}")
endif ()
+3 -3
View File
@@ -64,10 +64,10 @@ endif ()
if (BUILD_SANITIZER)
# 'BUILD_SANITIZER' is defined in ValkeySetup module (based on user input) If defined, the variables
# 'VALKEY_SANITAIZER_CFLAGS' and 'VALKEY_SANITAIZER_LDFLAGS' are set with the link & compile flags required
# 'VALKEY_SANITIZER_CFLAGS' and 'VALKEY_SANITIZER_LDFLAGS' are set with the link & compile flags required
message(STATUS "Adding sanitizer flags for target valkey-server")
target_compile_options(valkey-server PRIVATE ${VALKEY_SANITAIZER_CFLAGS})
target_link_options(valkey-server PRIVATE ${VALKEY_SANITAIZER_LDFLAGS})
target_compile_options(valkey-server PRIVATE ${VALKEY_SANITIZER_CFLAGS})
target_link_options(valkey-server PRIVATE ${VALKEY_SANITIZER_LDFLAGS})
endif ()
unset(BUILD_SANITIZER CACHE)
+1 -1
View File
@@ -2149,7 +2149,7 @@ static int ACLSelectorCheckKey(aclSelector *selector, const char *key, int keyle
return ACL_DENIED_KEY;
}
/* Checks if the provided selector selector has access specified in flags
/* Checks if the provided selector has access specified in flags
* to all keys in the keyspace. For example, CMD_KEY_READ access requires either
* '%R~*', '~*', or allkeys to be granted to the selector. Returns 1 if all
* the access flags are satisfied with this selector or 0 otherwise.
+1 -1
View File
@@ -1324,7 +1324,7 @@ void scanGenericCommandWithOptions(client *c, robj *o, unsigned long long cursor
* 4. data.pattern: the pattern string;
* 5. data.sampled: the maxiteration limit is there in case we're
* working on an empty dict, one with a lot of empty buckets, and
* for the buckets are not empty, we need to limit the spampled number
* for the buckets are not empty, we need to limit the sampled number
* to prevent a long hang time caused by filtering too many keys;
* 6. data.only_keys: to control whether values will be returned or
* only keys are returned. */
+1 -1
View File
@@ -4100,7 +4100,7 @@ int replicaProcessPsyncReply(connection *conn) {
if (!strncmp(reply, "+CONTINUE", 9)) {
if (server.repl_rdb_channel_state != REPL_DUAL_CHANNEL_STATE_NONE) {
/* During dual channel sync sesseion, primary struct is already initialized. */
/* During dual channel sync session, primary struct is already initialized. */
sdsfree(reply);
return PSYNC_CONTINUE;
}
+1 -1
View File
@@ -2441,7 +2441,7 @@ static int cliSendCommand(int argc, char **argv, long repeat) {
replicaMode(0);
config.replica_mode = 0;
zfree(argvlen);
return VALKEY_ERR; /* Error = replilcaMode lost connection to primary */
return VALKEY_ERR; /* Error = replicaMode lost connection to primary */
}
/* Read response, possibly skipping pubsub/push messages. */
+1 -1
View File
@@ -827,7 +827,7 @@ int zmalloc_get_allocator_info(size_t *allocated, size_t *active, size_t *reside
je_mallctl("stats.retained", retained, &sz, NULL, 0);
}
/* Unlike retained, Muzzy representats memory released with `madvised(..., MADV_FREE)`.
/* Unlike retained, Muzzy represents memory released with `madvised(..., MADV_FREE)`.
* These pages will show as RSS for the process, until the OS decides to re-use them. */
if (muzzy) {
size_t pmuzzy, page;
+1 -1
View File
@@ -441,7 +441,7 @@ proc pause_on_error {} {
}
} elseif {$cmd eq {help}} {
puts "ls List Sentinel and Valkey instances."
puts "show-sentinel-logs \[N\] Show latest N lines of logs."
puts "show-sentinel-logs \[N\] Show latest N lines of sentinel logs."
puts "show-valkey-logs \[N\] Show latest N lines of logs."
puts "S <id> cmd ... arg Call command in Sentinel <id>."
puts "R <id> cmd ... arg Call command in Valkey <id>."
+1 -1
View File
@@ -638,7 +638,7 @@ start_server {tags {"repl external:skip"} overrides {save {}}} {
# to the slave.
after 5000
# Stop the ability of the slave to process data by sendig
# Stop the ability of the slave to process data by sending
# a script that will put it in BUSY state.
$slave eval {for i=1,3000000000 do end} 0
+1 -1
View File
@@ -772,7 +772,7 @@ start_server {tags {"geo"}} {
}
}
# Make sure this is a real error and not a rounidng issue.
# Make sure this is a real error and not a rounding issue.
if {[llength $diff] == $rounding_errors} {
set res $res2; # Error silenced
}