ScopeIterator skipped scopes that don't declare any variables (other than the paused function's own scope). Now that ScopeIterator walks the full lexical scope tree, keep empty scopes, so that the scope chain reported via CDP (flagged with Debugger.Scope.emptyReason) matches the lexical scopes, e.g. to match them against scopes in source maps and to target them via `evaluateOnCallFrame` with `scopeNumber`. Empty script scopes and empty eval root scopes (which also back wrapped and Function() functions) are still skipped. [[Scopes]] is unaffected, since the inspector omits empty scopes there itself. R=pfaffe@chromium.org Bug: 545412300 Change-Id: I0a5c0d71e66f7c4f747770c350713ff97dcc38ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8460466 Reviewed-by: Philip Pfaffe <pfaffe@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#110382}
194 lines
5.6 KiB
JavaScript
194 lines
5.6 KiB
JavaScript
// Copyright 2012 the V8 project authors. All rights reserved.
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
|
|
var Debug = debug.Debug;
|
|
|
|
const ScopeType = debug.ScopeType;
|
|
|
|
let exception = null;
|
|
let listenerDelegate = null;
|
|
|
|
const expected_break_count = 5;
|
|
let break_count = 0;
|
|
|
|
Debug.setListener(function(event, exec_state, event_data, data) {
|
|
if (event != Debug.DebugEvent.Break) return;
|
|
try {
|
|
break_count++;
|
|
listenerDelegate(exec_state);
|
|
} catch (e) {
|
|
exception = e;
|
|
print(e, e.stack);
|
|
}
|
|
});
|
|
|
|
function CheckScope(scope_frame, scope_expectations, expected_scope_type) {
|
|
assertEquals(expected_scope_type, scope_frame.scopeType());
|
|
|
|
var scope_object = scope_frame.scopeObject().value();
|
|
|
|
for (var name in scope_expectations) {
|
|
var actual = scope_object[name];
|
|
var expected = scope_expectations[name];
|
|
assertEquals(expected, actual);
|
|
}
|
|
}
|
|
|
|
// ---
|
|
|
|
listenerDelegate = function(exec_state) {
|
|
const frame = exec_state.frame(0);
|
|
|
|
assertEquals(7, frame.scopeCount());
|
|
|
|
CheckScope(frame.scope(0), {}, ScopeType.Local);
|
|
CheckScope(frame.scope(1), { a: 4, b: 5 }, ScopeType.Closure);
|
|
CheckScope(frame.scope(2), { w: 5, v: "Capybara" }, ScopeType.With);
|
|
CheckScope(frame.scope(3), { z: 22 }, ScopeType.Closure);
|
|
CheckScope(frame.scope(4), { x: 5 }, ScopeType.Closure);
|
|
CheckScope(frame.scope(5), {}, ScopeType.Script);
|
|
CheckScope(frame.scope(6), {}, ScopeType.Global);
|
|
};
|
|
|
|
(function F1(x) {
|
|
function F2(y) {
|
|
var z = x + y;
|
|
with ({w: 5, v: "Capybara"}) {
|
|
var F3 = function(a, b) {
|
|
function F4(p) {
|
|
debugger;
|
|
return p + a + b + z + w + v.length;
|
|
}
|
|
return F4;
|
|
}
|
|
return F3(4, 5);
|
|
}
|
|
}
|
|
return F2(17);
|
|
})(5)();
|
|
|
|
// ---
|
|
|
|
listenerDelegate = function(exec_state) {
|
|
const frame = exec_state.frame(0);
|
|
|
|
assertEquals(3, frame.scopeCount());
|
|
|
|
CheckScope(frame.scope(0), {}, ScopeType.Local);
|
|
CheckScope(frame.scope(1), {}, ScopeType.Script);
|
|
CheckScope(frame.scope(2), {}, ScopeType.Global);
|
|
};
|
|
|
|
(function() { debugger; return 5; })();
|
|
|
|
// ---
|
|
|
|
listenerDelegate = function(exec_state) {
|
|
const frame = exec_state.frame(0);
|
|
|
|
assertEquals(6, frame.scopeCount());
|
|
|
|
CheckScope(frame.scope(0), {}, ScopeType.Local);
|
|
CheckScope(frame.scope(1), { visible2: 20 }, ScopeType.Closure);
|
|
CheckScope(frame.scope(2), { invisible2: undefined }, ScopeType.Closure);
|
|
CheckScope(frame.scope(3), { visible1: 10, invisible1: undefined }, ScopeType.Closure);
|
|
CheckScope(frame.scope(4), {}, ScopeType.Script);
|
|
CheckScope(frame.scope(5), {}, ScopeType.Global);
|
|
};
|
|
|
|
(function F1(invisible_parameter) {
|
|
var invisible1 = 1;
|
|
var visible1 = 10;
|
|
return (function F2() {
|
|
var invisible2 = 2;
|
|
return (function F3() {
|
|
var visible2 = 20;
|
|
return (function () { debugger; return visible1 + visible2; });
|
|
})();
|
|
})();
|
|
})(5)();
|
|
|
|
// ---
|
|
|
|
listenerDelegate = function(exec_state) {
|
|
const frame = exec_state.frame(0);
|
|
|
|
assertEquals(6, frame.scopeCount());
|
|
|
|
CheckScope(frame.scope(0), {}, ScopeType.Local);
|
|
CheckScope(frame.scope(1), { e2: "I'm error 2" }, ScopeType.Catch);
|
|
CheckScope(frame.scope(2), { e1: "I'm error 1" }, ScopeType.Catch);
|
|
CheckScope(frame.scope(3), {}, ScopeType.Closure);
|
|
CheckScope(frame.scope(4), {}, ScopeType.Script);
|
|
CheckScope(frame.scope(5), {}, ScopeType.Global);
|
|
};
|
|
|
|
(function One() {
|
|
try {
|
|
throw "I'm error 1";
|
|
} catch (e1) {
|
|
try {
|
|
throw "I'm error 2";
|
|
} catch (e2) {
|
|
return function GetError() {
|
|
debugger;
|
|
return e1 + e2;
|
|
};
|
|
}
|
|
}
|
|
})()();
|
|
|
|
// ---
|
|
|
|
listenerDelegate = function(exec_state) {
|
|
const frame = exec_state.frame(0);
|
|
|
|
assertEquals(5, frame.scopeCount());
|
|
|
|
CheckScope(frame.scope(0), {}, ScopeType.Local);
|
|
CheckScope(frame.scope(1), { p4: 20, p6: 22 }, ScopeType.Closure);
|
|
CheckScope(frame.scope(2), { p1: 1 }, ScopeType.Closure);
|
|
CheckScope(frame.scope(3), {}, ScopeType.Script);
|
|
CheckScope(frame.scope(4), {}, ScopeType.Global);
|
|
};
|
|
|
|
(function Raz(p1, p2) {
|
|
var p3 = p1 + p2;
|
|
return (function() {
|
|
var p4 = 20;
|
|
var p5 = 21;
|
|
var p6 = 22;
|
|
return eval("(function(p7){ debugger; return p1 + p4 + p6 + p7})");
|
|
})();
|
|
})(1,2)();
|
|
|
|
// ---
|
|
|
|
assertNull(exception);
|
|
assertEquals(expected_break_count, break_count);
|