mirrors/php-src
0
0 Fork 0
mirror of https://github.com/php/php-src.git synced 2026-10-28 17:56:50 +08:00
Code Activity

sapi/phpdbg: remove dead str_type assignments before goto (#22600)

Browse Source 
The switch in phpdbg_print_breakpoints() assigned str_type per case
and jumped to a shared label that immediately recomputed the same
value from brake->type, making the pre-goto assignments dead. Set
str_type directly per case instead and drop the goto.
This commit is contained in:
Jorg Adam Sowa authored and GitHub committed 2026-07-08 15:40:23 +01:00
1 parent 35881e1298
commit e7eebb9b1e
1 file changed
+9 -18
Download Patch File Download Diff File Expand all files Collapse all files
sapi/phpdbg/phpdbg_bp.c
+9 -18
View File
@@ -1500,33 +1500,24 @@ PHPDBG_API void phpdbg_print_breakpoints(zend_ulong type) /* {{{ */
switch (brake->type) {
case PHPDBG_BREAK_METHOD_OPLINE:
str_type = "method";
goto print_opline;
break;
case PHPDBG_BREAK_FUNCTION_OPLINE:
str_type = "function";
goto print_opline;
break;
case PHPDBG_BREAK_FILE_OPLINE:
str_type = "method";
print_opline: {
if (brake->type == PHPDBG_BREAK_METHOD_OPLINE) {
str_type = "method";
} else if (brake->type == PHPDBG_BREAK_FUNCTION_OPLINE) {
str_type = "function";
} else if (brake->type == PHPDBG_BREAK_FILE_OPLINE) {
str_type = "file";
}
phpdbg_writeln("#%d\t\t#"ZEND_ULONG_FMT"\t\t(%s breakpoint)%s",
brake->id, brake->opline, str_type,
((phpdbg_breakbase_t *) brake)->disabled ? " [disabled]" : "");
} break;
str_type = "file";
break;
default:
phpdbg_writeln("#%d\t\t#"ZEND_ULONG_FMT"%s",
brake->id, brake->opline,
((phpdbg_breakbase_t *) brake)->disabled ? " [disabled]" : "");
break;
continue;
}
phpdbg_writeln("#%d\t\t#"ZEND_ULONG_FMT"\t\t(%s breakpoint)%s",
brake->id, brake->opline, str_type,
((phpdbg_breakbase_t *) brake)->disabled ? " [disabled]" : "");
} ZEND_HASH_FOREACH_END();
} break;