mirrors/php-src
0
0 Fork 0
mirror of https://github.com/php/php-src.git synced 2026-10-28 09:46:46 +08:00
Code Activity

ext/sqlite3: user zend_string* instead of char* for extension global (#24303)

Browse Source 
This allows us to prevent a needless strlen() computation
This commit is contained in:
Gina Peter Banyard authored and GitHub committed 2026-10-14 12:44:03 +01:00
1 parent 9e0e6062a4
commit 97a581232f
2 files changed
+4 -4
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

ext/sqlite3/php_sqlite3.h
+1 -1
View File
@@ -21,7 +21,7 @@ extern zend_module_entry sqlite3_module_entry;
#define phpext_sqlite3_ptr &sqlite3_module_entry
ZEND_BEGIN_MODULE_GLOBALS(sqlite3)
char *extension_dir;
zend_string *extension_dir;
int dbconfig_defensive;
ZEND_END_MODULE_GLOBALS(sqlite3)
ext/sqlite3/sqlite3.c
+3 -3
View File
@@ -60,7 +60,7 @@ static zend_always_inline void php_sqlite3_fetch_one(int n_cols, php_sqlite3_res
/* {{{ PHP_INI */
PHP_INI_BEGIN()
STD_PHP_INI_ENTRY("sqlite3.extension_dir", NULL, PHP_INI_SYSTEM, OnUpdateString, extension_dir, zend_sqlite3_globals, sqlite3_globals)
STD_PHP_INI_ENTRY("sqlite3.extension_dir", NULL, PHP_INI_SYSTEM, OnUpdateStr, extension_dir, zend_sqlite3_globals, sqlite3_globals)
#if SQLITE_VERSION_NUMBER >= 3026000
STD_PHP_INI_BOOLEAN("sqlite3.defensive", "1", PHP_INI_USER, OnUpdateBool, dbconfig_defensive, zend_sqlite3_globals, sqlite3_globals)
#endif
@@ -415,8 +415,8 @@ PHP_METHOD(SQLite3, loadExtension)
RETURN_THROWS();
}
extension_dir = SQLITE3G(extension_dir);
extension_dir_len = strlen(SQLITE3G(extension_dir));
extension_dir = ZSTR_VAL(SQLITE3G(extension_dir));
extension_dir_len = ZSTR_LEN(SQLITE3G(extension_dir));
if (IS_SLASH(extension_dir[extension_dir_len-1])) {
spprintf(&lib_path, 0, "%s%s", extension_dir, extension);