mirror of
https://github.com/nodejs/node.git
synced 2026-10-28 18:25:13 +08:00
Paul Bouchon
1b2de5e052
A `.js` file with no `"type"` in the nearest package.json has no format of its own, and `defaultGetFormat()` reports it as null. `--check` passed that null straight to `wrapSafe()`, which parses as CommonJS. Module syntax makes that parse bail out early, so the file was reported as valid and `--check` exited 0 even though it is not valid JavaScript under either goal. At load time the goal for such a file is decided by looking for module syntax in the source. Decide it the same way here, so the file is parsed as a module and its real syntax error is reported. Files whose format is known are unaffected, as are ambiguous files without module syntax, which are still parsed as CommonJS. Fixes: https://github.com/nodejs/node/issues/65202 Signed-off-by: Paul Bouchon <mail@bitpshr.net> PR-URL: https://github.com/nodejs/node/pull/65203 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>
60 lines
1.8 KiB
JavaScript
60 lines
1.8 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const { exec } = require('child_process');
|
|
const { test } = require('node:test');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
// Test both sets of arguments that check syntax
|
|
const syntaxArgs = [
|
|
'-c',
|
|
'--check',
|
|
];
|
|
|
|
// Match on the name of the `Error` but not the message as it is different
|
|
// depending on the JavaScript engine.
|
|
const syntaxErrorRE = /^SyntaxError: \b/m;
|
|
|
|
// Test bad syntax with and without shebang
|
|
[
|
|
'syntax/bad_syntax.js',
|
|
'syntax/bad_syntax',
|
|
'syntax/bad_syntax_shebang.js',
|
|
'syntax/bad_syntax_shebang',
|
|
// A `.js` file with no `"type"` in the nearest package.json, whose module
|
|
// syntax makes it load as ESM. Refs: https://github.com/nodejs/node/issues/65202
|
|
'syntax/bad_syntax_esm_ambiguous.js',
|
|
].forEach((file) => {
|
|
const path = fixtures.path(file);
|
|
|
|
// Loop each possible option, `-c` or `--check`
|
|
syntaxArgs.forEach((flag) => {
|
|
test(`Checking syntax for ${file} with ${flag}`, async (t) => {
|
|
try {
|
|
const { stdout, stderr } = await execNode(flag, path);
|
|
|
|
// No stdout should be produced
|
|
t.assert.strictEqual(stdout, '');
|
|
|
|
// Stderr should have a syntax error message
|
|
t.assert.match(stderr, syntaxErrorRE);
|
|
|
|
// stderr should include the filename
|
|
t.assert.ok(stderr.startsWith(path));
|
|
} catch (err) {
|
|
t.assert.strictEqual(err.code, 1);
|
|
}
|
|
});
|
|
});
|
|
});
|
|
|
|
// Helper function to promisify exec
|
|
function execNode(flag, path) {
|
|
const { promise, resolve, reject } = Promise.withResolvers();
|
|
exec(...common.escapePOSIXShell`"${process.execPath}" ${flag} "${path}"`, (err, stdout, stderr) => {
|
|
if (err) return reject({ ...err, stdout, stderr });
|
|
resolve({ stdout, stderr });
|
|
});
|
|
return promise;
|
|
}
|