mirrors/node
0
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-10-28 18:25:13 +08:00
Code Activity
49,265 Commits 74 Branches 969 Tags
main
Commit Graph
44 Commits
Author SHA1 Message Date
René 724ef8ef9e url: suppress warnings from url.format/url.resolve inside node_modules 
PR-URL: https://github.com/nodejs/node/pull/62005
Fixes: https://github.com/nodejs/node/issues/61724
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2026-03-08 18:32:29 +00:00
Guy Bedford d24c7313f7 module: support 'module.exports' interop export in require(esm) 
PR-URL: https://github.com/nodejs/node/pull/54563
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2024-10-01 21:13:03 -07:00
Antoine du Hamel a717fa2111 esm: fix hint on invalid module specifier 
PR-URL: https://github.com/nodejs/node/pull/51223
Fixes: https://github.com/nodejs/node/issues/51216
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-12-23 20:38:08 +00:00
Yagiz NizipliandDaniel Lemire f13dbfd43a src: move package resolver to c++ 
Co-authored-by: Daniel Lemire <daniel@lemire.me>
PR-URL: https://github.com/nodejs/node/pull/50322
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
 2023-11-17 00:16:38 +00:00
Guy Bedford 53633c033d module: exports & imports map invalid slash deprecation 
PR-URL: https://github.com/nodejs/node/pull/44477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
 2022-09-11 12:01:37 +02:00
Guy Bedford 36e2ffe6dc module: subpath folder mappings EOL 
PR-URL: https://github.com/nodejs/node/pull/40121
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-09-21 23:15:02 -07:00
Guy Bedford 7216fb118d module: deprecate trailing slash pattern mappings 
PR-URL: https://github.com/nodejs/node/pull/40039
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
 2021-09-14 23:58:56 -07:00
Dominic Elm a9dd03b1ec src: add option to disable loading native addons 
PR-URL: https://github.com/nodejs/node/pull/39977
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2021-09-10 10:54:39 -05:00
Guy Bedford 18bb2cef83 module: support pattern trailers 
PR-URL: https://github.com/nodejs/node/pull/39635
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
 2021-08-25 12:49:33 -07:00
Guy Bedford 255d6337cd esm: deprecate legacy main lookup for modules 
PR-URL: https://github.com/nodejs/node/pull/36918
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-01-30 16:31:49 +02:00
Guy Bedford 2d868fe822 module: exports pattern support 
PR-URL: https://github.com/nodejs/node/pull/34718
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2020-09-17 18:56:17 -07:00
Guy Bedford 77a515c31a module: custom --conditions flag option 
PR-URL: https://github.com/nodejs/node/pull/34637
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
 2020-08-11 14:35:44 -07:00
Guy Bedford 1237955d41 module: package "imports" field 
PR-URL: https://github.com/nodejs/node/pull/34117
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
 2020-07-09 19:19:35 -07:00
Kirill Shatskiy 8f10bb2da5 esm: share package.json cache between ESM and CJS loaders 
Refs: https://github.com/nodejs/node/issues/30674

PR-URL: https://github.com/nodejs/node/pull/33229
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
 2020-05-24 16:22:31 -07:00
Ruben Bridgewater 50ba066921 repl: improve repl autocompletion for require calls 
This improves the autocompletion for require calls. It had multiple
small issues so far. Most important: it won't suggest completions for
require statements that are fully written out. Second, it'll detect
require calls that have whitespace behind the opening bracket. Third,
it makes sure node modules are detected as such instead of only
suggesting them as folders. Last, it adds suggestions for input that
starts with backticks.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: https://github.com/nodejs/node/pull/33282
Fixes: https://github.com/nodejs/node/issues/33238
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2020-05-15 01:48:40 +02:00
Daniele Belardi 8f87d252fa esm: improve commonjs hint on module not found 
Run CommonJS resolver only if `error.code` is ERR_MODULE_NOT_FOUND.
Avoid using absolute paths in hint by:
* using a parent-relative path if the specifier is a relative path
* using a `pkg/x.js` format if the specifier is bare (e.g. `pkg/x`)

PR-URL: https://github.com/nodejs/node/pull/31906
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2020-05-03 11:29:09 -07:00
Guy Bedford 2496db8e09 module: no type module resolver side effects 
PR-URL: https://github.com/nodejs/node/pull/33086
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
 2020-04-29 22:10:35 -07:00
Guy Bedford e767ed0558 module: exports not exported for null resolutions 
PR-URL: https://github.com/nodejs/node/pull/32838
Reviewed-By: Jan Krems <jan.krems@gmail.com>
 2020-04-22 15:48:44 -07:00
Myles Borins 09a50d3c5a module: improve error for invalid package targets 
For targets that are strings that do not start with `./` or `/` the
error will now have additional information about what the programming
error is.

Closes: https://github.com/nodejs/node/issues/32034

PR-URL: https://github.com/nodejs/node/pull/32052
Fixes: https://github.com/nodejs/node/issues/32034
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Signed-off-by: Myles Borins <myles.borins@gmail.com>
 2020-04-21 21:48:14 -04:00
Jan Krems 9129ab1996 module: expose exports conditions to loaders 
PR-URL: https://github.com/nodejs/node/pull/31303
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
 2020-04-03 01:29:39 +02:00
Guy Bedford 534c204e22 module: path-only CJS exports extension searching 
PR-URL: https://github.com/nodejs/node/pull/32351
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2020-03-31 20:39:01 -06:00
Guy Bedford 58de9b46b8 module: package "exports" error refinements 
PR-URL: https://github.com/nodejs/node/pull/31625
Reviewed-By: Jan Krems <jan.krems@gmail.com>
 2020-02-18 13:34:40 +02:00
Guy Bedford 405e7b4557 module: logical conditional exports ordering 
PR-URL: https://github.com/nodejs/node/pull/31008
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
 2020-01-07 06:14:19 +02:00
Guy Bedford 8a96d05ec7 module: self resolve bug fix and esm ordering 
PR-URL: https://github.com/nodejs/node/pull/31009
Reviewed-By: Jan Krems <jan.krems@gmail.com>
 2019-12-29 11:17:21 -05:00
Guy Bedford 357a99293e module: conditional exports import condition 
PR-URL: https://github.com/nodejs/node/pull/30799
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2019-12-12 17:35:08 -05:00
Rongjian Zhang aa4c57ae7e module: add warnings for experimental flags 
PR-URL: https://github.com/nodejs/node/pull/30617
Fixes: https://github.com/nodejs/node/issues/30600
Reviewed-By: Guy Bedford <guybedford@gmail.com>
 2019-12-04 22:36:37 -05:00
Guy Bedford 2367474db4 module: conditional exports with flagged conditions 
PR-URL: https://github.com/nodejs/node/pull/29978
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2019-11-08 17:26:26 -05:00
Jan Krems 71bcd05232 module: resolve self-references 
Adds the ability to `import` or `require` a package from within its
own source code. This allows tests and examples to be written using
the package name, making them easier to reuse by consumers of the
package.

Assuming the `name` field in `package.json` is set to `my-pkg`, its
test could use `require('my-pkg')` or `import 'my-pkg'` even if
there's no `node_modules/my-pkg` while testing the package itself.

An important difference between this and relative specifiers like
`require('../')` is that self-references use the public interface
of the package as defined in the `exports` field while relative
specifiers don't.

This behavior is guarded by a new experimental flag
(`--experimental-resolve-self`).

PR-URL: https://github.com/nodejs/node/pull/29327
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2019-10-24 15:14:38 -07:00
Guy Bedford 2103ae4835 module: pkg exports validations and fallbacks 
PR-URL: https://github.com/nodejs/node/pull/28949
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
 2019-08-12 06:24:28 -04:00
Jan Krems 61f3a5c60a module: unify package exports test for CJS and ESM 
Refs: https://github.com/nodejs/modules/issues/358

PR-URL: https://github.com/nodejs/node/pull/28831
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2019-07-31 13:33:46 -07:00
Jan Krems dcb6929183 module: implement "exports" proposal for CommonJS 
Refs: https://github.com/jkrems/proposal-pkg-exports/issues/36
Refs: https://github.com/nodejs/node/pull/28568

PR-URL: https://github.com/nodejs/node/pull/28759
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
 2019-07-23 16:11:20 -07:00
Guy Bedford 6df7b6a4f9 esm: implement "pkg-exports" proposal 
Refs: https://github.com/jkrems/proposal-pkg-exports/issues/36

PR-URL: https://github.com/nodejs/node/pull/28568
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2019-07-18 14:54:16 -07:00
Ruben Bridgewater 1940114ac3 util: highlight stack frames 
Using `util.inspect` on errors is going to highlight userland and
node_module stack frames from now on. This is done by marking Node.js
core frames grey and frames that contain `node_modules` in their path
yellow.

That way it's easy to grasp what frames belong to what code.

PR-URL: https://github.com/nodejs/node/pull/27052
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-04-15 17:30:50 +02:00
James M Snell 98e54b0bd4 meta: restore original copyright header 
A prior io.js era commit inappropriately removed the
original copyright statements from the source. This
restores those in any files still remaining from that
edit.

Ref: https://github.com/nodejs/TSC/issues/174
Ref: https://github.com/nodejs/node/pull/10599
PR-URL: https://github.com/nodejs/node/pull/10155

Note: This PR was required, reviewed-by and approved
by the Node.js Foundation Legal Committee and the TSC.
There is no `Approved-By:` meta data.
 2017-03-10 11:23:48 -08:00
Gibson Fahnestock 3d2aef3979 test: s/assert.equal/assert.strictEqual/ 
Use assert.strictEqual instead of assert.equal in tests, manually
convert types where necessary.

PR-URL: https://github.com/nodejs/node/pull/10698
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
 2017-01-11 14:19:26 +00:00
cjihrig ff1efa6087 test: use const for all require() calls 
PR-URL: https://github.com/nodejs/node/pull/10550
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2017-01-02 18:28:18 -05:00
Evan Lucas e248f7f9e7 repl: allow autocompletion for scoped packages 
Previously, autocompletion of scoped packages was not supported by the
repl due to not including the `@` character in the regular expression.

PR-URL: https://github.com/nodejs/node/pull/10296
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2016-12-22 22:03:39 -08:00
Ben Noordhuis 213ede6cee repl: fix require('3rdparty') regression 
Fix module loading of third-party modules in the REPL by inheriting
module.paths from the REPL's parent module.

Commit ee72ee7 ("module,repl: remove repl require() hack") introduced
a regression where require() of modules in node_modules directories
no longer worked in the REPL (and fortunately only in the REPL.)
It turns out we didn't have test coverage for that but we do now.

Fixes: https://github.com/nodejs/node/issues/4208
PR-URL: https://github.com/nodejs/node/pull/4215
Reviewed-By: Roman Reiss <me@silverwind.io>
 2015-12-09 23:30:02 +01:00
isaacs 3e1b1dd4a9 Remove excessive copyright/license boilerplate 
The copyright and license notice is already in the LICENSE file.  There
is no justifiable reason to also require that it be included in every
file, since the individual files are not individually distributed except
as part of the entire package.
 2015-01-12 15:30:28 -08:00
Colton Baker 87286cc737 Fixed a lot of jslint errors. 
Fixes #1831
 2011-10-05 18:51:06 -07:00
Mathias Buus 39246f65df Closes #1177 remove one node_modules optimization 
to better support certain project structures.
 2011-06-14 15:32:41 -07:00
Ryan Dahl 55048cdf79 Update copyright headers 2011-03-14 17:37:05 -07:00
isaacs 81b4d45354 Better assert in the node_modules tests 2011-02-09 14:35:08 -08:00
isaacs 46513483cd node_modules module lookup, +docs and test. 2011-02-09 14:24:22 -08:00