mirrors/node
0
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-10-28 10:15:07 +08:00
Code Activity
49,265 Commits 74 Branches 969 Tags
main
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Daijiro Wachi 0fbc7d3b1e fs: throw on existing dir in cpSync with errorOnExist 
cpSync() did not honor errorOnExist when the destination directory
already existed, while the asynchronous cp() does (fixed in the commit
that added test-fs-cp-async-dir-exists-error-on-exist). Mirror that
guard in the synchronous onDir() so both APIs behave identically.

Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/64124
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2026-09-12 08:03:54 +00:00
Daijiro Wachi 095fdd3721 net: fix BlockList.fromJSON for IPv4-mapped IPv6 rules 
BlockList.toJSON() serializes IPv4-mapped IPv6 addresses in mixed
dotted-quad form (e.g. "::ffff:192.0.2.128"), but the fromJSON() rule
parser's IPv6 regexes excluded "." and capped the length at 39, so such
rules were silently corrupted or dropped on a toJSON()/fromJSON()
round-trip. Allow "." and raise the cap to 45 (the longest mixed form).

Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/64125
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
 2026-09-03 12:57:27 +00:00
Daijiro Wachi e06b0f1350 net: recognize bare IPv6 loopback addresses in isLoopback 
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63619
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2026-09-02 03:55:41 +00:00
Daijiro Wachi f7702431de doc: fix typo in tls.md 
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/64458
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
 2026-07-14 16:52:12 +00:00
Daijiro Wachi b4c7be323e util: make MIMEParams accessors case-insensitive 
MIME parameter names are case-insensitive and the parser already
ASCII-lowercases them, but MIMEParams.get(), has(), delete() and set()
compared against the raw argument. As a result a parsed parameter was
unreachable by the casing the caller used (e.g. params.get('Charset')
returned null for "Charset=utf-8"), and set() could create duplicate,
case-colliding parameters.

Lowercase the name in the accessors to match the parser, consistent with
the whatwg-mimetype reference implementation.

Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/64123
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2026-07-12 16:53:44 +00:00
Daijiro Wachi 19a95f3d4b buffer: normalize lone "\r" in Blob native line endings 
`new Blob(parts, { endings: 'native' })` failed to normalize a
standalone carriage return. The replacement regex only matched
`\n` and `\r\n`, so a lone `\r` (and runs such as `\r\r`) were
left untouched instead of being converted to the platform's
native line ending.

The WHATWG "convert line endings to native" algorithm requires
`\r`, `\n`, and `\r\n` to all be normalized. Match `\r\n` before
a lone `\r` so that CRLF collapses to a single native ending.

Refs: https://w3c.github.io/FileAPI/#convert-line-endings-to-native

Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/64115
Refs: https://w3c.github.io/FileAPI/#convert-line-endings-to-native
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
 2026-07-12 16:53:35 +00:00
Daijiro Wachi 1677526335 lib: reject string "0" in validatePort when allowZero is false 
The allowZero guard compared the raw value with `port === 0`, but
validatePort accepts strings and coerces them with `+port` in every
other clause. Since `'0' === 0` is false, string forms of zero
('0', ' 0 ', '00', '0x0', ...) slipped past the guard when
allowZero was false, while the numeric 0 was correctly rejected.

This is reachable via dgram's send(), connect(), and bind(), which
call validatePort(port, 'Port', false): passing '0' was silently
accepted instead of throwing ERR_SOCKET_BAD_PORT.

Coerce the value with `+port` so the zero check matches the rest of
the validation.

Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/64174
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
 2026-07-06 12:40:25 +00:00
Daijiro Wachi ed33235bda doc: fix Fast FFI argument count in ffi.md 
The text said functions with more than 7 arguments fall back to the
generic call path, contradicting the preceding sentence that Fast FFI
calls support up to 8 arguments.

The real limit is architecture- and type-dependent: the hard cap is 8
public arguments (src/ffi/fast.cc), but register pressure lowers the
effective count to 7 integer/pointer arguments on AArch64 and 6 on
x86-64, while floating-point arguments can use up to 8 on both. Describe
this instead of the previous, inaccurate single threshold.

Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63960
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
 2026-07-01 11:49:20 +00:00
Daijiro Wachi b0a4f162df path: fix win32 normalize false-positive on reserved names 
`path.win32.normalize()` checked for Windows reserved device names
(CON, NUL, PRN, LPT1, etc.) without first ensuring the path actually
contained a colon. When no colon was present, `indexOf(':')` returned
-1 and `isWindowsReservedName()` sliced off the last character instead
of slicing up to a colon, so any filename equal to a reserved name plus
one trailing character was wrongly treated as a device and prefixed with
`.\` — e.g. `normalize('CONx')` returned `.\CONx` instead of `CONx`.

Guard the check with `colonIndex !== -1`, matching the other reserved
name call sites which are already guarded by `colonIndex > 0`.

Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/64159
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
 2026-06-29 18:48:08 +09:00
Daijiro Wachi 07e27ad5e6 stream: proxy first own method in Readable.wrap() 
The method-proxying loop in Readable.prototype.wrap() started at
index 1, silently skipping streamKeys[0] and leaving a method at the
first own-enumerable key unproxied.

This was introduced in ee9e2a2eb6 when ArrayPrototypeForEach(
ObjectKeys(stream), ...) — which iterates from index 0 — was
rewritten as a manual for loop for performance. The faithful
translation starts at 0; a sibling loop converted in the same commit
correctly does so. The bug stayed hidden because keys[0] is usually
_events (a non-function), which the loop's typeof guard skips anyway.

Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/64048
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mattias Buelens <mattias@buelens.com>
 2026-06-23 15:24:34 +00:00
Daijiro Wachi 745a43e976 repl: lazy-load acorn and defer vm context creation 
Merely loading the repl builtin used to eagerly require acorn and
acorn-walk (~250KB of JS) and create an entire V8 context via
vm.runInNewContext() just to enumerate global property names, even
though both are only needed once REPL input is actually parsed or
tab-completion is used.

Require acorn and acorn-walk at their function-level use sites
instead, and wrap the global builtins set in getLazy(). The cost
moves to the first preview/completion/recoverable-error check,
where the one-time ~1ms is imperceptible.

Benchmark results (Linux x64, misc/startup-core.js, 20 runs):

  require-builtins.js: +3.12% ops/s (t=3.57, p<0.01)
  import-builtins.mjs: +2.20% ops/s (t=3.00, p<0.01)

In isolation, require('repl') drops from 4.64ms to 2.84ms (-39%)
and interactive `node -i` startup improves by ~13%.

Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63879
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2026-06-23 18:44:53 +09:00
Daijiro Wachi 1258a19b68 doc: fix typo in util.md 
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63961
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2026-06-20 16:14:30 +09:00
Daijiro Wachi 9fa6e8a516 stream: fix Utf8Stream stall after full write of multi-byte data 
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63964
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2026-06-20 16:12:16 +09:00
Daijiro Wachi 6e8c1717e2 stream: fix dropped first chunk in Utf8Stream buffer mode 
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63833
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mattias Buelens <mattias@buelens.com>
 2026-06-16 02:30:51 +00:00
Daijiro Wachi 5ee27e3f24 util: fix scientific notation formatting 
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63823
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
 2026-06-16 02:30:40 +00:00
Daijiro Wachi 3f42cfacf2 doc: fix typo in cli.md 
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63883
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2026-06-15 09:42:39 +00:00
Daijiro Wachi 3ad2463848 util: fix -0 formatting when numericSeparator is enabled 
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63815
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
 2026-06-15 17:55:40 +09:00
Daijiro Wachi 3501b3e446 test: add tests for 3 methods in utils 
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63765
Refs: https://app.codecov.io/gh/nodejs/node/blob/main/lib%2Futil.js
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2026-06-14 07:01:35 +00:00
Daijiro Wachi b3042c7b68 test_runner: remove unused shuffleArrayWithSeed 
shuffleArrayWithSeed was introduced along with test order
randomization but was never called: the feature picks a random
pending subtest at dequeue time using createSeededGenerator
directly. Remove the dead helper and its export, and add direct
unit coverage for createSeededGenerator's deterministic contract.

Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63847
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2026-06-13 09:02:10 +00:00
Daijiro Wachi 20fda5692e doc: fix typo in vm.md 
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63881
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2026-06-12 21:45:48 +00:00
Daijiro Wachi 8c43981593 doc: fix typo in packages.md 
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63882
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2026-06-12 21:08:07 +00:00
Daijiro Wachi 19c46abbef lib: insert argv[0] at argv[1] in setDeserializeMainFunction 
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/62928
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2026-06-10 11:36:03 +09:00
Daijiro Wachi 1be74647ca test: validate ERR_INVALID_THIS for scheduler methods 
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63764
Refs: https://app.codecov.io/gh/nodejs/node/blob/main/lib%2Ftimers%2Fpromises.js
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2026-06-09 14:21:21 +00:00
Daijiro Wachi 5e645ccf55 test: add coverage outside SEA 
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63744
Refs: https://app.codecov.io/gh/nodejs/node/blob/main/lib%2Fsea.js
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2026-06-09 23:02:56 +09:00
Daijiro Wachi 549833792e stream: check done before backpressure in stream reader 
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63699
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2026-06-09 04:53:54 +00:00
Daijiro Wachi 828560574d doc: fix a/an article typos in module, util, and dns 
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63766
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
 2026-06-08 14:42:21 +00:00
Daijiro Wachi af2e68bba5 doc: fix "used to sent" → "used to send" in http2 
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63700
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2026-06-03 17:37:13 +00:00
Daijiro Wachi 15d0c61bad doc: fix double spaces in ERR_TLS_INVALID_PROTOCOL_METHOD 
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63511
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2026-05-25 13:43:09 +00:00
Daijiro Wachi 985b608730 doc: fix double space in modules.md 
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63512
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2026-05-23 20:10:43 +00:00
Daijiro Wachi 5ff701aa28 doc: fix "options" to "option" in tls.createServer 
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63453
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2026-05-22 16:11:55 +00:00
Daijiro Wachi 7e8641a411 doc: fix typo in deprecations 
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63434
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2026-05-21 16:06:04 +00:00
Daijiro Wachi b1387e6aed lib: use Object.freeze to avoid defensive cloning in SourceMap 
PR-URL: https://github.com/nodejs/node/pull/62830
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2026-05-19 20:30:44 +02:00
Daijiro Wachi 676e9da784 repl: fix dedup comparing normalized line against raw history 
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/62886
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2026-05-15 18:02:14 +09:00
Daijiro Wachi a159b57078 lib: fix typo idenity => identity 
PR-URL: https://github.com/nodejs/node/pull/63112
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
 2026-05-13 14:22:55 +02:00
Daijiro Wachi 6916e6453f lib: fixes validator message 
PR-URL: https://github.com/nodejs/node/pull/62823
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2026-05-13 19:14:02 +09:00
Daijiro Wachi 74c6f85042 doc: use mjs/cjs blocks for callbackify null reason example 
PR-URL: https://github.com/nodejs/node/pull/62884
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2026-04-29 15:40:48 +02:00
Daijiro Wachi b6b6e960cf lib: avoid quadratic shift() in startup snapshot callback 
PR-URL: https://github.com/nodejs/node/pull/62914
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2026-04-27 23:17:57 +09:00
Daijiro Wachi adef648b26 doc: fix duplicate word "of of" in postMessageToThread 
PR-URL: https://github.com/nodejs/node/pull/62917
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
 2026-04-26 21:17:00 +09:00
Daijiro Wachi 4532d33bcc doc: fix duplicate word "to to" in util.styleText 
PR-URL: https://github.com/nodejs/node/pull/62917
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
 2026-04-26 21:16:59 +09:00
Daijiro Wachi 846806bdb4 doc: fix duplicate word "for for" in compile cache 
PR-URL: https://github.com/nodejs/node/pull/62917
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
 2026-04-26 21:16:57 +09:00
Daijiro Wachi 11f76b45ab tools: consolidate and simplify .editorconfig deps section 
PR-URL: https://github.com/nodejs/node/pull/62887
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2026-04-26 19:00:37 +09:00
Daijiro Wachi 34adeebaaf doc: fix doubled word typo in stream_iter.md 
PR-URL: https://github.com/nodejs/node/pull/62916
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2026-04-25 18:26:01 +00:00
Daijiro Wachi 10ae641e6c lib: fix FLOAT_32 and FLOAT_64 type constants in ffi 
PR-URL: https://github.com/nodejs/node/pull/62892
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
 2026-04-25 18:26:05 +09:00
Daijiro Wachi 9c4ca0a12d doc: fix typo in dns.lookup options description 
PR-URL: https://github.com/nodejs/node/pull/62882
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2026-04-24 23:11:53 +09:00
Daijiro Wachi d44a71a251 http: fix no_proxy leading-dot suffix matching 
PR-URL: https://github.com/nodejs/node/pull/62333
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2026-04-23 19:42:58 +09:00
Daijiro Wachi dd852934fc stream: ensuring cross-destruction in _duplexify to prevent leaks 
PR-URL: https://github.com/nodejs/node/pull/62824
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
 2026-04-21 09:54:35 +00:00
Daijiro Wachi a193dadf37 test: fix typos in test files 
PR-URL: https://github.com/nodejs/node/pull/61408
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
 2026-02-22 01:06:33 +01:00
Daijiro Wachi 70ec5c009d meta: fix typos in issue template config 
PR-URL: https://github.com/nodejs/node/pull/61399
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2026-01-17 11:14:31 +01:00
Daijiro Wachi 1409ac4ffb doc: restore @watilde to collaborators 
Fixes: https://github.com/nodejs/TSC/issues/1813
PR-URL: https://github.com/nodejs/node/pull/61350
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2026-01-14 11:07:37 +00:00
Daijiro Wachi f570109094 net: check if option is undefined 
PR-URL: https://github.com/nodejs/node/pull/40344
Fixes: https://github.com/nodejs/node/issues/40336
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2021-10-13 01:45:04 +00:00
Daijiro Wachi e0faf8c3e9 test: replace common port with specific number 
PR-URL: https://github.com/nodejs/node/pull/40344
Fixes: https://github.com/nodejs/node/issues/40336
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2021-10-13 01:45:03 +00:00
Daijiro WachiandLuigi Pinca 119558b6a2 net: remove unused ObjectKeys 
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/40344
Fixes: https://github.com/nodejs/node/issues/40336
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2021-10-13 01:45:02 +00:00
Daijiro WachiandLuigi Pinca c7cd8ef6c6 net: check objectMode first and then readble || writable 
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/40344
Fixes: https://github.com/nodejs/node/issues/40336
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2021-10-13 01:45:01 +00:00
Daijiro Wachi 46446623f5 net: throw error to object mode in Socket 
Fixes: https://github.com/nodejs/node/issues/40336

PR-URL: https://github.com/nodejs/node/pull/40344
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2021-10-13 01:45:00 +00:00
Daijiro Wachi 873d21cdc1 test: update wpt interfaces 
Refs: https://github.com/web-platform-tests/wpt/pull/26992

PR-URL: https://github.com/nodejs/node/pull/36659
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-01-01 23:28:55 +09:00
Daijiro Wachi 32b87f223e test: update wpt resources 
Refs: https://github.com/web-platform-tests/wpt/pull/26824

PR-URL: https://github.com/nodejs/node/pull/36659
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-01-01 23:28:54 +09:00
Daijiro Wachi 6259ddeb8c test: update wpt encoding 
Refs: https://github.com/web-platform-tests/wpt/pull/26385

PR-URL: https://github.com/nodejs/node/pull/36659
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-01-01 23:28:52 +09:00
Daijiro Wachi 6aebe2b74f test: update wpt url 
Refs: https://github.com/web-platform-tests/wpt/pull/26643

PR-URL: https://github.com/nodejs/node/pull/36659
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-01-01 23:28:51 +09:00
Daijiro Wachi e40ed2856f src: integrate URL::href() and use in inspector 
PR-URL: https://github.com/nodejs/node/pull/35912
Refs: https://github.com/nodejs/node/issues/22610
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-11-22 00:02:32 +09:00
Daijiro Wachi d6d4721f3b test: update wpt url and resource 
Refs: https://github.com/web-platform-tests/wpt/pull/26317

PR-URL: https://github.com/nodejs/node/pull/36032
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2020-11-19 10:54:53 +09:00
Daijiro Wachi 456b4e133c doc: update core-validate-commit link in guide 
PR-URL: https://github.com/nodejs/node/pull/35938
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2020-11-06 10:51:12 +00:00
Daijiro Wachi 3fab511a9e doc: fix release-schedule link in backport guide 
PR-URL: https://github.com/nodejs/node/pull/35920
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2020-11-05 03:17:13 +00:00
Daijiro Wachi 2351e2cffe test: integrate abort_controller tests from wpt 
Refs: https://github.com/web-platform-tests/wpt/pull/9361

PR-URL: https://github.com/nodejs/node/pull/35869
Refs: https://github.com/web-platform-tests/wpt/blob/master/dom/abort/event.any.js
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2020-11-01 10:16:56 +09:00
Daijiro Wachi 44571d18e5 lib: let abort_controller target be EventTarget 
The AbortController abort event should have EventTarget as a target
property of the argument event.

PR-URL: https://github.com/nodejs/node/pull/35869
Refs: https://github.com/web-platform-tests/wpt/blob/master/dom/abort/event.any.js
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2020-11-01 10:16:54 +09:00
Daijiro Wachi 802c98d65d test: add onerror test cases to policy 
Increase test coverage of lib/internal/policy/manifest.js

PR-URL: https://github.com/nodejs/node/pull/35797
Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L60
Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L146
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-10-29 23:51:55 +09:00
Daijiro Wachi bec918fb9b test: add upstream test cases to encoding 
Refs: https://github.com/web-platform-tests/wpt/pull/25988
Refs: https://github.com/web-platform-tests/wpt/pull/26158

PR-URL: https://github.com/nodejs/node/pull/35794
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-10-28 00:25:51 +09:00
Daijiro Wachi f9c9c216cc test: add upstream test cases to urlsearchparam 
Refs: https://github.com/web-platform-tests/wpt/pull/26126

PR-URL: https://github.com/nodejs/node/pull/35792
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-10-27 06:32:15 -07:00
Daijiro Wachi 7afe3af200 url: fix file url reparse 
Fixes: https://github.com/nodejs/node/issues/35571
Refs: https://github.com/whatwg/url/pull/550
Refs: https://github.com/web-platform-tests/wpt/pull/25989

PR-URL: https://github.com/nodejs/node/pull/35671
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
 2020-10-19 15:52:45 +09:00
Daijiro Wachi c143266b55 test: add a few uncovered url tests from wpt 
Refs: https://github.com/web-platform-tests/wpt/pull/25987

PR-URL: https://github.com/nodejs/node/pull/35636
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-10-16 11:43:17 +09:00
Daijiro Wachi 8a12e9994f bootstrap: use file URL instead of relative url 
PR-URL: https://github.com/nodejs/node/pull/35622
Fixes: https://github.com/nodejs/node/issues/35621
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2020-10-13 13:23:26 +00:00
Daijiro Wachi 9f2e19fa30 test: update url test for win 
PR-URL: https://github.com/nodejs/node/pull/35622
Fixes: https://github.com/nodejs/node/issues/35621
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2020-10-13 13:23:25 +00:00
Daijiro Wachi bb62f4ad9e url: file URL path normalization 
Refs: https://github.com/whatwg/url/pull/544
Refs: https://github.com/web-platform-tests/wpt/pull/25716

PR-URL: https://github.com/nodejs/node/pull/35477
Fixes: https://github.com/nodejs/node/issues/35429
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2020-10-12 15:06:55 +09:00
Daijiro Wachi d8ec5a2e92 doc: update example ICU URL 
PR-URL: https://github.com/nodejs/node/pull/35373
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-09-30 06:09:13 -07:00
Daijiro Wachi 6fc3b0ddb9 test: update wpt tests for encoding 
Refs: https://github.com/web-platform-tests/wpt/pull/25542

PR-URL: https://github.com/nodejs/node/pull/35330
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-09-28 14:03:27 +09:00
Daijiro Wachi c88d845db3 test: update wpt status for url 
PR-URL: https://github.com/nodejs/node/pull/35335
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-09-28 12:48:29 +09:00
Daijiro Wachi 589dbf1392 test: update wpt tests for url 
Refs: https://github.com/web-platform-tests/wpt/pull/25086

PR-URL: https://github.com/nodejs/node/pull/35329
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-09-28 00:36:16 +09:00
Daijiro Wachi a8971f87d3 url: support non-special URLs 
Fixes: https://github.com/nodejs/node/issues/34899
Refs: https://github.com/whatwg/url/pull/505
Refs: https://github.com/web-platform-tests/wpt/pull/25113

PR-URL: https://github.com/nodejs/node/pull/34925
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-09-20 14:19:52 +09:00
Daijiro Wachi 3b925219c3 querystring: manage percent character at unescape 
Related: https://github.com/nodejs/node/issues/33892
Fixes: https://github.com/nodejs/node/issues/35012

PR-URL: https://github.com/nodejs/node/pull/35013
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-09-03 20:43:39 -07:00
Daijiro Wachi a1faa8d852 test: fix typo in test/parallel/test-icu-punycode.js 
coverter => converter

PR-URL: https://github.com/nodejs/node/pull/34934
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
 2020-08-30 16:34:14 +09:00
Daijiro Wachi ef0701d31f tools: update dependencies in lint-md-cli-rollup 
Summary
+ Update `@zeit/ncc` to `^0.16.1` from `^0.15.2`
+ Update `unified-engine` to `^6.0.1` from `^5.1.0`
+ Run `npm audit fix`
+ Run `npm run build-node`

Refs:
+ https://github.com/unifiedjs/unified-engine/releases/tag/6.0.0
+ https://github.com/unifiedjs/unified-engine/releases/tag/6.0.1
+ https://github.com/zeit/ncc/releases/tag/0.16.0
+ https://github.com/zeit/ncc/releases/tag/0.16.1

PR-URL: https://github.com/nodejs/node/pull/26889
Refs: https://github.com/unifiedjs/unified-engine/releases/tag/6.0.0
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
 2019-03-30 13:22:03 +01:00
Daijiro Wachi 450ab14d4b doc: update a link of npm repository 
PR-URL: https://github.com/nodejs/node/pull/24969
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2018-12-13 17:23:56 -08:00
Daijiro Wachi 8ce0d4fdf1 tools: update remark-preset-lint-node to v1.3.1 
PR-URL: https://github.com/nodejs/node/pull/24642
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2018-11-28 06:53:32 -08:00
Daijiro Wachi d0bf5ca90b doc: remove trailing whitespace 
PR-URL: https://github.com/nodejs/node/pull/24642
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2018-11-28 06:53:30 -08:00
Daijiro Wachi 62d053b707 tools: fix make lint-md-rollup and run it 
PR-URL: https://github.com/nodejs/node/pull/24333
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
 2018-11-16 04:20:40 +01:00
Daijiro Wachi 195b7c2880 tools: update remark-lint to v6.0.3 from v6.0.2 
PR-URL: https://github.com/nodejs/node/pull/24333
Refs: https://github.com/remarkjs/remark-lint/releases/tag/6.0.3
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
 2018-11-16 04:20:27 +01:00
Daijiro Wachi eeed6d9858 tools: update remark version to v10 from v8 
Including the below two updates:
+ https://github.com/remarkjs/remark/releases/tag/9.0.0
+ https://github.com/remarkjs/remark/releases/tag/10.0.0

PR-URL: https://github.com/nodejs/node/pull/24333
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
 2018-11-16 04:20:13 +01:00
Daijiro Wachi 7067572a63 doc: update core-validate-commit url 
PR-URL: https://github.com/nodejs/node/pull/24331
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
 2018-11-13 09:15:18 +01:00
Daijiro Wachi d6f52f5a38 test: add test for autoDestroy in stream 
PR-URL: https://github.com/nodejs/node/pull/24127
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mathias Buus <mathiasbuus@gmail.com>
 2018-11-12 14:05:37 +09:00
Daijiro Wachi c05c73a634 test: add test cases for fsPromises 
Add tests of lchmod, chown, fchown and lchown.

PR-URL: https://github.com/nodejs/node/pull/19064
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2018-03-02 22:36:07 +01:00
Daijiro Wachi a399881773 tools: add make lint-md-clean 
PR-URL: https://github.com/nodejs/node/pull/12756
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
 2017-10-25 21:13:57 +02:00
Daijiro Wachi 212f4b981d build: add lint-md-build 
PR-URL: https://github.com/nodejs/node/pull/12756
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
 2017-10-25 21:13:49 +02:00
Daijiro Wachi f1329543d6 tools: add lint-md command in Makefile 
PR-URL: https://github.com/nodejs/node/pull/12756
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
 2017-10-25 21:13:22 +02:00
Daijiro Wachi 92dff06122 tools: use remark-preset-lint-node in .remarkrc 
PR-URL: https://github.com/nodejs/node/pull/12756
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
 2017-10-25 21:12:12 +02:00
Daijiro Wachi 2e1d092ff1 tools: introduce remark-preset-lint-node 
PR-URL: https://github.com/nodejs/node/pull/12756
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
 2017-10-25 21:11:56 +02:00
Daijiro Wachi 503342e4e7 tools: introduce remark-cli@3.0.1 
PR-URL: https://github.com/nodejs/node/pull/12756
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
 2017-10-25 21:11:44 +02:00
Daijiro Wachi f91218c58f doc: fix missing newline character 
PR-URL: https://github.com/nodejs/node/pull/16447
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
 2017-10-25 12:21:43 +02:00
Daijiro Wachi 986be03a4c doc: fix doc styles 
CONTRIBUTING.md
  + L857: Unused definition
  + L861: Unused definition
  + L863: Unused definition

doc/api/assert.md
  + L719: Unused definition

doc/api/async_hooks.md
  + L460: Missing code-language flag

doc/api/child_process.md
  + L1362: Unused definition

doc/api/dns.md
  + L674: Unused definition

doc/api/esm.md
  + L178: Missing code-language flag

doc/api/http.md
  + L1868: Unused definition
  + L1887: Unused definition
  + L1888: Unused definition
  + L1889: Unused definition
  + L1916: Unused definition
  + L1917: Unused definition

doc/api/https.md
  + L260: Unused definition

doc/api/os.md
  + L1226: Unused definition

doc/api/process.md
  + L1888: Unused definition

doc/api/stream.md
  + L2227: Definitions with the same identifier

doc/guides/writing-and-running-benchmarks.md
  + L1: Missing newline character at end of file

Refs: https://github.com/nodejs/node/pull/12756
PR-URL: https://github.com/nodejs/node/pull/16385
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2017-10-24 18:04:18 +02:00
Daijiro Wachi 7294f57c0d doc: fix docs style in util.md 
Summary
  + L582: Cell should be padded
  + L589: Cell should be padded
  + L590: Cell should be padded
  + L600: Cell should be padded
  + L622: Cell should be padded

PR-URL: https://github.com/nodejs/node/pull/14711
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
 2017-08-13 20:19:12 +02:00
Daijiro Wachi 003ba0b0e2 doc: fix docs style in intl.md 
Summary
  + L43: Add missing final pipe in table fence
  + L45: Add missing final pipe in table fence
  + L46: Add missing final pipe in table fence
  + L47: Add missing final pipe in table fence
  + L48: Add missing final pipe in table fence
  + L49: Add missing final pipe in table fence
  + L50: Add missing final pipe in table fence
  + L51: Add missing final pipe in table fence
  + L52: Add missing final pipe in table fence
  + L53: Add missing final pipe in table fence
  + L54: Add missing final pipe in table fence
  + L55: Add missing final pipe in table fence

PR-URL: https://github.com/nodejs/node/pull/14711
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
 2017-08-13 20:18:50 +02:00
Daijiro Wachi 8b2c61c169 doc: fix api docs style 
doc/api/cluster.md
  L337: Use the definition link

doc/api/deprecations.md
  L106: Fix the definition link name

doc/api/errors.md
  L901: Remove unused definition

PR-URL: https://github.com/nodejs/node/pull/13970
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
 2017-07-03 11:06:36 +02:00