mirror of
https://github.com/nodejs/node.git
synced 2026-10-28 18:25:13 +08:00
test: remove common.skipIfInspectorEnabled()
common.skipIfInspectorEnabled() is only used once in all of the tests. The test is more clear (in my opinion, at least) without the abstraction so put the check directly in the test. Additionally, it honestly looks like an error (which is how I noticed it in the first place) and that someone mistyped the far more common skipIfInspectorDisabled(). PR-URL: https://github.com/nodejs/node/pull/29993 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This commit is contained in:
1 parent
ce72cd779a
commit
fa2ba05bcd
2 files changed
+3
-8
No files matched your search
@@ -651,12 +651,6 @@ function skipIfInspectorDisabled() {
|
||||
}
|
||||
}
|
||||
|
||||
function skipIfInspectorEnabled() {
|
||||
if (process.features.inspector) {
|
||||
skip('V8 inspector is enabled');
|
||||
}
|
||||
}
|
||||
|
||||
function skipIfReportDisabled() {
|
||||
if (!process.config.variables.node_report) {
|
||||
skip('Diagnostic reporting is disabled');
|
||||
@@ -789,7 +783,6 @@ module.exports = {
|
||||
skipIf32Bits,
|
||||
skipIfEslintMissing,
|
||||
skipIfInspectorDisabled,
|
||||
skipIfInspectorEnabled,
|
||||
skipIfReportDisabled,
|
||||
skipIfWorker,
|
||||
|
||||
|
||||
@@ -1,7 +1,9 @@
|
||||
'use strict';
|
||||
|
||||
const common = require('../common');
|
||||
common.skipIfInspectorEnabled();
|
||||
if (process.features.inspector) {
|
||||
common.skip('V8 inspector is enabled');
|
||||
}
|
||||
|
||||
const fixtures = require('../common/fixtures');
|
||||
const assert = require('assert');
|
||||
|
||||
Reference in new issue
Block a user