mirror of
https://github.com/nodejs/node.git
synced 2026-10-28 18:25:13 +08:00
events: remove return value on addEventListener
The `addEventListener()` should not return a value. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/37696 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
1 parent
5fdcfb33d7
commit
ef459d86ee
2 files changed
+6
-2
No files matched your search
@@ -329,7 +329,7 @@ class EventTarget {
|
||||
|
||||
if (signal) {
|
||||
if (signal.aborted) {
|
||||
return false;
|
||||
return;
|
||||
}
|
||||
// TODO(benjamingr) make this weak somehow? ideally the signal would
|
||||
// not prevent the event target from GC.
|
||||
|
||||
@@ -25,7 +25,11 @@ const {
|
||||
controller.abort();
|
||||
et.dispatchEvent(new Event('test'));
|
||||
strictEqual(count, 2, 'Aborting on the controller removes the listener');
|
||||
et.addEventListener('test', handler, { signal: controller.signal });
|
||||
// See: https://github.com/nodejs/node/pull/37696 , adding an event listener
|
||||
// should always return undefined.
|
||||
strictEqual(
|
||||
et.addEventListener('test', handler, { signal: controller.signal }),
|
||||
undefined);
|
||||
et.dispatchEvent(new Event('test'));
|
||||
strictEqual(count, 2, 'Passing an aborted signal never adds the handler');
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user