mirrors/node
0
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-10-28 10:15:07 +08:00
Code Activity

build: don't pass --mode argument to V8 test-runner

Browse Source 
V8's test-runner dropped the `--mode` argument some time back, and now
produces the following error if run with it:
  run-tests.py: error: no such option: --mode

PR-URL: https://github.com/nodejs/node/pull/39055
Refs: https://github.com/nodejs/node/pull/35705
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Richard Lau authored and Node.js GitHub Bot committed 2021-06-23 09:59:44 +00:00
1 parent bf9ce95db7
commit d65514bc29
1 file changed
+2 -2
Download Patch File Download Diff File Expand all files Collapse all files
Makefile
+2 -2
View File
@@ -667,12 +667,12 @@ test-v8: v8 ## Runs the V8 test suite on deps/v8.
test-v8-intl: v8
export PATH="$(NO_BIN_OVERRIDE_PATH)" && \
deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) \
--mode=$(BUILDTYPE_LOWER) intl \
intl \
$(TAP_V8_INTL)
test-v8-benchmarks: v8
export PATH="$(NO_BIN_OVERRIDE_PATH)" && \
deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) --mode=$(BUILDTYPE_LOWER) \
deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) \
benchmarks \
$(TAP_V8_BENCHMARKS)