mirror of
https://github.com/nodejs/node.git
synced 2026-10-28 10:15:07 +08:00
deps: V8: cherry-pick cc9a8a37445e
Original commit message:
fix overflow check in error formatting
Bug: v8:12494
Change-Id: Iba2684173296aa236f1a1c73a5606c21472eff06
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3426634
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Gus Caplan <snek@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78909}
Refs: https://github.com/v8/v8/commit/cc9a8a37445eeffff17474020bb6038c2f9af9fc
PR-URL: https://github.com/nodejs/node/pull/41823
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This commit is contained in:
2 files changed
+4
-3
No files matched your search
+1
-1
@@ -36,7 +36,7 @@
|
||||
|
||||
# Reset this number to 0 on major V8 upgrades.
|
||||
# Increment by one for each non-official patch applied to deps/v8.
|
||||
'v8_embedder_string': '-node.12',
|
||||
'v8_embedder_string': '-node.13',
|
||||
|
||||
##### V8 defaults for Node.js #####
|
||||
|
||||
|
||||
Vendored
+3
-2
@@ -306,7 +306,8 @@ MaybeHandle<Object> ErrorUtils::FormatStackTrace(Isolate* isolate,
|
||||
const bool in_recursion = isolate->formatting_stack_trace();
|
||||
const bool has_overflowed = i::StackLimitCheck{isolate}.HasOverflowed();
|
||||
Handle<Context> error_context;
|
||||
if (!in_recursion && error->GetCreationContext().ToHandle(&error_context)) {
|
||||
if (!in_recursion && !has_overflowed &&
|
||||
error->GetCreationContext().ToHandle(&error_context)) {
|
||||
DCHECK(error_context->IsNativeContext());
|
||||
|
||||
if (isolate->HasPrepareStackTraceCallback()) {
|
||||
@@ -322,7 +323,7 @@ MaybeHandle<Object> ErrorUtils::FormatStackTrace(Isolate* isolate,
|
||||
isolate->RunPrepareStackTraceCallback(error_context, error, sites),
|
||||
Object);
|
||||
return result;
|
||||
} else if (!has_overflowed) {
|
||||
} else {
|
||||
Handle<JSFunction> global_error =
|
||||
handle(error_context->error_function(), isolate);
|
||||
|
||||
|
||||
Reference in new issue
Block a user