mirror of
https://github.com/nodejs/node.git
synced 2026-10-28 10:15:07 +08:00
src: fix ssize_t error from nghttp2.h
The "node_http2.h" include reordering enforced by clang-format broke Electron's Node.js upgrade on Windows. ssize_t is a part of the POSIX standard and it's not available on Windows, so the fix for this is to include "node.h" which typedefs it on Windows in https://github.com/nodejs/node/blob/bb4dff783ddb3b20c67041f7ccef796c335c2407/src/node.h#L212-L220. Refs: https://github.com/electron/electron/pull/35350#discussion_r954890551 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/44393 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
1 parent
d40a622016
commit
72aafbdba7
1 file changed
+3
-2
+3
-2
@@ -3,8 +3,9 @@
|
||||
|
||||
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
|
||||
|
||||
// FIXME(joyeecheung): nghttp2.h needs stdint.h to compile on Windows
|
||||
#include <cstdint>
|
||||
// clang-format off
|
||||
#include "node.h" // nghttp2.h needs ssize_t
|
||||
// clang-format on
|
||||
#include "nghttp2/nghttp2.h"
|
||||
|
||||
#include "env.h"
|
||||
|
||||
Reference in new issue
Block a user