mirror of
https://github.com/nodejs/node.git
synced 2026-10-28 10:15:07 +08:00
benchmark,tools: fix napi benchmarks on GHA
The GHA benchmark never built the addons of benchmark/napi, and its --debug-node build made benchmark/common.js look for them in build/Debug. Build them when the napi category runs, and pick the build type as test/common does. Refs: https://github.com/nodejs/node/pull/66395 Signed-off-by: Nigro Simone <nigro.simone@gmail.com> PR-URL: https://github.com/nodejs/node/pull/66423 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This commit is contained in:
1 parent
cbac135e5a
commit
6f71b9ba66
2 files changed
+6
-2
No files matched your search
@@ -140,7 +140,7 @@ jobs:
|
||||
--arg withPerfetto ${{ matrix.perfetto || false }} \
|
||||
--arg ccache '(import <nixpkgs> {}).sccache' \
|
||||
--run '
|
||||
make build-ci -j4 V=1
|
||||
make build-ci -j4 V=1 ${{ contains(format(' {0} ', inputs.category), ' napi ') && '&& make bench-addons-build' || '' }}
|
||||
' tools/nix/ci-shell.nix
|
||||
env:
|
||||
SCCACHE_LOCAL_RW_MODE: READ_ONLY
|
||||
|
||||
+5
-1
@@ -470,7 +470,11 @@ module.exports = {
|
||||
return process.binding(bindingName);
|
||||
}
|
||||
},
|
||||
buildType: process.features.debug ? 'Debug' : 'Release',
|
||||
// As in test/common: a --debug-node build is still a Release build, and its
|
||||
// addons are in build/Release.
|
||||
buildType: process.config.target_defaults ?
|
||||
process.config.target_defaults.default_configuration :
|
||||
'Release',
|
||||
createBenchmark(fn, configs, options) {
|
||||
return new Benchmark(fn, configs, options);
|
||||
},
|
||||
|
||||
Reference in new issue
Block a user