mirror of
https://github.com/nodejs/node.git
synced 2026-10-28 10:15:07 +08:00
build,tools: fix addon build deadlock on errors
PR-URL: https://github.com/nodejs/node/pull/61321 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
1 parent
0f15923583
commit
45e37d95eb
1 file changed
+1
-1
@@ -58,8 +58,8 @@ def rebuild_addons(args):
|
||||
|
||||
# We buffer the output and print it out once the process is done in order
|
||||
# to avoid interleaved output from multiple builds running at once.
|
||||
return_code = process.wait()
|
||||
stdout, stderr = process.communicate()
|
||||
return_code = process.returncode
|
||||
if return_code != 0:
|
||||
print(f'Failed to build addon in {test_dir}:')
|
||||
if stdout:
|
||||
|
||||
Reference in new issue
Block a user