mirror of
https://github.com/nodejs/node.git
synced 2026-10-28 10:15:07 +08:00
src: set SSL_OP_ALLOW_CLIENT_RENEGOTIATION
This commit sets SSL_OP_ALLOW_CLIENT_RENEGOTIATION for OpenSSL 3.0 as this option is not set by default as it was in previous versions. Without this option set there are a few tests that fail when linked against OpenSSl 3.0.0-alpha-17, for example test-https-client-renegotiation-limit.js. I'm not sure we should be setting this for OpenSSL 3.0 or not, but I'll take a closer look at the implications but if nothing else this would allow for us to update to alpha-17 in the mean time. PR-URL: https://github.com/nodejs/node/pull/38753 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
This commit is contained in:
1 parent
1efa8fe1aa
commit
44e382290a
1 file changed
+3
@@ -475,6 +475,9 @@ void SecureContext::Init(const FunctionCallbackInfo<Value>& args) {
|
||||
// SSLv3 is disabled because it's susceptible to downgrade attacks (POODLE.)
|
||||
SSL_CTX_set_options(sc->ctx_.get(), SSL_OP_NO_SSLv2);
|
||||
SSL_CTX_set_options(sc->ctx_.get(), SSL_OP_NO_SSLv3);
|
||||
#if OPENSSL_VERSION_MAJOR >= 3
|
||||
SSL_CTX_set_options(sc->ctx_.get(), SSL_OP_ALLOW_CLIENT_RENEGOTIATION);
|
||||
#endif
|
||||
|
||||
// Enable automatic cert chaining. This is enabled by default in OpenSSL, but
|
||||
// disabled by default in BoringSSL. Enable it explicitly to make the
|
||||
|
||||
Reference in new issue
Block a user