mirror of
https://github.com/nodejs/node.git
synced 2026-10-28 18:25:13 +08:00
tools: fix small not-quite-a-bug in find-inactive-tsc.mjs
The current code attempts to count votes from people who were not members at the start of the 3 month period, resulting in `NaN` being tallied for their votes. PR-URL: https://github.com/nodejs/node/pull/41469 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Tierney Cyren <hello@bnb.im>
This commit is contained in:
1 parent
79e07a42f9
commit
426df1b836
1 file changed
+3
-1
@@ -118,7 +118,9 @@ async function getVotingRecords(tscMembers, votes) {
|
||||
await fs.promises.readFile(path.join('.tmp', vote), 'utf8')
|
||||
);
|
||||
for (const member in voteData.votes) {
|
||||
votingRecords[member]++;
|
||||
if (tscMembers.includes(member)) {
|
||||
votingRecords[member]++;
|
||||
}
|
||||
}
|
||||
}
|
||||
return votingRecords;
|
||||
|
||||
Reference in new issue
Block a user