benchmark: fix buffer option in buffer read/write benchmarks

main() read `buf` instead of `buffer`, so every run measured
Buffer.allocUnsafeSlow() even when labeled buffer=fast. Also benchmark
the slow variant and trim the byteLength matrix.

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/66604
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

benchmark/buffers/buffer-read-with-byteLength.js

@@ -10,14 +10,14 @@ const types = [
 ];
 
 const bench = common.createBenchmark(main, {
-  buffer: ['fast'],
+  buffer: ['fast', 'slow'],
   type: types,
   n: [1e6],
-  byteLength: [1, 2, 3, 4, 5, 6],
+  byteLength: [1, 2, 4, 6],
 });
 
-function main({ n, buf, type, byteLength }) {
-  const buff = buf === 'fast' ?
+function main({ n, buffer, type, byteLength }) {
+  const buff = buffer === 'fast' ?
     Buffer.alloc(8) :
     Buffer.allocUnsafeSlow(8);
   const fn = `read${type}`;

benchmark/buffers/buffer-read.js

@@ -20,13 +20,13 @@ const types = [
 ];
 
 const bench = common.createBenchmark(main, {
-  buffer: ['fast'],
+  buffer: ['fast', 'slow'],
   type: types,
   n: [1e6],
 });
 
-function main({ n, buf, type }) {
-  const buff = buf === 'fast' ?
+function main({ n, buffer, type }) {
+  const buff = buffer === 'fast' ?
     Buffer.alloc(8) :
     Buffer.allocUnsafeSlow(8);
   const fn = `read${type}`;

benchmark/buffers/buffer-write.js

@@ -27,7 +27,7 @@ const types = [
 ];
 
 const bench = common.createBenchmark(main, {
-  buffer: ['fast'],
+  buffer: ['fast', 'slow'],
   type: types,
   n: [1e6],
 });
@@ -70,8 +70,8 @@ const byteLength = {
   writeIntBE: 6,
 };
 
-function main({ n, buf, type }) {
-  const buff = buf === 'fast' ?
+function main({ n, buffer, type }) {
+  const buff = buffer === 'fast' ?
     Buffer.alloc(8) :
     Buffer.allocUnsafeSlow(8);
   const fn = `write${type}`;