mirror of
https://github.com/nodejs/node.git
synced 2026-10-28 18:25:13 +08:00
doc: mention adding Fixes to collaborator onboarding PR
Also update the example to include the Fixes url. PR-URL: https://github.com/nodejs/node/pull/37097 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
This commit is contained in:
1 parent
4e833b6059
commit
35fe310b0a
1 file changed
+6
-3
+6
-3
@@ -204,11 +204,14 @@ needs to be pointed out separately during the onboarding.
|
||||
## Exercise: Make a PR adding yourself to the README
|
||||
|
||||
* Example:
|
||||
<https://github.com/nodejs/node/commit/ce986de829457c39257cd205067602e765768fb0>
|
||||
* For raw commit message: `git log ce986de829457c39257cd205067602e765768fb0
|
||||
-1`
|
||||
<https://github.com/nodejs/node/commit/b58fe52692659c0bc25ddbe6afa7f4ae2c7f14a8>
|
||||
* For raw commit message:
|
||||
`git show --format=%Bb58fe52692659c0bc25ddbe6afa7f4ae2c7f14a8`
|
||||
* Collaborators are in alphabetical order by GitHub username.
|
||||
* Optionally, include your personal pronouns.
|
||||
* Add the `Fixes: <collaborator-nomination-issue-url>` to the commit message
|
||||
so that when the commit lands, the nomination issue url will be
|
||||
automatically closed.
|
||||
* Label your pull request with the `doc`, `notable-change`, and `fast-track`
|
||||
labels.
|
||||
* Run CI on the PR. Use the `node-test-pull-request` CI task.
|
||||
|
||||
Reference in new issue
Block a user