mirrors/node
0
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-10-28 10:15:07 +08:00
Code Activity

test: skip retries in DNS timeout coverage

Browse Source 
A single query attempt exercises the configured timeout without the
default retry backoff. Retry behavior has separate coverage.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Codex
PR-URL: https://github.com/nodejs/node/pull/65980
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
This commit is contained in:
Filip Skokan committed 2026-09-13 14:01:17 +02:00
1 parent fb1b8717ff
commit 1677ee7af2
1 file changed
+3 -2
Download Patch File Download Diff File Expand all files Collapse all files
test/parallel/test-dns-channel-timeout.js
+3 -2
View File
@@ -22,10 +22,11 @@ for (const ctor of [dns.Resolver, dns.promises.Resolver]) {
for (const timeout of [-1, 0, 1]) new ctor({ timeout }); // OK
}
// One attempt is enough to exercise the timeout without retry backoff.
for (const timeout of [0, 1, 2]) {
const server = dgram.createSocket('udp4');
server.bind(0, '127.0.0.1', common.mustCall(() => {
const resolver = new dns.Resolver({ timeout });
const resolver = new dns.Resolver({ timeout, tries: 1 });
resolver.setServers([`127.0.0.1:${server.address().port}`]);
resolver.resolve4('nodejs.org', common.mustCall((err) => {
assert.throws(() => { throw err; }, {
@@ -40,7 +41,7 @@ for (const timeout of [0, 1, 2]) {
for (const timeout of [0, 1, 2]) {
const server = dgram.createSocket('udp4');
server.bind(0, '127.0.0.1', common.mustCall(() => {
const resolver = new dns.promises.Resolver({ timeout });
const resolver = new dns.promises.Resolver({ timeout, tries: 1 });
resolver.setServers([`127.0.0.1:${server.address().port}`]);
resolver.resolve4('nodejs.org').catch(common.mustCall((err) => {
assert.throws(() => { throw err; }, {