Merge pull request #138921 from liggitt/drop-redundant-dv

Drop declarative minimum that is redundant with field type
This commit is contained in:
Kubernetes Prow Robot authored and GitHub committed 2026-05-09 11:17:17 +05:30
commit ea231e60e7
3 files changed
-16

No files matched your search

-12
View File
@@ -761,12 +761,6 @@ func Validate_PodGroupSpec(
}); len(e) != 0 {
errs = append(errs, e...)
}
if e := validate.IfOption(ctx, op, fldPath, obj, oldObj, "WorkloadAwarePreemption", true,
func(ctx context.Context, op operation.Operation, fldPath *field.Path, obj, oldObj *int32) field.ErrorList {
return validate.Minimum(ctx, op, fldPath, obj, oldObj, -2147483648)
}); len(e) != 0 {
errs = append(errs, e...)
}
return
}
oldVal := safe.Field(oldObj,
@@ -1086,12 +1080,6 @@ func Validate_PodGroupTemplate(
}); len(e) != 0 {
errs = append(errs, e...)
}
if e := validate.IfOption(ctx, op, fldPath, obj, oldObj, "WorkloadAwarePreemption", true,
func(ctx context.Context, op operation.Operation, fldPath *field.Path, obj, oldObj *int32) field.ErrorList {
return validate.Minimum(ctx, op, fldPath, obj, oldObj, -2147483648)
}); len(e) != 0 {
errs = append(errs, e...)
}
return
}
oldVal := safe.Field(oldObj,
@@ -288,7 +288,6 @@ message PodGroupSpec {
// +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:optional
// +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:immutable
// +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:maximum=1000000000 # HighestUserDefinablePriority
// +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:minimum=-2147483648
optional int32 priority = 7;
}
@@ -417,7 +416,6 @@ message PodGroupTemplate {
// +k8s:ifDisabled("WorkloadAwarePreemption")=+k8s:forbidden
// +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:optional
// +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:maximum=1000000000 # HighestUserDefinablePriority
// +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:minimum=-2147483648
optional int32 priority = 7;
}
@@ -200,7 +200,6 @@ type PodGroupTemplate struct {
// +k8s:ifDisabled("WorkloadAwarePreemption")=+k8s:forbidden
// +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:optional
// +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:maximum=1000000000 # HighestUserDefinablePriority
// +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:minimum=-2147483648
Priority *int32 `json:"priority,omitempty" protobuf:"varint,7,opt,name=priority"`
}
@@ -455,7 +454,6 @@ type PodGroupSpec struct {
// +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:optional
// +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:immutable
// +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:maximum=1000000000 # HighestUserDefinablePriority
// +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:minimum=-2147483648
Priority *int32 `json:"priority,omitempty" protobuf:"varint,7,opt,name=priority"`
}