Drop k8s.io/utils/integer

The package is entirely deprecated, has a single user in k/k, with a
trivial replacement. This drops it and prevents its re-introduction.

Signed-off-by: Stephen Kitt <skitt@redhat.com>

.import-restrictions

@@ -4,3 +4,7 @@ rules:
   - selectorRegexp: github[.]com/google/cadvisor
     forbiddenPrefixes:
       - github.com/google/cadvisor
+  # Forbid k8s.io/utils/integer
+  - selectorRegexp: k8s[.]io/utils/integer
+    forbiddenPrefixes:
+      - k8s.io/utils/integer

pkg/controller/deployment/util/deployment_util.go

@@ -40,7 +40,6 @@ import (
 	"k8s.io/klog/v2"
 	"k8s.io/kubernetes/pkg/controller"
 	labelsutil "k8s.io/kubernetes/pkg/util/labels"
-	"k8s.io/utils/integer"
 )
 
 const (
@@ -523,7 +522,7 @@ func getReplicaSetFraction(logger klog.Logger, rs apps.ReplicaSet, d apps.Deploy
 	scaleBase := *(rs.Spec.Replicas)
 	// deploymentMaxReplicasBeforeScale should normally be a positive value, and we have made sure that it is not a zero.
 	newRSsize := (float64(scaleBase * deploymentMaxReplicas)) / float64(deploymentMaxReplicasBeforeScale)
-	return integer.RoundToInt32(newRSsize) - *(rs.Spec.Replicas)
+	return int32(math.Round(newRSsize)) - *(rs.Spec.Replicas)
 }
 
 // RsListFromClient returns an rsListFunc that wraps the given client.

vendor/k8s.io/utils/integer/integer.go

@@ -1,79 +0,0 @@
-/*
-Copyright 2016 The Kubernetes Authors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
-package integer
-
-import "math"
-
-// IntMax returns the maximum of the params.
-// Deprecated: for new code, use the max() builtin instead.
-func IntMax(a, b int) int {
-	if b > a {
-		return b
-	}
-	return a
-}
-
-// IntMin returns the minimum of the params.
-// Deprecated: for new code, use the min() builtin instead.
-func IntMin(a, b int) int {
-	if b < a {
-		return b
-	}
-	return a
-}
-
-// Int32Max returns the maximum of the params.
-// Deprecated: for new code, use the max() builtin instead.
-func Int32Max(a, b int32) int32 {
-	if b > a {
-		return b
-	}
-	return a
-}
-
-// Int32Min returns the minimum of the params.
-// Deprecated: for new code, use the min() builtin instead.
-func Int32Min(a, b int32) int32 {
-	if b < a {
-		return b
-	}
-	return a
-}
-
-// Int64Max returns the maximum of the params.
-// Deprecated: for new code, use the max() builtin instead.
-func Int64Max(a, b int64) int64 {
-	if b > a {
-		return b
-	}
-	return a
-}
-
-// Int64Min returns the minimum of the params.
-// Deprecated: for new code, use the min() builtin instead.
-func Int64Min(a, b int64) int64 {
-	if b < a {
-		return b
-	}
-	return a
-}
-
-// RoundToInt32 rounds floats into integer numbers.
-// Deprecated: use math.Round() and a cast directly.
-func RoundToInt32(a float64) int32 {
-	return int32(math.Round(a))
-}

vendor/modules.txt

@@ -1195,7 +1195,6 @@ k8s.io/utils/dump
 k8s.io/utils/exec
 k8s.io/utils/exec/testing
 k8s.io/utils/inotify
-k8s.io/utils/integer
 k8s.io/utils/internal/third_party/forked/golang/golang-lru
 k8s.io/utils/internal/third_party/forked/golang/net
 k8s.io/utils/io