mirrors/kubernetes
0
0 Fork 0
mirror of https://github.com/kubernetes/kubernetes.git synced 2026-10-28 13:45:38 +08:00
Code Activity

Merge pull request #142743 from Jefftree/store-validation-deepcopy

Browse Source 
apiserver: remove redundant DeepCopyObject calls in Store validation hooks
This commit is contained in:
kubernetes-prow[bot] authored and GitHub committed 2026-10-26 21:53:01 +00:00
2 parents e96327d86b 67a395d492
commit 1738b0a029
1 file changed
+3 -3
Download Patch File Download Diff File Expand all files Collapse all files
staging/src/k8s.io/apiserver/pkg/registry/generic/registry/store.go
+3 -3
View File
@@ -622,7 +622,7 @@ func (e *Store) create(ctx context.Context, obj runtime.Object, createValidation
// at this point we have a fully formed object. It is time to call the validators that the apiserver
// handling chain wants to enforce.
if createValidation != nil {
if err := createValidation(ctx, obj.DeepCopyObject()); err != nil {
if err := createValidation(ctx, obj); err != nil {
return nil, err
}
}
@@ -839,7 +839,7 @@ func (e *Store) Update(ctx context.Context, name string, objInfo rest.UpdatedObj
// at this point we have a fully formed object. It is time to call the validators that the apiserver
// handling chain wants to enforce.
if createValidation != nil {
if err := createValidation(ctx, obj.DeepCopyObject()); err != nil {
if err := createValidation(ctx, obj); err != nil {
return nil, nil, err
}
}
@@ -910,7 +910,7 @@ func (e *Store) Update(ctx context.Context, name string, objInfo rest.UpdatedObj
// at this point we have a fully formed object. It is time to call the validators that the apiserver
// handling chain wants to enforce.
if updateValidation != nil {
if err := updateValidation(ctx, obj.DeepCopyObject(), existing.DeepCopyObject()); err != nil {
if err := updateValidation(ctx, obj, existing); err != nil {
return nil, nil, err
}
}