mirrors/guava
0
0 Fork 0
mirror of https://github.com/google/guava.git synced 2026-10-28 08:35:50 +08:00
Code Activity

Bump Error Prone, and remove ReferenceEquality suppressions for Thread comparisons.

Browse Source 
The suppressions are no longer necessary as of cl/937358981, which is [part of Error Prone 2.51.0](https://github.com/google/error-prone/commit/1259c50f8f164fb021dbdde08651602964ae6fd8).

RELNOTES=n/a
PiperOrigin-RevId: 1008358244
This commit is contained in:
cpovirk authored and Google Java Core Libraries committed 2026-10-27 14:02:13 -07:00
1 parent c5e32cfaa9
commit 89eb04b66e
4 files changed
+6 -34
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

android/guava/src/com/google/common/util/concurrent/ExecutionSequencer.java
+1 -15
View File
@@ -320,12 +320,6 @@ public final class ExecutionSequencer {
this.sequencer = sequencer;
}
/*
* We compare two Thread instances with ==: For concurrency correctness, we need to know whether
* they are actually the same thread, even if they are instances of some user subclass that
* overrides Thread.equals.
*/
@SuppressWarnings("ReferenceEquality")
@Override
public void execute(Runnable task) {
// If this operation was successfully cancelled already, calling the runnable will be a noop.
@@ -398,15 +392,7 @@ public final class ExecutionSequencer {
}
}
@SuppressWarnings({
"ShortCircuitBoolean",
/*
* We compare two Thread instances with ==: For concurrency correctness, we need to know
* whether they are actually the same thread, even if they are instances of some user subclass
* that overrides Thread.equals.
*/
"ReferenceEquality",
})
@SuppressWarnings("ShortCircuitBoolean")
@Override
public void run() {
Thread currentThread = Thread.currentThread();
android/pom.xml
+2 -2
View File
@@ -59,8 +59,8 @@
<build-helper-maven-plugin.version>3.6.2</build-helper-maven-plugin.version>
<caliper.version>1.0-beta-3</caliper.version>
<central-publishing-maven-plugin.version>0.11.0</central-publishing-maven-plugin.version>
<error_prone_annotations.version>2.50.0</error_prone_annotations.version>
<error_prone_core.version>2.50.0</error_prone_core.version>
<error_prone_annotations.version>2.51.0</error_prone_annotations.version>
<error_prone_core.version>2.51.0</error_prone_core.version>
<exec-maven-plugin.version>3.5.0</exec-maven-plugin.version>
<failureaccess.version>1.0.3</failureaccess.version>
<gummy-bears-api-24-version>0.15.0</gummy-bears-api-24-version>
guava/src/com/google/common/util/concurrent/ExecutionSequencer.java
+1 -15
View File
@@ -320,12 +320,6 @@ public final class ExecutionSequencer {
this.sequencer = sequencer;
}
/*
* We compare two Thread instances with ==: For concurrency correctness, we need to know whether
* they are actually the same thread, even if they are instances of some user subclass that
* overrides Thread.equals.
*/
@SuppressWarnings("ReferenceEquality")
@Override
public void execute(Runnable task) {
// If this operation was successfully cancelled already, calling the runnable will be a noop.
@@ -398,15 +392,7 @@ public final class ExecutionSequencer {
}
}
@SuppressWarnings({
"ShortCircuitBoolean",
/*
* We compare two Thread instances with ==: For concurrency correctness, we need to know
* whether they are actually the same thread, even if they are instances of some user subclass
* that overrides Thread.equals.
*/
"ReferenceEquality",
})
@SuppressWarnings("ShortCircuitBoolean")
@Override
public void run() {
Thread currentThread = Thread.currentThread();
pom.xml
+2 -2
View File
@@ -60,8 +60,8 @@
<build-helper-maven-plugin.version>3.6.2</build-helper-maven-plugin.version>
<caliper.version>1.0-beta-3</caliper.version>
<central-publishing-maven-plugin.version>0.11.0</central-publishing-maven-plugin.version>
<error_prone_annotations.version>2.50.0</error_prone_annotations.version>
<error_prone_core.version>2.50.0</error_prone_core.version>
<error_prone_annotations.version>2.51.0</error_prone_annotations.version>
<error_prone_core.version>2.51.0</error_prone_core.version>
<exec-maven-plugin.version>3.5.0</exec-maven-plugin.version>
<failureaccess.version>1.0.3</failureaccess.version>
<gummy-bears-api-24-version>0.15.0</gummy-bears-api-24-version>