mirrors/fx
0
0 Fork 0
mirror of https://github.com/vercel-labs/fx.git synced 2026-10-28 10:15:17 +08:00
Code Activity

Report Node header discovery failures cleanly

Browse Source 
Use build-time fatal diagnostics when automatic Node header discovery cannot run or allocate its result. This keeps expected configuration failures out of panic paths.
This commit is contained in:
Pranit committed 2026-08-16 08:31:14 -04:00
1 parent 09deb7f30d
commit 293dfd07f7
1 file changed
+3 -3
Download Patch File Download Diff File Expand all files Collapse all files
build.zig
+3 -3
View File
@@ -415,10 +415,10 @@ fn discoverNodeIncludeDir(b: *std.Build) []const u8 {
&.{ "node", "-p", "require('node:path').join(require('node:path').dirname(process.execPath), '..', 'include', 'node')" },
&code,
.ignore,
) catch @panic("Node.js is required to locate node_api.h; pass -Dnode-include-dir=<path>");
if (code != 0) @panic("could not locate node_api.h; pass -Dnode-include-dir=<path>");
) catch std.process.fatal("Node.js is required to locate node_api.h; pass -Dnode-include-dir=<path>", .{});
if (code != 0) std.process.fatal("could not locate node_api.h; pass -Dnode-include-dir=<path>", .{});
const trimmed = std.mem.trim(u8, out, " \t\r\n");
return b.allocator.dupe(u8, trimmed) catch @panic("could not allocate Node include path");
return b.allocator.dupe(u8, trimmed) catch std.process.fatal("could not allocate Node include path", .{});
}
fn readGitCommit(b: *std.Build) []const u8 {