mirrors/electron
0
0 Fork 0
mirror of https://github.com/electron/electron.git synced 2026-10-28 11:44:46 +08:00
Code Activity
31,446 Commits 483 Branches 3,892 Tags
main
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Shelley Vohr a0b2810640 chore: add ability to log native deprecation warnings (#18681) 
* chore: add ability to log native deprecation warnings

* take std::string, handle conversion later

* address feedback from @ckerr's review

* simplify with feedback from zcbenz
 2019-06-19 08:46:36 +09:00
Shelley Vohr 02710ef574 refactor: make templateImage a property on nativeImage (#18124) 
* refactor: make templateImage a property on nativeImage

* Update docs/api/native-image.md

Co-Authored-By: codebytere <codebytere@github.com>

* fix nativeImage prototype deprecation

* update for new property name

* Update docs/api/native-image.md

Co-Authored-By: codebytere <codebytere@github.com>
 2019-05-07 06:52:07 -07:00
Shelley Vohr cfb6e847a0 refactor: allow embedder overriding of internal FS calls (#17906) (#18183) 2019-05-07 06:44:32 -07:00
Shelley Vohr 2b9bd0f56f fix crash when passing empty string to recording (#17698) 2019-04-05 11:19:06 -07:00
Shelley Vohr c4020308c9 test: remove non-applicable processMemoryInfo specs (#17679) 2019-04-05 07:53:25 -07:00
Shelley Vohr 9c3cb55ef2 refactor: make accessibilitySupportEnabled a property on app (#17362) 
* refactor: make accessibilitySupport a prop on app

* fix docs

* update spec
 2019-04-04 19:49:04 -07:00
Shelley Vohr 8c8eac88a4 build: fix spec-main linting for 'only' (#17666) 2019-04-03 11:19:39 -07:00
Shelley Vohr 0431997c8d refactor: make applicationMenu a property on app (#17361) 2019-04-02 13:36:57 -07:00
Shelley Vohr d412582f72 docs: clarify cookie domain normalization (#17590) 2019-04-02 13:04:20 -07:00
Shelley Vohr 8ea33d69ac fix: match net module headers & http.IncomingMessage headers (#17517) 
* fix: match net module headers & http.IncomingMessage headers

* update net doc for cleanliness

* address feedback from review

* Update spec/api-net-spec.js

Co-Authored-By: codebytere <codebytere@github.com>

* add special cookie case
 2019-04-02 07:41:19 -07:00
Shelley Vohr 808783a5e4 fix: crashReporter.getParameters() takes no params (#17459) 2019-03-28 15:04:16 -04:00
Shelley Vohr 4e57a732a8 feat: allow windows to be excluded from the windows menu (#17404) 
* feat: allow windows to be excluded from the windows menu

* excludedfromWindowsMenu => excludedFromShownWindowsMenu

* implement no-op for win & linux
 2019-03-27 08:10:23 -04:00
Shelley Vohr 34eb5d0815 fix: correctly return properties on the netLog module (#17525) 2019-03-25 22:40:38 -04:00
Shelley Vohr 4ec2f8b67b chore: remove some bot config options (#17506) 2019-03-22 19:29:23 -05:00
Shelley Vohr a5febe392c chore: update issue templates with guidelines (#17505) 2019-03-22 16:56:52 -07:00
Shelley Vohr b25279df89 docs: clarify documentation for getLastCrashReport (#17458) 
* docs: clarify documentation for getLastCrashReport

* address feedback
 2019-03-20 15:34:21 -07:00
Shelley Vohr b140a82fe8 fix: take foreground visibility into account for isVisible on macOS (#17463) 2019-03-20 15:33:59 -07:00
Shelley Vohr 1d93bc76cd feat: expose colorSpace to display object (#17405) 
* feat: expose colorSpace to display object

* update doc

* add a spec
 2019-03-19 15:12:03 -07:00
Shelley Vohr 879462af4b docs: document modernization initiative more clearly (#17376) 
* docs: document modernization initiative more clearly
 2019-03-19 10:31:45 -07:00
Shelley Vohr 2fb9085e5b feat: add tray.getTitle() (#17385) 
* feat: add tray.getTitle

* fix spec
 2019-03-18 12:40:34 -07:00
Shelley Vohr 38d75010c7 chore: rename atomBinding to electronBinding (#17419) 2019-03-18 12:37:06 -07:00
Shelley Vohr db29978fe0 fix: throw error when inserting menu items out-of-range (#17401) 
* fix: throw error when inserting menu items out-of-range

* also check pos < 0
 2019-03-18 07:58:42 -07:00
Shelley Vohr f09f43a4a9 chore: remove unused arg parsing code in dialog (#17420) 2019-03-18 07:58:03 -07:00
Shelley Vohr 961c9a88a8 feat: promisify dialog.showCertificateTrustDialog() (#17181) 
* feat: promisify dialog.showCertificateTrustDialog()

* update promisification doc
 2019-03-15 09:02:50 +09:00
Shelley Vohr cb4ede453f chore: add deprecation helper for fnToProperty (#17377) 
* chore: add deprecation helper for fnToProperty

* add a test
 2019-03-14 15:19:19 -07:00
Shelley Vohr 12b6a0f5b2 feat: add native emoji picker (#17359) 2019-03-14 13:39:52 -07:00
Shelley Vohr aa8b66aae1 feat: promisify session.getBlobData() (#17303) 2019-03-14 08:11:01 -07:00
Shelley Vohr d9234798d3 chore: clean up promise resoution with helpers (#17268) 2019-03-13 14:30:21 -07:00
Shelley Vohr 3e5a98b5f4 feat: promisify In-App Purchase (#17355) 
* feat: promisify In-App Purchase

* use mate::Arguments in GetProducts
 2019-03-13 13:56:01 -07:00
Shelley Vohr 5eb75e91b9 chore: fix default_app showMessageBox (#17357) 2019-03-12 14:10:18 -07:00
Shelley Vohr 8991c0056e feat: promisify dialog.showMessageBox() (#17298) 
* feat: promisify dialog.showMessageBox()

* address feedback from review
 2019-03-12 11:06:59 -07:00
Shelley Vohr 9ea6c01e02 feat: promisify session.clearAuthCache() (#17259) 
* feat: promisify session.clearAuthCache()

* remove unused callback runner helpers
 2019-03-08 18:41:42 -08:00
Shelley Vohr fc10620082 feat: promisify session cache methods (#17185) 2019-03-08 14:42:03 -08:00
Shelley Vohr 2769e75b49 feat: promisify session proxy methods (#17222) 2019-03-08 12:51:12 -08:00
Shelley Vohr e5e6aa207c feat: promisify ses.clearHostResolverCache() (#17229) 2019-03-08 10:26:17 -08:00
Shelley Vohr bbfa63fd9d feat: promisify session.clearStorageData() (#17249) 2019-03-08 09:02:30 -08:00
Shelley Vohr 17dab8f239 build: turn gpg signing off for bootstrap (#17282) 2019-03-07 18:11:31 -08:00
Shelley Vohr a4418a9014 chore: add static promise resolution helpers (#17223) 
* chore: add static promise resolution helpers

* address feedback

* address feedback from review
 2019-03-07 18:07:04 -08:00
Shelley Vohr 6cb7b8d3a4 feat: promisify dialog.showSaveDialog() (#17054) 
* feat: promisify dialog.showSaveDialog()

* address some feedback from review

* filename => filePath

* fix last filename => filePath
 2019-03-05 13:48:20 -08:00
Shelley Vohr e05985145b feat: promisify dialog.showOpenDialog() (#16973) 
* feat: promisify dialog.showOpenDialog()

* address feedback from review

* address feedback from review
 2019-03-05 05:54:48 -08:00
Shelley Vohr 544d8a423c feat: allow MenuItems to work optionally when hidden (#16853) 
* feat: allow MenuItems to work optionally when hidden

* fix: actually include forward_declaration
 2019-02-28 17:00:54 +00:00
Shelley Vohr 5ecda17c7a refactor: make shell.ShowItemInFolder asynchronous (#17121) 
* fix: add scoped_blocking_calls to platform_win

https://chromium-review.googlesource.com/c/chromium/src/+/1191582

* feat: make ShowItemInFolder async

* address feedback from review

* fix build
 2019-02-27 12:58:23 +00:00
Shelley Vohr be8f9bd597 chore: clean up issue templates (#17085) 
* chore: clean up issue templates

* address feedback from review

* cleanup
 2019-02-26 17:51:29 +09:00
Shelley Vohr d9c7735a04 chore: augment promisifyMultiArg deprecation (#17066) 2019-02-25 18:25:25 -08:00
Shelley Vohr 3edc497d3d feat: show user gesture type in click event (#16954) 2019-02-20 12:20:24 +00:00
Shelley Vohr cc5ed24e23 chore: properly template the Then promise helper (#17050) 2019-02-19 21:46:59 +00:00
Shelley Vohr ef2e7d95fe chore: add Then helper for native promises (#16978) 2019-02-18 14:25:28 +00:00
Shelley Vohr 1e8ac79e6f docs: document the Event interface (#16966) 
* docs: document the Event interface

* update docs deps

* pull new VoidFunction update
 2019-02-15 12:08:45 -08:00
Shelley Vohr de27911661 feat: promisify webContents.savePage() (#16742) 
* feat: promisify webContents.savePage()

* no need to make compatible w callbacks, we're breaking it

* fix promise resolve type

* address feedback from review

* fix promise return text

* update smoke test
 2019-02-14 09:03:28 -08:00
Shelley Vohr 46a24c82ff feat: add Touch ID authentication support for macOS (#16707) 
This PR adds Touch ID authentication support for macOS with two new `SystemPreferences` methods.

1. `systemPreferences.promptForTouchID()` returns a Promise that resolves with `true` if successful and rejects with an error message if authentication could not be completed.
2. `systemPreferences.isTouchIDAvailable()` returns a Boolean that's `true` if this device is a Mac running a supported OS that has the necessary hardware for Touch ID and `false` otherwise.
 2019-02-13 18:36:28 -08:00
Shelley Vohr 319c2853df chore: move ts-smoke tests to core (#16930) 
* chore: move ts smoke tests to core

* fix: fix paths for tsconfig / ts-smoke runner

* update ts-defs version

* do not lintr
 2019-02-13 15:24:28 -08:00
Shelley Vohr fed5b99a9f feat: promisify contentTracing.getTraceBufferUsage() (#16600) 
* feat: promsify contentTracing.getTraceBufferUsage()

* deprecate getTraceBufferUsage

* address feedback from review

* properly deprecate
 2019-02-13 13:24:57 -08:00
Shelley Vohr ca83d36426 feat: promisify app.dock.show() (#16904) 
* feat: promisify app.dock.show

* add a spec
 2019-02-12 21:06:33 -08:00
Shelley Vohr cfba59929a fix: backport patch to sync exposed crypto (#16822) 
* fix: backport patch to sync exposed crypto

* add two new specs

* fix iv length

* fix formatting
 2019-02-12 11:57:11 -08:00
Shelley Vohr bf276ecc69 feat: add new components to Display structure (#16870) 
* feat: add new components to Display structure

* add internal property

* expose colorDepth

* add specs
 2019-02-12 05:34:42 -10:00
Shelley Vohr 3effa6f20c feat: add support for scroll lock accelerator (#16873) 2019-02-11 09:13:13 -10:00
Shelley Vohr 1898f91620 fix: enable property having no effect on submenus (#16835) 2019-02-08 18:07:08 -08:00
Shelley Vohr ccf46a57bc fix: display empty menu item for non-visible submenus (#16832) 
* fix: display empty menu item for nonvisible submenus

* use Chromium UI string ID
 2019-02-08 13:19:01 -08:00
Shelley Vohr 062778c031 fix: don't construct submenu if it's invisible (#16834) 2019-02-08 12:54:39 -08:00
Shelley Vohr e790dbd737 chore: add standalone function deprecation helper (#16782) 2019-02-08 09:50:11 -08:00
Shelley Vohr 9ebba76c03 chore: improve existing error preservation in promisify (#16815) 
This PR better preserves existing behavior in `deprecate.promisify()` in the cases where the promise fails. Previously, if a callback was only called with `data` instead of `err, data` and the promise was rejected, `data` would be populated with `err`, which could be confusing to users. This makes it such that `err` is called back on promise rejection if a callback is called with `err, data` a la Node.js.
 2019-02-07 10:25:20 -08:00
Shelley Vohr c6fc5a23fc Revert "build: hack around GitHub upload API failure / flake (#16663)" (#16802) 
This reverts commit ab503c7e43.
 2019-02-06 16:51:45 -08:00
Shelley Vohr a569dad8c5 build: remove non-arm vstsJobs (#16793) 2019-02-06 13:36:17 -08:00
Shelley Vohr 84eef16755 chore: depend on mojo audio and video in BUILD.gn (#16785) 2019-02-06 11:03:39 -08:00
Shelley Vohr 858781ba83 feat: allow Menu.buildFromTemplate() to accept MenuItems (#16697) 
* feat: allow Menu.buildFromTemplate to accept MenuItems

* add another spec

* fix linter error

* add submenu spec
 2019-02-06 10:04:40 -08:00
Shelley Vohr 8946cfd4f1 chore: fix dependency vulnerabilities (#16756) 2019-02-05 15:19:55 -08:00
Shelley Vohr 793d6c3691 chore: remove release notes semantic PR map (#16758) 2019-02-05 15:19:26 -08:00
Shelley Vohr e098d08728 docs: we shouldn't promisify net apis (#16736) 2019-02-04 22:25:59 -08:00
Shelley Vohr f303caa87c refactor: remove ServiceWorker APIs from WebContents (#16717) 2019-02-04 22:22:46 -08:00
Shelley Vohr 698d348168 feat: support capslock and numlock as accelerators (#16719) 
* feat: support capslock as accelerator

* also add numlock
 2019-02-04 15:54:59 -08:00
Shelley Vohr f142aae9eb chore: remove unused variable in removeWindow (#16715) 2019-02-04 15:00:39 -08:00
Shelley Vohr a9991f5451 chore: fix falsy comments edge case in release notes (#16720) 2019-02-04 14:57:38 -08:00
Shelley Vohr bae09643c1 docs: fix referrer typedef in OnCompletedDetails (#16661) 2019-02-01 07:54:31 -08:00
Shelley Vohr c8c1be7ae5 feat: add window removeMenu() method (#16570) 
* feat: add window removeMenu() method

* chore: remove original method from docs and code

* retain backwards compatibility
 2019-01-31 10:58:23 -08:00
Shelley Vohr ba57e1d991 feat: promisify contentTracing recording APIs (#16584) 
* feat: promisify contentTracing.startRecording()

* feat: promisify contentTracing.stopRecording()

* test: convert specs for new promisified apis

* chore: deprecate and ensure legacy tests work
 2019-01-30 18:53:55 -08:00
Shelley Vohr 641b47f384 feat: promisify contentTracing.getCategories() (#16583) 
* feat: promisify contentTracing.getCategories()

* deprecate contentTracing/getCategories
 2019-01-30 12:39:55 -08:00
Shelley Vohr c7677b23e6 fix: enable and update osr (#16517) 
* fix: enable OSR

* fix some macos errors

* fix client reset not in guard

* fix things not rendering on mac
 2019-01-30 09:33:32 -08:00
Shelley Vohr 6e131f2121 docs: remove nonexistent contentTracing methods (#16597) 2019-01-30 08:33:56 -08:00
Shelley Vohr a25f82c91f fix: reject with error when url not loaded (#16571) 
* fix: reject with error when url not loaded

* improve descriptive spec naming
 2019-01-28 14:42:36 -08:00
Shelley Vohr d105dcc0d3 feat: promisify webContents.hasServiceWorker() (#16535) 
* feat: promisify contents.hasServiceWorker()

* spec: add initial test for hasServiceWorker()
 2019-01-26 10:23:16 -08:00
Shelley Vohr 5a35c3a279 chore: fix promisify helper (#16544) 
* chore: fix promise deprecation helper

* fix deprecations

* update deprecation tests
 2019-01-25 14:23:24 -08:00
Shelley Vohr f431ce4971 build: fix individual asset downloading in release script (#16493) 
* Revert "build: fix release asset download for now (#16486)"

This reverts commit 7df531bc4e.

* build: clean up asset downloading
 2019-01-23 11:47:36 -08:00
Shelley Vohr 7df531bc4e build: fix release asset download for now (#16486) 2019-01-22 08:53:52 -08:00
Shelley Vohr 51961fccfa build: temporarily disable arm to unblock nightlies (#16479) 2019-01-21 15:22:56 -08:00
Shelley Vohr 3ca87d205f feat: make zoomLevel/zoomFactor sync (#16410) 
* feat: make zoomLevel/zoomFactor sync

* update ts defs dep
 2019-01-20 23:40:27 -08:00
Shelley Vohr 441c9ce376 feat: promisify desktopCapturer.getSources (#16427) 
* feat: promisify desktopCapturer.getSources

* fix doc

* fix docs lint error
 2019-01-18 15:29:32 -08:00
Shelley Vohr 3417c42bfd chore: always try to nuke tags (#16451) 2019-01-18 14:00:15 -08:00
Shelley Vohr f105c84349 test: ensure legacy callback functions work (#16436) 
* test: test legacy callback functions

* add TODO removal comments

* fix callback spec
 2019-01-17 14:17:16 -08:00
Shelley Vohr 720197f9c8 fix: correctly handle IPC for promise-based methods (#16433) 2019-01-17 12:08:54 -08:00
Shelley Vohr 1f2b02c18f feat: promisify protocol.isProtocolHandled() (#16423) 
* feat: promisify protocol

* fix base::Bind and specs

* update documentation

* make callback-compatible

* async awaitify tests
 2019-01-17 09:05:10 -08:00
Shelley Vohr 8e2ab8b20b refactor: promise_util promise creation (#16401) 
* refactor: promise_util creation

* enter correct contexts on resolve/reject

* return Local in helper

* set context correctly

* forgot one
 2019-01-15 09:54:59 -08:00
Shelley Vohr 0881fd6397 feat: split openExternal into sync and async (#16176) 
* feat: split openExternal into sync and async

* v8::Locker => mate::Locker

* fix: enter js env when resolving promise
 2019-01-14 20:35:21 -08:00
Shelley Vohr df62e78b71 chore: remove unused deps (#16373) 2019-01-12 16:47:09 +01:00
Shelley Vohr e2b1394ad1 redo: size -> length (#16370) 2019-01-11 09:53:13 -08:00
Shelley Vohr ca218b6395 test: allow retries for flaky mas loginitem specs (#16347) 2019-01-10 14:15:47 -08:00
Shelley Vohr d0ae89befa chore: fix tag cleanup (#16353) 2019-01-10 13:42:42 -08:00
Shelley Vohr 03e16ffa57 chore: s/size/length (#16351) 2019-01-10 10:58:23 -08:00
Shelley Vohr f72d5a4184 chore: fix electron.d.ts file upload (#16335) 2019-01-08 22:51:49 -08:00
Shelley Vohr b4299a2872 chore: pass dryRun arg correctly (#16333) 
* chore: pass dryRun arg correctly

* no log
 2019-01-08 18:09:42 -08:00
Shelley Vohr 826063a2f7 chore: github => octokit in release notes (#16332) 2019-01-08 16:20:54 -08:00