mirrors/dbx
0
0 Fork 0
mirror of https://github.com/t8y2/dbx.git synced 2026-10-28 09:45:37 +08:00
Code Activity

fix(query): remove result surface border

Browse Source
This commit is contained in:
二丫讲梵 authored and GitHub committed 2026-10-23 01:08:29 +08:00
1 parent ab2ca96df2
commit 75e984a6e8
2 files changed
+11 -9
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

apps/desktop/src/components/layout/ContentArea.vue
+1 -1
View File
@@ -2152,7 +2152,7 @@ defineExpose({
</div>
</Pane>
<Pane v-if="(resultsPaneOpen || resultOnly) && !editorOnly" class="min-h-0" :size="resultOnly ? 100 : resultsPaneSize" :min-size="resultOnly ? 100 : 20">
<div data-query-result-surface class="h-full flex flex-col border border-transparent" :style="activeResultColor ? { borderColor: activeResultColor } : undefined">
<div data-query-result-surface class="h-full flex flex-col">
<!--
The shared result surface (resultOnly) is always mounted regardless of
whether the active tab has run a query yet, and this toolbar is the only
apps/desktop/src/components/layout/__tests__/ContentArea.resultConnectionColors.spec.ts
Vendored
+10 -8
View File
@@ -93,24 +93,26 @@ describe("query result connection colors", () => {
expect(tab.resultRuns?.[0]?.connectionId).toBe("test");
});
it("colors each run from its source and keeps the selected result color after changing the editor connection", async () => {
const { host, tab, connections } = await mountResults();
it.each(["tabs", "list"] as const)("keeps the selected source marker in %s mode when the editor connection changes", async (displayMode) => {
const { host, tab, connections, settings } = await mountResults();
const markers = [...host.querySelectorAll<HTMLElement>("[data-result-run-tab] [data-result-connection-color]")];
expect(markers.map((marker) => marker.style.backgroundColor)).toEqual(["#22c55e", "#ef4444"]);
const surface = host.querySelector<HTMLElement>("[data-query-result-surface]")!;
expect(surface.style.borderColor).toBe("#22c55e");
settings.editorSettings.resultRunDisplayMode = displayMode;
await nextTick();
const selectedMarker = () => host.querySelector<HTMLElement>(displayMode === "tabs" ? '[data-result-run-tab][aria-selected="true"] [data-result-connection-color]' : "[data-query-result-surface] [data-result-connection-color]");
expect(selectedMarker()?.style.backgroundColor).toBe("#22c55e");
tab.connectionId = "production";
await nextTick();
expect(surface.style.borderColor).toBe("#22c55e");
expect(selectedMarker()?.style.backgroundColor).toBe("#22c55e");
tab.activeResultRunId = "production-run";
await nextTick();
expect(surface.style.borderColor).toBe("#ef4444");
expect(selectedMarker()?.style.backgroundColor).toBe("#ef4444");
connections.connections[1]!.color = "#3b82f6";
await nextTick();
expect(surface.style.borderColor).toBe("#3b82f6");
expect(selectedMarker()?.style.backgroundColor).toBe("#3b82f6");
connections.connections[1]!.color = "";
await nextTick();
expect(surface.style.borderColor).toBe("");
expect(selectedMarker()).toBeNull();
});
it("colors ordinary result sets without retained runs and removes markers for an uncolored connection", async () => {