maint: prefer enums over macros for sources used for multiple programs

* src/chown.h (enum chown_modes): New type.
(CHOWN_CHOWN, CHOWN_CHGRP): Define as an enum instead of a macro.
* src/chown-chgrp.c (chown_mode): Use "enum chown_modes" instead of
"int".
* src/chown-chown.c (chown_mode): Likewise.
* src/ls.h (enum ls_modes): New type.
(LS_LS, LS_MULTI_COL, LS_LONG_FORMAT): Define as an enum instead of a
macro.
* src/ls-dir.c (ls_mode): Use "enum ls_modes" instead of "int".
* src/ls-ls.c (ls_mode): Likewise.
* src/ls-vdir.c (ls_mode): Likewise.
* src/uname.h (enum uname_modes): New type.
(UNAME_UNAME, UNAME_ARCH): Define as an enum instead of a macro.
* src/uname-arch.c (uname_mode): Use "enum uname_modes" instead of
"int".
* src/uname-uname.c (uname_mode): Likewise.

src/chown-chgrp.c

@@ -1,2 +1,2 @@
 #include "chown.h"
-int chown_mode = CHOWN_CHGRP;
+enum chown_modes chown_mode = CHOWN_CHGRP;

src/chown-chown.c

@@ -1,2 +1,2 @@
 #include "chown.h"
-int chown_mode = CHOWN_CHOWN;
+enum chown_modes chown_mode = CHOWN_CHOWN;

src/chown.h

@@ -1,7 +1,10 @@
-/* This is for the 'chown' program. */
-#define CHOWN_CHOWN 1
+enum chown_modes
+{
+  /* This is for the 'chown' program.  */
+  CHOWN_CHOWN,
 
-/* This is for the 'chgrp' program.  */
-#define CHOWN_CHGRP 2
+  /* This is for the 'chgrp' program.  */
+  CHOWN_CHGRP,
+};
 
-extern int chown_mode;
+extern enum chown_modes chown_mode;

src/ls-dir.c

@@ -1,2 +1,2 @@
 #include "ls.h"
-int ls_mode = LS_MULTI_COL;
+enum ls_modes ls_mode = LS_MULTI_COL;

src/ls-ls.c

@@ -1,2 +1,2 @@
 #include "ls.h"
-int ls_mode = LS_LS;
+enum ls_modes ls_mode = LS_LS;

src/ls-vdir.c

@@ -1,2 +1,2 @@
 #include "ls.h"
-int ls_mode = LS_LONG_FORMAT;
+enum ls_modes ls_mode = LS_LONG_FORMAT;

src/ls.h

@@ -1,10 +1,13 @@
-/* This is for the 'ls' program.  */
-#define LS_LS 1
+enum ls_modes
+{
+  /* This is for the 'ls' program.  */
+  LS_LS,
 
-/* This is for the 'dir' program.  */
-#define LS_MULTI_COL 2
+  /* This is for the 'dir' program.  */
+  LS_MULTI_COL,
 
-/* This is for the 'vdir' program.  */
-#define LS_LONG_FORMAT 3
+  /* This is for the 'vdir' program.  */
+  LS_LONG_FORMAT
+};
 
-extern int ls_mode;
+extern enum ls_modes ls_mode;

src/uname-arch.c

@@ -1,2 +1,2 @@
 #include "uname.h"
-int uname_mode = UNAME_ARCH;
+enum uname_modes uname_mode = UNAME_ARCH;

src/uname-uname.c

@@ -1,2 +1,2 @@
 #include "uname.h"
-int uname_mode = UNAME_UNAME;
+enum uname_modes uname_mode = UNAME_UNAME;

src/uname.h

@@ -1,7 +1,10 @@
-/* This is for the 'uname' program. */
-#define UNAME_UNAME 1
+enum uname_modes
+{
+  /* This is for the 'uname' program.  */
+  UNAME_UNAME,
 
-/* This is for the 'arch' program.  */
-#define UNAME_ARCH 2
+  /* This is for the 'arch' program.  */
+  UNAME_ARCH
+};
 
-extern int uname_mode;
+extern enum uname_modes uname_mode;