Files
arrow/ci/scripts/python_wheel_validate_contents.py
Rok Mihevc 889141a013 GH-49831: [Python] Withhold annotations from Python wheel until they are complete (#50168)
### Rationale for this change

Since 24.0, pyarrow ships annotations and `py.typed` marker while the type stubs are still incomplete. This makes type checkers trust the partial stubs and report false errors in downstream code (e.g. Module has no attribute "all" for `pyarrow.compute`). Some type checkers also consume bundled `.pyi` files even without `py.typed`, so the stubs need to be withheld from wheels for now. See #49831.

### What changes are included in this PR?

This temporarily omits both `pyarrow/py.typed` and the bundled `pyarrow-stubs` / `.pyi` files from built wheels until the stubs are complete. Wheel-content validation now asserts that neither `py.typed` nor `.pyi` files are present, and wheel build scripts no longer request stub docstring injection while stubs are not installed.

### Are these changes tested?

Wheel-content validation has been updated to check the intended absence of `py.typed` and `.pyi` files.

### Are there any user-facing changes?

Type checkers no longer pick up pyarrow's incomplete stubs from wheels.
* GitHub Issue: #49831

Authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
2026-06-29 09:32:34 +02:00

107 lines
4.0 KiB
Python

# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
import argparse
import ast
from pathlib import Path
import re
import zipfile
def _count_docstrings(source):
"""Count docstrings in module, function, and class bodies."""
tree = ast.parse(source)
count = 0
for node in ast.walk(tree):
if isinstance(node, (ast.Module, ast.FunctionDef,
ast.AsyncFunctionDef, ast.ClassDef)):
if (node.body
and isinstance(node.body[0], ast.Expr)
and isinstance(node.body[0].value, ast.Constant)
and isinstance(node.body[0].value.value, str)):
count += 1
return count
# TODO(GH-48970): Check stubs ARE present once annotations are complete
def validate_wheel(path):
p = Path(path)
wheels = list(p.glob('*.whl'))
error_msg = f"{len(wheels)} wheels found but only 1 expected ({wheels})"
assert len(wheels) == 1, error_msg
with zipfile.ZipFile(wheels[0]) as wheel_zip:
outliers = [
info.filename for info in wheel_zip.filelist if not re.match(
r'(pyarrow/|pyarrow-[-.\w\d]+\.dist-info/|pyarrow\.libs/)', info.filename
)
]
assert not outliers, f"Unexpected contents in wheel: {sorted(outliers)}"
for filename in ('LICENSE.txt', 'NOTICE.txt'):
assert any(
info.filename.split("/")[-1] == filename for info in wheel_zip.filelist
), f"{filename} is missing from the wheel."
assert not any(
info.filename == "pyarrow/py.typed" for info in wheel_zip.filelist
), "pyarrow/py.typed is present in the wheel."
source_root = Path(__file__).resolve().parents[2]
stubs_dir = source_root / "python" / "pyarrow-stubs" / "pyarrow"
assert stubs_dir.exists(), f"Stub source directory not found: {stubs_dir}"
expected_stub_files = {
f"pyarrow/{stub_file.relative_to(stubs_dir).as_posix()}"
for stub_file in stubs_dir.rglob("*.pyi")
}
wheel_stub_files = {
info.filename
for info in wheel_zip.filelist
if info.filename.startswith("pyarrow/") and info.filename.endswith(".pyi")
}
assert not (wheel_stub_files == expected_stub_files), (
"Wheel .pyi files do not differ from python/pyarrow-stubs/pyarrow.\n"
f"Missing in wheel: {sorted(expected_stub_files - wheel_stub_files)}\n"
f"Unexpected in wheel: {sorted(wheel_stub_files - expected_stub_files)}"
)
assert not wheel_stub_files, (
f"Wheel contains unexpected .pyi files: {sorted(wheel_stub_files)}"
)
wheel_docstring_count = sum(
_count_docstrings(wheel_zip.read(wsf).decode("utf-8"))
for wsf in wheel_stub_files
)
print(f"Found {wheel_docstring_count} docstring(s) in wheel stubs.")
assert wheel_docstring_count == 0, "Docstrings found in wheel stub files."
print(f"The wheel: {wheels[0]} seems valid.")
def main():
parser = argparse.ArgumentParser()
parser.add_argument("--path", type=str, required=True,
help="Directory where wheel is located")
args = parser.parse_args()
validate_wheel(args.path)
if __name__ == '__main__':
main()