0 Fork 0

mirror of https://github.com/microsoft/vscode.git synced 2026-10-28 13:26:52 +08:00

Files

T

History

Rohan Malpani d4dd44c192 sessions: reveal hierarchy guides on pane hover (#343631 )

<!-- Thank you for submitting a Pull Request. Please:
* Read our Pull Request guidelines:

https://github.com/microsoft/vscode/wiki/How-to-Contribute#pull-requests
* Associate an issue with the Pull Request.
* Ensure that the code is up-to-date with the `main` branch.
* Include a description of the proposed changes and how to test them.
-->

Fixes #343511.

## Summary

Reveal all session/sub-session hierarchy guides while the pointer is
anywhere inside the Agents sessions pane, including headers and empty
space. Leaving the pane restores the quiet resting appearance while
preserving existing selection and keyboard-focus guides.

- Use pane-wide CSS hover and remove redundant per-row hover tracking.
- Keep row actions and collapse controls row-local; preserve connector
styling and standalone completed-chat exclusions.
- Add rendered-style regression coverage and multi-hierarchy fixtures,
including compact rows and high-contrast variants.

## Validation

- `./scripts/test.sh --run
src/vs/sessions/contrib/sessions/test/browser/sessionsList.test.ts
--grep 'session chat rows' --reporter dot` — passed, 98 tests.
- `npm run test-browser-no-install -- --run
src/vs/sessions/contrib/sessions/test/browser/sessionsList.test.ts
--grep 'hierarchy indent/connector guides' --browser chromium --reporter
dot` — passed, 16 tests.
- `npm run eslint --
src/vs/sessions/contrib/sessions/browser/views/sessionsList.ts
src/vs/sessions/contrib/sessions/test/browser/sessionsList.test.ts
src/vs/sessions/contrib/sessions/test/browser/sessionsListFixtureUtils.ts
src/vs/sessions/contrib/sessions/test/browser/sessionsList.fixture.ts` —
passed.
- `npm run stylelint --
src/vs/sessions/contrib/sessions/browser/media/sessionsList.css` —
passed with three existing design-token suggestions unrelated to this
change.
- Real-pointer browser checks on the production list — passed for
headers, parent/child/unrelated rows, empty list space, pane padding,
pointer exit, and virtualized scrolling across light, dark, and both
high-contrast themes with compact and normal rows.
- Commit hygiene — passed for all five changed files.
- `npm run compile-client` — blocked by an existing Markdown extension
dependency mismatch (`@vscode/markdown-editor/commands` is not
exported).
- `npm run typecheck-client` — blocked by existing dependency/type
errors, including missing Electron declarations; no diagnostics in the
changed files.

## Manual Test

1. Open the Agents window with at least two expanded session
hierarchies.
2. Hover a session row, a child row, a section header, or empty space
within the sessions pane. All visible hierarchy guides should appear
without revealing unrelated row controls.
3. Move outside the pane. Only the existing selected/focused hierarchy
guides should remain visible.
4. Repeat with compact rows, scroll to previously offscreen sessions,
and check high-contrast themes.

2026-10-27 09:24:11 -07:00

automation

smoke: fix Windows restart flakes when exit() falls back to killing (#344552 )

2026-10-27 13:53:13 +00:00

componentFixtures

sessions: reveal hierarchy guides on pane hover (#343631 )

2026-10-27 09:24:11 -07:00

integration

ci: run Windows PR checks on vscode-large-runners-windows-8-core (#343812 )

2026-10-26 10:29:41 -04:00

monaco

chore: bump several dependencies (#343627 )