/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, * software distributed under the License is distributed on an * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY * KIND, either express or implied. See the License for the * specific language governing permissions and limitations * under the License. */ #define _USE_MATH_DEFINES #include #include #include #include #include #include #include #include #include #include #include "gen-cpp/DebugProtoTest_types.h" #define BOOST_TEST_MODULE JSONProtoTest #include using namespace thrift::test::debug; using namespace apache::thrift; using apache::thrift::transport::TMemoryBuffer; using apache::thrift::protocol::TJSONProtocol; static std::shared_ptr ooe; void testCaseSetup_1() { ooe.reset(new OneOfEach); ooe->im_true = true; ooe->im_false = false; ooe->a_bite = 0x7f; ooe->integer16 = 27000; ooe->integer32 = 1 << 24; ooe->integer64 = (uint64_t)6000 * 1000 * 1000; ooe->double_precision = M_PI; ooe->some_characters = "JSON THIS! \"\1"; ooe->zomg_unicode = "\xd7\n\a\t"; ooe->base64 = "\1\2\3\255"; ooe->rfc4122_uuid = apache::thrift::TUuid{"00000000-0000-0000-0000-000000000000"}; } BOOST_AUTO_TEST_CASE(test_json_proto_1) { testCaseSetup_1(); const std::string expected_result( "{\"1\":{\"tf\":1},\"2\":{\"tf\":0},\"3\":{\"i8\":127},\"4\":{\"i16\":27000}," "\"5\":{\"i32\":16777216},\"6\":{\"i64\":6000000000},\"7\":{\"dbl\":3.1415926" "535897931},\"8\":{\"str\":\"JSON THIS! \\\"\\u0001\"},\"9\":{\"str\":\"\xd7\\" "n\\u0007\\t\"},\"10\":{\"tf\":0},\"11\":{\"str\":\"AQIDrQ\"},\"12\":{\"lst\"" ":[\"i8\",3,1,2,3]},\"13\":{\"lst\":[\"i16\",3,1,2,3]},\"14\":{\"lst\":[\"i64" "\",3,1,2,3]},\"15\":{\"uid\":\"00000000-0000-0000-0000-000000000000\"},\"16\"" ":{\"lst\":[\"uid\",0]}}"); const std::string result(apache::thrift::ThriftJSONString(*ooe)); BOOST_CHECK_MESSAGE(!expected_result.compare(result), "Expected:\n" << expected_result << "\nGotten:\n" << result); } static std::shared_ptr n; void testCaseSetup_2() { testCaseSetup_1(); n.reset(new Nesting); n->my_ooe = *ooe; n->my_ooe.integer16 = 16; n->my_ooe.integer32 = 32; n->my_ooe.integer64 = 64; n->my_ooe.double_precision = (std::sqrt(5.0) + 1) / 2; n->my_ooe.some_characters = ":R (me going \"rrrr\")"; n->my_ooe.zomg_unicode = "\xd3\x80\xe2\x85\xae\xce\x9d\x20\xd0\x9d\xce" "\xbf\xe2\x85\xbf\xd0\xbe\xc9\xa1\xd0\xb3\xd0" "\xb0\xcf\x81\xe2\x84\x8e\x20\xce\x91\x74\x74" "\xce\xb1\xe2\x85\xbd\xce\xba\xc7\x83\xe2\x80" "\xbc"; n->my_ooe.rfc4122_uuid = apache::thrift::TUuid{"5e2ab188-1726-4e75-a04f-1ed9a6a89c4c"}; std::vector uuiid_list; uuiid_list.push_back(apache::thrift::TUuid{"{fa1af5ec-fdc2-4355-844a-9f0dbfd00e50}"}); uuiid_list.push_back(apache::thrift::TUuid{"{1beece83-34f4-4fa3-b757-1ad1ac157fe3}"}); n->my_ooe.rfc4122_uuid_list = uuiid_list; n->my_bonk.type = 31337; n->my_bonk.message = "I am a bonk... xor!"; } BOOST_AUTO_TEST_CASE(test_json_proto_2) { testCaseSetup_2(); const std::string expected_result( "{\"1\":{\"rec\":{\"1\":{\"i32\":31337},\"2\":{\"str\":\"I am a bonk... xor" "!\"}}},\"2\":{\"rec\":{\"1\":{\"tf\":1},\"2\":{\"tf\":0},\"3\":{\"i8\":127" "},\"4\":{\"i16\":16},\"5\":{\"i32\":32},\"6\":{\"i64\":64},\"7\":{\"dbl\":" "1.6180339887498949},\"8\":{\"str\":\":R (me going \\\"rrrr\\\")\"},\"9\":{" "\"str\":\"ӀⅮΝ Нοⅿоɡгаρℎ Αttαⅽκǃ‼\"},\"10\":{\"tf\":0},\"11\":{\"str\":\"" "AQIDrQ\"},\"12\":{\"lst\":[\"i8\",3,1,2,3]},\"13\":{\"lst\":[\"i16\",3,1,2" ",3]},\"14\":{\"lst\":[\"i64\",3,1,2,3]},\"15\":{\"uid\":\"5e2ab188-1726-" "4e75-a04f-1ed9a6a89c4c\"},\"16\":{\"lst\":[\"uid\",2,\"fa1af5ec-fdc2-4355-" "844a-9f0dbfd00e50\",\"1beece83-34f4-4fa3-b757-1ad1ac157fe3\"]}}}}" ); const std::string result(apache::thrift::ThriftJSONString(*n)); BOOST_CHECK_MESSAGE(!expected_result.compare(result), "Expected:\n" << expected_result << "\nGotten:\n" << result); } static std::shared_ptr hm; void testCaseSetup_3() { testCaseSetup_2(); hm.reset(new HolyMoley); hm->big.push_back(*ooe); hm->big.push_back(n->my_ooe); hm->big[0].a_bite = 0x22; hm->big[1].a_bite = 0x33; std::vector stage1; stage1.push_back("and a one"); stage1.push_back("and a two"); hm->contain.insert(stage1); stage1.clear(); stage1.push_back("then a one, two"); stage1.push_back("three!"); stage1.push_back("FOUR!!"); hm->contain.insert(stage1); stage1.clear(); hm->contain.insert(stage1); std::vector stage2; hm->bonks["nothing"] = stage2; stage2.resize(stage2.size() + 1); stage2.back().type = 1; stage2.back().message = "Wait."; stage2.resize(stage2.size() + 1); stage2.back().type = 2; stage2.back().message = "What?"; hm->bonks["something"] = stage2; stage2.clear(); stage2.resize(stage2.size() + 1); stage2.back().type = 3; stage2.back().message = "quoth"; stage2.resize(stage2.size() + 1); stage2.back().type = 4; stage2.back().message = "the raven"; stage2.resize(stage2.size() + 1); stage2.back().type = 5; stage2.back().message = "nevermore"; hm->bonks["poe"] = stage2; } BOOST_AUTO_TEST_CASE(test_json_proto_3) { testCaseSetup_3(); const std::string expected_result( "{\"1\":{\"lst\":[\"rec\",2,{\"1\":{\"tf\":1},\"2\":{\"tf\":0},\"3\":{\"i8\":" "34},\"4\":{\"i16\":27000},\"5\":{\"i32\":16777216},\"6\":{\"i64\":6000000000" "},\"7\":{\"dbl\":3.1415926535897931},\"8\":{\"str\":\"JSON THIS! \\\"\\u0001" "\"},\"9\":{\"str\":\"\xd7\\n\\u0007\\t\"},\"10\":{\"tf\":0},\"11\":{\"str\":" "\"AQIDrQ\"},\"12\":{\"lst\":[\"i8\",3,1,2,3]},\"13\":{\"lst\":[\"i16\",3,1,2" ",3]},\"14\":{\"lst\":[\"i64\",3,1,2,3]},\"15\":{\"uid\":\"00000000-0000-0000" "-0000-000000000000\"},\"16\":{\"lst\":[\"uid\",0]}},{\"1\":{\"tf\":1},\"2\":{\"tf\":0}," "\"3\":{\"i8\":51},\"4\":{\"i16\":16},\"5\":{\"i32\":32},\"6\":{\"i64\":64}," "\"7\":{\"dbl\":1.6180339887498949},\"8\":{\"str\":\":R (me going \\\"rrrr\\\"" ")\"},\"9\":{\"str\":\"ӀⅮΝ Нοⅿоɡгаρℎ Αttαⅽκǃ‼\"},\"10\":{\"tf\":0},\"11\":{" "\"str\":\"AQIDrQ\"},\"12\":{\"lst\":[\"i8\",3,1,2,3]},\"13\":{\"lst\":[\"i16" "\",3,1,2,3]},\"14\":{\"lst\":[\"i64\",3,1,2,3]},\"15\":{\"uid\":\"5e2ab188-" "1726-4e75-a04f-1ed9a6a89c4c\"},\"16\":{\"lst\":[\"uid\",2,\"fa1af5ec-fdc2-4355-" "844a-9f0dbfd00e50\",\"1beece83-34f4-4fa3-b757-1ad1ac157fe3\"]}}]},\"2\":{\"set\":[\"lst\",3" ",[\"str\",0],[\"str\",2,\"and a one\",\"and a two\"],[\"str\",3,\"then a one" ", two\",\"three!\",\"FOUR!!\"]]},\"3\":{\"map\":[\"str\",\"lst\",3,{\"nothin" "g\":[\"rec\",0],\"poe\":[\"rec\",3,{\"1\":{\"i32\":3},\"2\":{\"str\":\"quoth" "\"}},{\"1\":{\"i32\":4},\"2\":{\"str\":\"the raven\"}},{\"1\":{\"i32\":5},\"" "2\":{\"str\":\"nevermore\"}}],\"something\":[\"rec\",2,{\"1\":{\"i32\":1},\"" "2\":{\"str\":\"Wait.\"}},{\"1\":{\"i32\":2},\"2\":{\"str\":\"What?\"}}]}]}}" ); const std::string result(apache::thrift::ThriftJSONString(*hm)); BOOST_CHECK_MESSAGE(!expected_result.compare(result), "Expected:\n" << expected_result << "\nGotten:\n" << result); } BOOST_AUTO_TEST_CASE(test_json_proto_4) { testCaseSetup_1(); std::shared_ptr buffer(new TMemoryBuffer()); std::shared_ptr proto(new TJSONProtocol(buffer)); ooe->write(proto.get()); OneOfEach ooe2; ooe2.read(proto.get()); BOOST_TEST_INFO("written: " << *ooe); BOOST_TEST_INFO("read : " << ooe2); BOOST_CHECK(*ooe == ooe2); } BOOST_AUTO_TEST_CASE(test_json_proto_5) { testCaseSetup_3(); std::shared_ptr buffer(new TMemoryBuffer()); std::shared_ptr proto(new TJSONProtocol(buffer)); hm->write(proto.get()); HolyMoley hm2; hm2.read(proto.get()); BOOST_TEST_INFO("written: " << *hm); BOOST_TEST_INFO("read : " << hm2); BOOST_CHECK(*hm == hm2); hm2.big[0].a_bite = 0x00; BOOST_CHECK(*hm != hm2); } BOOST_AUTO_TEST_CASE(test_json_proto_6) { Doubles dub; dub.nan = HUGE_VAL / HUGE_VAL; dub.inf = HUGE_VAL; dub.neginf = -HUGE_VAL; dub.repeating = 10.0 / 3.0; dub.big = 1E+305; dub.tiny = 1E-305; dub.zero = 0.0; dub.negzero = -0.0; const std::string expected_result( "{\"1\":{\"dbl\":\"NaN\"},\"2\":{\"dbl\":\"Infinity\"},\"3\":{\"dbl\":\"-Infi" "nity\"},\"4\":{\"dbl\":3.3333333333333335},\"5\":{\"dbl\":9.9999999999999994e+" "304},\"6\":{\"dbl\":1e-305},\"7\":{\"dbl\":0},\"8\":{\"dbl\":-0}}" ); std::shared_ptr buffer(new TMemoryBuffer()); std::shared_ptr proto(new TJSONProtocol(buffer)); dub.write(proto.get()); Doubles dub_1; dub_1.read(proto.get()); const std::string result(apache::thrift::ThriftJSONString(dub)); const std::string result_1(apache::thrift::ThriftJSONString(dub_1)); BOOST_CHECK_MESSAGE(!expected_result.compare(result), "Expected:\n" << expected_result << "\nGotten:\n" << result); BOOST_CHECK_MESSAGE(!expected_result.compare(result_1), "Expected:\n" << expected_result << "\nGotten:\n" << result_1); } BOOST_AUTO_TEST_CASE(test_json_proto_7) { std::shared_ptr buffer(new TMemoryBuffer()); std::shared_ptr proto(new TJSONProtocol(buffer)); Base64 base; base.a = 123; base.b1 = "1"; base.b2 = "12"; base.b3 = "123"; base.b4 = "1234"; base.b5 = "12345"; base.b6 = "123456"; base.write(proto.get()); Base64 base2; base2.read(proto.get()); BOOST_CHECK(base == base2); } BOOST_AUTO_TEST_CASE(test_json_proto_8) { const char* json_string = "{\"1\":{\"tf\":1},\"2\":{\"tf\":0},\"3\":{\"i8\":127},\"4\":{\"i16\":27000}," "\"5\":{\"i32\":16.77216},\"6\":{\"i64\":6000000000},\"7\":{\"dbl\":3.1415926" "535897931},\"8\":{\"str\":\"JSON THIS! \\\"\\u0001\"},\"9\":{\"str\":\"\xd7\\" "n\\u0007\\t\"},\"10\":{\"tf\":0},\"11\":{\"str\":\"AQIDrQ\"},\"12\":{\"lst\"" ":[\"i8\",3,1,2,3]},\"13\":{\"lst\":[\"i16\",3,1,2,3]},\"14\":{\"lst\":[\"i64" "\",3,1,2,3]}}"; const std::size_t bufSiz = strlen(json_string) * sizeof(char); std::shared_ptr buffer(new TMemoryBuffer( (uint8_t*)(json_string), static_cast(bufSiz))); std::shared_ptr proto(new TJSONProtocol(buffer)); OneOfEach ooe2; BOOST_CHECK_THROW(ooe2.read(proto.get()), apache::thrift::protocol::TProtocolException); } static std::string toHexSequence(const std::string& str) { std::stringstream ss; ss << std::hex << std::setfill('0'); for (std::size_t i = 0; i < str.size(); i++) { ss << "\\x" << int(uint8_t(str[i])); } return ss.str(); } BOOST_AUTO_TEST_CASE(test_json_unicode_escaped) { const char json_string[] = "{\"1\":{\"tf\":1},\"2\":{\"tf\":0},\"3\":{\"i8\":127},\"4\":{\"i16\":27000}," "\"5\":{\"i32\":16},\"6\":{\"i64\":6000000000},\"7\":{\"dbl\":3.1415926" "535897931},\"8\":{\"str\":\"JSON THIS!\"},\"9\":{\"str\":\"\\u0e01 \\ud835\\udd3e\"}," "\"10\":{\"tf\":0},\"11\":{\"str\":\"000000\"},\"12\":{\"lst\"" ":[\"i8\",3,1,2,3]},\"13\":{\"lst\":[\"i16\",3,1,2,3]},\"14\":{\"lst\":[\"i64" "\",3,1,2,3]}}"; const char* expected_zomg_unicode = "\xe0\xb8\x81 \xf0\x9d\x94\xbe"; std::shared_ptr buffer(new TMemoryBuffer( (uint8_t*)(json_string), sizeof(json_string))); std::shared_ptr proto(new TJSONProtocol(buffer)); OneOfEach ooe2; ooe2.read(proto.get()); BOOST_CHECK_MESSAGE(!ooe2.zomg_unicode.compare(expected_zomg_unicode), "Expected:\n" << toHexSequence(expected_zomg_unicode) << "\nGotten:\n" << toHexSequence(ooe2.zomg_unicode)); } BOOST_AUTO_TEST_CASE(test_json_unicode_escaped_missing_low_surrogate) { const char json_string[] = "{\"1\":{\"tf\":1},\"2\":{\"tf\":0},\"3\":{\"i8\":127},\"4\":{\"i16\":27000}," "\"5\":{\"i32\":16},\"6\":{\"i64\":6000000000},\"7\":{\"dbl\":3.1415926" "535897931},\"8\":{\"str\":\"JSON THIS!\"},\"9\":{\"str\":\"\\ud835\"}," "\"10\":{\"tf\":0},\"11\":{\"str\":\"000000\"},\"12\":{\"lst\"" ":[\"i8\",3,1,2,3]},\"13\":{\"lst\":[\"i16\",3,1,2,3]},\"14\":{\"lst\":[\"i64" "\",3,1,2,3]}}"; std::shared_ptr buffer(new TMemoryBuffer( (uint8_t*)(json_string), sizeof(json_string))); std::shared_ptr proto(new TJSONProtocol(buffer)); OneOfEach ooe2; BOOST_CHECK_THROW(ooe2.read(proto.get()), apache::thrift::protocol::TProtocolException); } BOOST_AUTO_TEST_CASE(test_json_unicode_escaped_missing_hi_surrogate) { const char json_string[] = "{\"1\":{\"tf\":1},\"2\":{\"tf\":0},\"3\":{\"i8\":127},\"4\":{\"i16\":27000}," "\"5\":{\"i32\":16},\"6\":{\"i64\":6000000000},\"7\":{\"dbl\":3.1415926" "535897931},\"8\":{\"str\":\"JSON THIS!\"},\"9\":{\"str\":\"\\udd3e\"}," "\"10\":{\"tf\":0},\"11\":{\"str\":\"000000\"},\"12\":{\"lst\"" ":[\"i8\",3,1,2,3]},\"13\":{\"lst\":[\"i16\",3,1,2,3]},\"14\":{\"lst\":[\"i64" "\",3,1,2,3]}}"; std::shared_ptr buffer(new TMemoryBuffer( (uint8_t*)(json_string), sizeof(json_string))); std::shared_ptr proto(new TJSONProtocol(buffer)); OneOfEach ooe2; BOOST_CHECK_THROW(ooe2.read(proto.get()), apache::thrift::protocol::TProtocolException); } BOOST_AUTO_TEST_CASE(test_json_invalid_byte_range) { // Test case for byte values outside valid range const char json_string[] = "\"3\":{\"i8\":849}"; std::shared_ptr buffer(new TMemoryBuffer( (uint8_t*)(json_string), sizeof(json_string))); std::shared_ptr proto(new TJSONProtocol(buffer)); OneOfEach ooe2; BOOST_CHECK_THROW(ooe2.read(proto.get()), apache::thrift::protocol::TProtocolException); } BOOST_AUTO_TEST_CASE(test_json_base64_padding_validation) { auto test_base64_padding = [](const std::string& base64_value) { std::string json_string = "{\"11\":{\"str\":\"" + base64_value + "\"}}"; std::shared_ptr buffer(new TMemoryBuffer( (uint8_t*)(json_string.c_str()), static_cast(json_string.size()))); std::shared_ptr proto(new TJSONProtocol(buffer)); OneOfEach ooe; BOOST_CHECK_NO_THROW(ooe.read(proto.get())); }; // Valid base64 with 1 padding character test_base64_padding("QWE="); // Valid base64 with 2 padding characters test_base64_padding("QQ=="); // Just padding test_base64_padding("="); test_base64_padding("=="); // Malformed base64 with excessive padding (processed conservatively) test_base64_padding("==="); test_base64_padding("===="); } // A single JSON string is quote-delimited, so unlike a length-prefixed binary // string there is no declared size to reject up front. readJSONString() must // therefore bound the string it decodes against the configured MaxMessageSize: // a string within the limit is still read, but one larger than the limit is // rejected rather than grown without bound. BOOST_AUTO_TEST_CASE(test_json_string_respects_max_message_size) { const int kMaxMessageSize = 1024; // A string comfortably under the limit is accepted unchanged. { auto config = std::make_shared(kMaxMessageSize); std::string json = "\"" + std::string(kMaxMessageSize / 2, 'A') + "\""; auto buffer = std::make_shared(reinterpret_cast(&json[0]), static_cast(json.size()), TMemoryBuffer::COPY, config); auto proto = std::make_shared(buffer); std::string out; BOOST_CHECK_NO_THROW(proto->readString(out)); BOOST_CHECK_EQUAL(out.size(), static_cast(kMaxMessageSize / 2)); } // A single string larger than the configured limit is rejected. { auto config = std::make_shared(kMaxMessageSize); std::string json = "\"" + std::string(kMaxMessageSize * 2, 'A') + "\""; auto buffer = std::make_shared(reinterpret_cast(&json[0]), static_cast(json.size()), TMemoryBuffer::COPY, config); auto proto = std::make_shared(buffer); std::string out; BOOST_CHECK_THROW(proto->readString(out), apache::thrift::transport::TTransportException); } } // The same char-by-char, no-declared-length reasoning applies to numeric // literals via readJSONNumericChars(): an over-long numeric run must also be // bounded by the configured MaxMessageSize. BOOST_AUTO_TEST_CASE(test_json_number_respects_max_message_size) { const int kMaxMessageSize = 1024; auto config = std::make_shared(kMaxMessageSize); // Terminate the numeric run with a non-numeric byte so that, without the // size bound, readJSONNumericChars() stops cleanly (rather than throwing on // buffer exhaustion) and the test isolates the MaxMessageSize check itself. std::string json = std::string(kMaxMessageSize * 2, '1') + " "; auto buffer = std::make_shared(reinterpret_cast(&json[0]), static_cast(json.size()), TMemoryBuffer::COPY, config); auto proto = std::make_shared(buffer); int64_t out = 0; BOOST_CHECK_THROW(proto->readI64(out), apache::thrift::transport::TTransportException); } // TMemoryBuffer checks the message size budget but never draws it down, so the // tests above cannot tell a bound against the configured maximum apart from one // against the size still remaining -- on such a transport the two are the same // thing. TZlibTransport::read() does draw the budget down as bytes are consumed; // this stand-in reproduces that accounting without adding a zlib dependency to // this test. class TCountingTransport : public apache::thrift::transport::TVirtualTransport { public: TCountingTransport(std::shared_ptr inner, std::shared_ptr config) : TVirtualTransport(config), inner_(inner) {} uint32_t read(uint8_t* buf, uint32_t len) { checkReadBytesAvailable(len); uint32_t got = inner_->read(buf, len); countConsumedMessageBytes(got); return got; } void write(const uint8_t* buf, uint32_t len) { inner_->write(buf, len); } bool isOpen() const override { return inner_->isOpen(); } void open() override { inner_->open(); } void close() override { inner_->close(); } private: std::shared_ptr inner_; }; static std::shared_ptr countingProtoReading(const std::string& json, std::shared_ptr config) { auto buffer = std::make_shared( reinterpret_cast(const_cast(json.data())), static_cast(json.size()), TMemoryBuffer::COPY, config); auto transport = std::make_shared(buffer, config); return std::make_shared(transport); } // The size of a field must be measured against the configured maximum, not // against whatever is left of the message budget: a transport that draws the // budget down as it reads has already accounted for those same bytes, and // counting them a second time rejects strings well inside the limit. BOOST_AUTO_TEST_CASE(test_json_string_size_measured_against_configured_maximum) { const int kMaxMessageSize = 1024; const size_t kStringSize = kMaxMessageSize * 3 / 4; // inside the limit, past half of it // Within the limit: must be read, even though the transport has drawn the // remaining budget down by the same bytes as they arrived. { auto config = std::make_shared(kMaxMessageSize); auto proto = countingProtoReading("\"" + std::string(kStringSize, 'A') + "\"", config); std::string out; BOOST_CHECK_NO_THROW(proto->readString(out)); BOOST_CHECK_EQUAL(out.size(), kStringSize); } // Past the limit: still rejected on that same transport. { auto config = std::make_shared(kMaxMessageSize); auto proto = countingProtoReading("\"" + std::string(kMaxMessageSize * 2, 'A') + "\"", config); std::string out; BOOST_CHECK_THROW(proto->readString(out), apache::thrift::transport::TTransportException); } } // readJSONNumericChars() counts the same way and needs the same treatment. BOOST_AUTO_TEST_CASE(test_json_number_size_measured_against_configured_maximum) { const int kMaxMessageSize = 40; const size_t kDigits = 24; // inside the limit, past half of it auto config = std::make_shared(kMaxMessageSize); // Terminated by a non-numeric byte so the numeric run ends on the terminator // rather than on buffer exhaustion, isolating the size check itself. auto proto = countingProtoReading(std::string(kDigits, '1') + " ", config); double out = 0; BOOST_CHECK_NO_THROW(proto->readDouble(out)); } // An empty numeric token must be rejected, not decoded into a value that was // never assigned. readJSONNumericChars() returns an empty string when no digits // are present where a number is expected; fromString() must then throw rather // than return an unset number. BOOST_AUTO_TEST_CASE(test_json_empty_number_rejected) { std::string json = "}"; // a non-numeric byte where a number is expected auto buffer = std::make_shared(reinterpret_cast(&json[0]), static_cast(json.size()), TMemoryBuffer::COPY); auto proto = std::make_shared(buffer); int64_t out = 0; BOOST_CHECK_THROW(proto->readI64(out), apache::thrift::protocol::TProtocolException); } // A numeric token outside the target type's range must be rejected, not clamped // and returned as if it were the value on the wire. BOOST_AUTO_TEST_CASE(test_json_overflow_number_rejected) { std::string json = "99999999999999999999 "; // > INT64_MAX, then a terminator auto buffer = std::make_shared(reinterpret_cast(&json[0]), static_cast(json.size()), TMemoryBuffer::COPY); auto proto = std::make_shared(buffer); int64_t out = 0; BOOST_CHECK_THROW(proto->readI64(out), apache::thrift::protocol::TProtocolException); }