mirrors/terminal
0
0 Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-10-28 08:26:27 +08:00
Code Activity

Banish the new Serialization slop test to the nega-verse (#20794)

Browse Source
This commit is contained in:
Dustin L. Howett authored and GitHub committed 2026-10-12 20:12:55 +00:00
1 parent 0edb684b0c
commit e90f9a534c
1 file changed
-81
Download Patch File Download Diff File Expand all files Collapse all files
src/cascadia/UnitTests_SettingsModel/SerializationTests.cpp
-81
View File
@@ -42,7 +42,6 @@ namespace SettingsModelUnitTests
TEST_METHOD(Actions);
TEST_METHOD(CascadiaSettings);
TEST_METHOD(LegacyFontSettings);
TEST_METHOD(MigrateLegacyConfirmCloseAllTabs);
TEST_METHOD(RoundtripReloadEnvVars);
TEST_METHOD(DontRoundtripNoReloadEnvVars);
@@ -574,86 +573,6 @@ namespace SettingsModelUnitTests
VERIFY_ARE_EQUAL(toString(jsonOutput), toString(result));
}
void SerializationTests::MigrateLegacyConfirmCloseAllTabs()
{
struct TestCase
{
std::string_view globals;
ConfirmOnClose expected;
// The value we expect to be written as "warning.confirmOnClose", or empty if none.
std::string_view expectedJson;
bool expectFixup;
};
static constexpr std::array testCases{
// Nothing to migrate.
TestCase{ "", ConfirmOnClose::Automatic, "", false },
TestCase{ R"("warning.confirmOnClose": "never")", ConfirmOnClose::Never, "never", false },
// true -> automatic, false -> never, for both legacy keys.
TestCase{ R"("confirmCloseAllTabs": true)", ConfirmOnClose::Automatic, "automatic", true },
TestCase{ R"("confirmCloseAllTabs": false)", ConfirmOnClose::Never, "never", true },
TestCase{ R"("warning.confirmCloseAllTabs": true)", ConfirmOnClose::Automatic, "automatic", true },
TestCase{ R"("warning.confirmCloseAllTabs": false)", ConfirmOnClose::Never, "never", true },
// "warning.confirmOnClose" takes precedence over either legacy key.
TestCase{ R"("warning.confirmOnClose": "always", "confirmCloseAllTabs": false)", ConfirmOnClose::Always, "always", true },
TestCase{ R"("warning.confirmOnClose": "always", "warning.confirmCloseAllTabs": false)", ConfirmOnClose::Always, "always", true },
// "warning.confirmCloseAllTabs" takes precedence over "confirmCloseAllTabs".
TestCase{ R"("warning.confirmCloseAllTabs": false, "confirmCloseAllTabs": true)", ConfirmOnClose::Never, "never", true },
// A null value is ignored, but the stale key still gets removed.
TestCase{ R"("confirmCloseAllTabs": null)", ConfirmOnClose::Automatic, "", true },
TestCase{ R"("warning.confirmCloseAllTabs": null)", ConfirmOnClose::Automatic, "", true },
};
for (const auto& tc : testCases)
{
Log::Comment(NoThrowString().Format(L"Testing case: {%s}", til::u8u16(tc.globals).c_str()));
std::string settingsJson{ R"({
"defaultProfile": "{6239a42c-0000-49a3-80bd-e8fdd045185c}",
"profiles": [
{
"name": "profile0",
"guid": "{6239a42c-0000-49a3-80bd-e8fdd045185c}"
}
])" };
if (!tc.globals.empty())
{
settingsJson.append(",\n").append(tc.globals);
}
settingsJson.append("\n}");
implementation::SettingsLoader loader{ settingsJson, implementation::LoadStringResource(IDR_DEFAULTS) };
loader.MergeInboxIntoUserSettings();
loader.FinalizeLayering();
VERIFY_ARE_EQUAL(tc.expectFixup, loader.FixupUserSettings());
const auto settings = winrt::make_self<implementation::CascadiaSettings>(std::move(loader));
VERIFY_ARE_EQUAL(tc.expected, settings->GlobalSettings().ConfirmOnClose());
VERIFY_ARE_EQUAL(!tc.expectedJson.empty(), settings->GlobalSettings().HasConfirmOnClose());
const auto result{ settings->ToJson() };
VERIFY_IS_FALSE(result.isMember("confirmCloseAllTabs"));
VERIFY_IS_FALSE(result.isMember("warning.confirmCloseAllTabs"));
if (tc.expectedJson.empty())
{
VERIFY_IS_FALSE(result.isMember("warning.confirmOnClose"));
}
else
{
VERIFY_ARE_EQUAL(std::string{ tc.expectedJson }, result["warning.confirmOnClose"].asString());
}
Log::Comment(L"Reloading the written settings shouldn't need any further fixups");
implementation::SettingsLoader reloader{ toString(result), implementation::LoadStringResource(IDR_DEFAULTS) };
reloader.MergeInboxIntoUserSettings();
reloader.FinalizeLayering();
VERIFY_IS_FALSE(reloader.FixupUserSettings());
const auto reloaded = winrt::make_self<implementation::CascadiaSettings>(std::move(reloader));
VERIFY_ARE_EQUAL(tc.expected, reloaded->GlobalSettings().ConfirmOnClose());
}
}
void SerializationTests::RoundtripReloadEnvVars()
{
static constexpr std::string_view oldSettingsJson{ R"(