mirror of
https://github.com/ruby/ruby.git
synced 2026-10-29 00:46:26 +08:00
SleepingUnblockScheduler#unblock deliberately breaks the join path,
so the inner Thread.new{sleep(0.01)} created inside Fiber.schedule
is abandoned mid-sleep when the outer thread exits. It eventually
wakes and lingers in Thread.list, breaking cleanup_threads in later
test files (e.g. test/-ext-/thread/test_instrumentation_api.rb).
Capture the inner thread and join it in an ensure.
18) Failure:
TestThreadInstrumentation#test_thread_pass_multi_thread [/build/ruby4.0/test/-ext-/thread/test_instrumentation_api.rb:289]:
<[#<Thread:0x00007f8dbc9b7f48 run>]> expected but was
<[#<Thread:0x00007f8dbc9b7f48 run>,
#<Thread:0x00007f8dbc9f45b0 /build/ruby4.0/test/fiber/test_thread.rb:165 sleep>]>.
176 lines
3.3 KiB
Ruby
176 lines
3.3 KiB
Ruby
# frozen_string_literal: true
|
|
require "test/unit"
|
|
require_relative 'scheduler'
|
|
|
|
class TestFiberThread < Test::Unit::TestCase
|
|
def test_thread_join
|
|
thread = Thread.new do
|
|
scheduler = Scheduler.new
|
|
Fiber.set_scheduler scheduler
|
|
|
|
result = nil
|
|
Fiber.schedule do
|
|
result = Thread.new{:done}.value
|
|
end
|
|
|
|
scheduler.run
|
|
result
|
|
end
|
|
|
|
assert_equal :done, thread.value
|
|
end
|
|
|
|
def test_thread_join_timeout
|
|
sleeper = nil
|
|
|
|
thread = Thread.new do
|
|
scheduler = Scheduler.new
|
|
Fiber.set_scheduler scheduler
|
|
|
|
Fiber.schedule do
|
|
sleeper = Thread.new{sleep}
|
|
sleeper.join(0.1)
|
|
end
|
|
|
|
scheduler.run
|
|
end
|
|
|
|
thread.join
|
|
|
|
assert_predicate sleeper, :alive?
|
|
ensure
|
|
sleeper&.kill&.join
|
|
end
|
|
|
|
def test_thread_join_implicit
|
|
sleeping = false
|
|
finished = false
|
|
|
|
thread = Thread.new do
|
|
scheduler = Scheduler.new
|
|
Fiber.set_scheduler scheduler
|
|
|
|
Fiber.schedule do
|
|
sleeping = true
|
|
sleep(0.1)
|
|
finished = true
|
|
end
|
|
|
|
:done
|
|
end
|
|
|
|
Thread.pass until sleeping
|
|
|
|
thread.join
|
|
|
|
assert_equal :done, thread.value
|
|
assert finished, "Scheduler thread's task should be finished!"
|
|
end
|
|
|
|
def test_thread_join_blocking
|
|
thread = Thread.new do
|
|
scheduler = Scheduler.new
|
|
Fiber.set_scheduler scheduler
|
|
|
|
result = nil
|
|
Fiber.schedule do
|
|
Fiber.new(blocking: true) do
|
|
# This can deadlock if the blocking state is not taken into account:
|
|
Thread.new do
|
|
sleep(0)
|
|
result = :done
|
|
end.join
|
|
end.resume
|
|
end
|
|
|
|
scheduler.run
|
|
result
|
|
end
|
|
|
|
assert_equal :done, thread.value
|
|
end
|
|
|
|
def test_spurious_unblock_during_thread_join
|
|
ready = Thread::Queue.new
|
|
|
|
target_thread = Thread.new do
|
|
ready.pop
|
|
:success
|
|
end
|
|
|
|
Thread.pass until target_thread.status == "sleep"
|
|
|
|
result = nil
|
|
|
|
thread = Thread.new do
|
|
scheduler = Scheduler.new
|
|
Fiber.set_scheduler scheduler
|
|
|
|
# Create a fiber that will join a long-running thread:
|
|
joining_fiber = Fiber.schedule do
|
|
result = target_thread.value
|
|
end
|
|
|
|
# Create another fiber that spuriously unblocks the joining fiber:
|
|
Fiber.schedule do
|
|
# This interrupts the join in joining_fiber:
|
|
scheduler.unblock(:spurious_wakeup, joining_fiber)
|
|
|
|
# This allows the unblock to be processed:
|
|
sleep(0)
|
|
|
|
# This allows the target thread to finish:
|
|
ready.push(:done)
|
|
end
|
|
|
|
scheduler.run
|
|
end
|
|
|
|
thread.join
|
|
|
|
assert_equal :success, result
|
|
end
|
|
|
|
def test_broken_unblock
|
|
thread = Thread.new do
|
|
Thread.current.report_on_exception = false
|
|
|
|
scheduler = BrokenUnblockScheduler.new
|
|
|
|
Fiber.set_scheduler scheduler
|
|
|
|
Fiber.schedule do
|
|
Thread.new{
|
|
Thread.current.report_on_exception = false
|
|
}.join
|
|
end
|
|
|
|
scheduler.run
|
|
ensure
|
|
scheduler.close
|
|
end
|
|
|
|
assert_raise(RuntimeError) do
|
|
thread.join
|
|
end
|
|
end
|
|
|
|
def test_thread_join_hang
|
|
inner = nil
|
|
thread = Thread.new do
|
|
scheduler = SleepingUnblockScheduler.new
|
|
|
|
Fiber.set_scheduler scheduler
|
|
|
|
Fiber.schedule do
|
|
inner = Thread.new{sleep(0.01)}
|
|
inner.value
|
|
end
|
|
end
|
|
|
|
thread.join
|
|
ensure
|
|
inner&.join
|
|
end
|
|
end
|