130 Commits
Author SHA1 Message Date
usa dbe8e9c578 merge revision(s) 59584: [Backport #13850]
REXML: Fix a bug that unexpected methods can be called as a XPath function

	[HackerOne:249295]

	Reported by Andrea Jegher. Thanks!!!


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@59796 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2017-09-09 13:42:22 +00:00
usa 971b99f3ed merge revision(s) 59033,59034: [Backport #13636]
rexml: add close tag check on end of document to StreamParser

	[ruby-core:81593] [Bug #13636]

	Reported by Anton Sivakov. Thanks!!!

	* properties.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@59239 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2017-06-30 12:58:41 +00:00
naruse 6b73bb455e merge revision(s) 53299: [Backport #11870]
* compile.c, cont.c, doc, man: fix common misspelling.
          [ruby-core:72466] [Bug #11870]


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@54351 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2016-03-29 04:49:00 +00:00
naruse 3e92b635fb Add frozen_string_literal: false for all files
When you change this to true, you may need to add more tests.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53141 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2015-12-16 05:07:31 +00:00
nobu ae042f21fb use assert_raise
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50727 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2015-06-02 02:18:44 +00:00
kou 9f4ab1c69d * test/rexml/test_document.rb: Indent.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48448 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-11-15 12:29:21 +00:00
kou 64f9f1ba58 * test/rexml/test_document.rb
(REXMLTests::TestDocument::EntityExpansionLimitTest):
  Group tests by general entity and parameter entity.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48446 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-11-15 11:47:34 +00:00
kou a38971c595 * test/rexml/test_document.rb
(REXMLTests::TestDocument::EntityExpansionLimitTest): Define
  test XML in each test method because (1) each XML in used only
  one test and (2) related data and code should be close.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48445 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-11-15 11:45:27 +00:00
kou a5406b873c * test/rexml/test_document.rb
(REXMLTests::TestDocument::EntityExpansionLimitTest):
  Use one test method for one test.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48444 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-11-15 11:40:47 +00:00
kou a4a2fbdf64 * test/rexml/test_document.rb
(REXMLTests::TestDocument::EntityExpansionLimitTest): Use
  setup and teardown instead of ensure in test.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48442 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-11-15 11:17:33 +00:00
kou 9fb2d21d7d * test/rexml/test_document.rb
(REXMLTests::TestDocument::EntityExpansionLimitTest): Indent.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48440 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-11-15 11:13:31 +00:00
kou f2588e1c8e * test/rexml/test_document.rb (REXMLTests::TestDocument): Group
entity expansion limit related tests.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48439 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-11-15 11:12:20 +00:00
kou 1e326bb0e5 * test/rexml/test_document.rb (REXMLTests::TestDocument::BomTest):
Fix wrong parent class. It doesn't need inherit tests in
  TestDocument class.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48438 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-11-15 11:09:57 +00:00
nagachika 2e8f953d68 * lib/rexml/document.rb: add REXML::Document#document.
reported by Tomas Hoger <thoger@redhat.com> and patched by nahi.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48402 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-11-13 13:29:50 +00:00
usa 9cdd297a29 * lib/rexml/entity.rb: keep the entity size within the limitation.
reported by Willis Vandevanter <will@silentrobots.com> and
  patched by nahi.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48161 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-10-27 11:18:02 +00:00
kou 93647e81a6 * lib/rexml/source.rb (REXML::IOSource#encoding_updated): Fix a
bug that can't parse XML correctly when
  Encoding.default_internal is different with XML
  encoding. REXML::Source converts XML encoding on read. So IO
  should not convert XML encoding.
  Based on patch by NAKAMURA Usaku.
  [ruby-dev:48686] [Bug #10418]

* test/rexml/test_encoding.rb
  (REXMLTests::EncodingTester#test_parse_utf16_with_utf8_default_internal):
  Add the for the above case.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48109 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-10-23 08:23:10 +00:00
kou f6c56982ab * test/rexml/test_encoding.rb
(REXMLTests::EncodingTester#test_parse_utf16): Use meaningful
  test name. "ticket" in the old test name means the ticket in
  REXML's issue tracker. The REXML's issue tracker was gone. So
  "ticket" is meaningless.

* test/rexml/data/ticket_110_utf16.xml: Rename to ...
* test/rexml/data/utf16.xml: ... this.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48108 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-10-23 07:31:31 +00:00
kou 7a608ada8f * test/rexml/test_encoding.rb
(REXMLTests::EncodingTester#test_ticket_110): Fix expected and
  actual order.
  Patch by NAKAMURA Usaku. Thanks!!!


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48107 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-10-23 07:26:39 +00:00
akr 36276b6f40 Avoid a shadowing warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46184 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-27 15:15:54 +00:00
akr 3356c312cd * test/rexml: Avoid fd leaks.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46178 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-27 13:45:04 +00:00
kou 3c908895ab * test/rexml/test_document.rb: Indent.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46177 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-27 13:24:39 +00:00
kou 875f071500 * test/rexml/test_document.rb: Wrap by REXMLTests module.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46176 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-27 13:15:58 +00:00
kou cb50e15e0d * test/rexml/test_encoding_2.rb: Remove a needless file.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46175 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-27 13:12:32 +00:00
kou ba3d2f4ac2 * test/rexml/test_contrib.rb: Indent.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46174 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-27 13:10:55 +00:00
kou 28e78bf7f2 * test/rexml/: Use REXMLTests as wrapping module for REXML tests.
I avoid using the same module for library in test because
  it provides "include REXML" environment in test. Normally,
  users don't use REXML on "include REXML" environment. So I
  don't want to write tests on "include REXML" environment.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46171 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-27 12:07:40 +00:00
kou effcb9a712 * test/rexml/test_comment.rb: Remove needless REXML module wrapping.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46170 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-27 12:01:25 +00:00
akr 13a8d735d9 Wrap REXML test classes by REXML module.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46166 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-27 10:21:10 +00:00
kou ba5ed845b3 * lib/rexml/xmltokens.rb: Add missing non ASCII valid characters
to element name characters. Now, REXML name tokens exactly
  match "[5] Name" in the XML spec and "[4] NCName" in the
  Namespaces in XML spec. See comment about the details.
  [Bug #9539]  [ruby-core:60901]
  Reported by Mario Barcala. Thanks!!!

* test/rexml/xpath/test_node.rb: Add tests for the above case.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@45153 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-02-23 09:01:32 +00:00
kou f8b76cd8fd * test/rexml/xpath/test_attribute.rb: Simplify.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@45141 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-02-22 14:03:25 +00:00
kou 9a695f113a * test/rexml/test_xpath*.rb: Move to ...
* test/rexml/xpath/*.rb: ... here.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@45133 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-02-22 11:25:47 +00:00
kou 464f68a3e5 * test/rexml/listener.rb: Untabify.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@45132 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-02-22 11:05:35 +00:00
hsbt 5691727653 * test/monitor/test_monitor.rb: remove unused variabels.
*  test/resolv/test_dns.rb: ditto.
*  test/rexml/test_functions.rb: ditto.
*  test/rss/test_setup_maker_itunes.rb: ditto.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@45067 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-02-21 01:53:38 +00:00
zzak 2c5dcdf0b4 * lib/{rake,rdoc,rss}/*, test/rexml/test_listener.rb: [DOC] Fix typos
by @dvsuresh [Fixes GH-486] https://github.com/ruby/ruby/pull/486


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@44346 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-12-22 15:00:29 +00:00
a_matsuda adb1ee65b7 [DOC] Correct a couple of typos in comments by @dvsuresh [Fixes GH-482]
* doc/ChangeLog-YARV:  Correct a typo in comment
* lib/rubygems/specification.rb:  ditto.
* test/rexml/data/tutorial.xml:  ditto.
* test/ruby/test_settracefunc.rb:  ditto.
* tool/instruction.rb:  ditto.

https://github.com/ruby/ruby/pull/482
[ci-skip]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@44208 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-12-14 10:54:54 +00:00
kou a66a9fbb10 * lib/rexml/parsers/ultralightparser.rb
(REXML::Parsers::UltraLightParser#parse): Fix wrong :start_doctype
  position.
  [Bug #9061] [ruby-dev:47778]
  Patch by Ippei Obayashi. Thanks!!!

* test/rexml/parser/test_ultra_light.rb: Add a test for this case.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43693 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-11-16 09:31:24 +00:00
kou 1d8efe61d8 * test/rexml/parser/test_tree.rb
(TestTreeParser::TestInvalid#test_unmatched_close_tag):
  Compute expected value from test value.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42816 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-09-03 14:02:10 +00:00
kou 73c57761a9 * lib/rexml/parsers/treeparser.rb (REXML::Parsers::TreeParser#parse):
Add source information to parse exception on no close tag error.
  [Bug #8844]  [ruby-dev:47672]
  Patch by Ippei Obayashi. Thanks!!!
* test/rexml/parser/test_tree.rb: Add a test for the above case.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42815 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-09-03 14:01:20 +00:00
kou 4c1fa1a6a4 * test/rexml/parser/test_tree.rb: Fix test name to describe test
content.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42814 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-09-03 13:58:24 +00:00
kou a0657cd5d7 * lib/rexml/parsers/treeparser.rb (REXML::Parsers::TreeParser#parse):
Remove needless nested parse exception information.
  [Bug #8844]  [ruby-dev:47672]
  Reported by Ippei Obayashi. Thanks!!!
* test/rexml/parser/test_tree.rb: Add a test for the above case.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42813 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-09-03 13:57:18 +00:00
kou bd2b8d2603 * test/rexml/parser/test_sax2.rb: Expand abbreviated class name.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42522 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-08-11 10:12:28 +00:00
kou 45222164dc * lib/rexml/sax2listener.rb (REXML::SAX2Listener#notationdecl): Fix
wrong number of arguments in the template listener.
  [Bug #8731] [ruby-dev:47582]
  Reported by Ippei Obayashi.
* test/rexml/parser/test_sax2.rb: Add tests for parsing notation
  declarations with SAX2 API.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42521 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-08-11 10:08:05 +00:00
kou 7e0022bc8e * lib/rexml/parsers/sax2parser.rb (REXML::Parsers::SAX2Parser#parse):
Fix wrong "%" position in parameter entity declaration event argument.
* test/rexml/parser/test_sax2.rb: Add tests for the above case.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42518 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-08-11 09:41:29 +00:00
kou f61f11a936 * lib/rexml/parsers/sax2parser.rb (REXML::Parsers::SAX2Parser#parse):
Support NDATA in external entity declaration.
* test/rexml/parser/test_sax2.rb: Add tests for the above case.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42516 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-08-11 09:09:25 +00:00
kou ce89dedde3 * NEWS (REXML::Parsers::SAX2Parser): Add about this change.
* lib/rexml/parsers/sax2parser.rb (REXML::Parsers::SAX2Parser#parse):
  Fix wrong number of arguments. Document says "an array of the
  entity declaration" but it passes two or more arguments.
  This is a bug but it break backward compatibility.
  Reported by Ippei Obayashi. [Bug #8731] [ruby-dev:47582]
* lib/rexml/sax2listener.rb (REXML::SAX2Listener#entitydecl): ditto.
  The listener template accepted two arguments.
* test/rexml/parser/test_sax2.rb: Add tests for external ID case.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42514 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-08-11 09:01:41 +00:00
kou 99ed561b4b * test/rexml/parser/test_sax2.rb: Add SAX2 API test.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42512 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-08-11 08:43:17 +00:00
kou 8a4567b207 * test/rexml/parse/test_document_type_declaration.rb: Add tests for
parsing document type declaration.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42486 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-08-10 03:40:58 +00:00
kou b729f2da30 * test/rexml/parse/test_notation_declaration.rb (#test_system_public):
Add a test for PUBLIC notation and SYSTEM notation order case.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42483 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-08-10 02:59:15 +00:00
kou 6d18dd8e4d * lib/rexml/parsers/baseparser.rb (REXML::Parsers::BaseParser::PUBLIC):
Fix loose "head" match regular expression.
  [Bug #8701] [ruby-dev:47551]
  Patch by Ippei Obayashi. Thanks!!!
* test/rexml/parse/test_notation_declaration.rb (#test_system_public):
  Add a test for the above case.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42482 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-08-10 02:34:06 +00:00
kou 5f8cba0705 * test/rexml/parse/test_notation_declaration.rb: Change class
name to follow file name change.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42290 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-07-31 14:00:26 +00:00
kou 6668c32a7e * test/rexml/test_notationdecl_parsetest.rb: Rename to ...
* test/rexml/parse/test_notation_declaration.rb: ... this.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42289 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2013-07-31 13:58:49 +00:00