mirror of
https://github.com/ruby/ruby.git
synced 2026-10-29 00:46:26 +08:00
Socket.tcp_with_fast_fallback: Pass proper addr family to getaddrinfo
Addrinfo.getaddrinfo expects Socket::AF_INET or Socket::AF_INET6 as its
third argument (family). However Socket.tcp_with_fast_fallback was
incorrectly passing :ipv4 or :ipv6.
Repro:
require 'socket'
Socket.tcp_with_fast_fallback('example.com', 80, '127.0.0.1')
Expected behavior: Returns a Socket object
Actual: Raises unknown socket domain: ipv4 (SocketError)
This commit is contained in:
1 parent
03800bff69
commit
b896f80598
1 file changed
+1
-1
@@ -704,7 +704,7 @@ class Socket < BasicSocket
|
||||
|
||||
if resolving_family_names.size == 1
|
||||
family_name = resolving_family_names.first
|
||||
addrinfos = Addrinfo.getaddrinfo(host, port, family_name, :STREAM, timeout: resolv_timeout)
|
||||
addrinfos = Addrinfo.getaddrinfo(host, port, ADDRESS_FAMILIES[:family_name], :STREAM, timeout: resolv_timeout)
|
||||
resolution_store.add_resolved(family_name, addrinfos)
|
||||
hostname_resolution_result = nil
|
||||
hostname_resolution_notifier = nil
|
||||
|
||||
Reference in new issue
Block a user