mirror of
https://gitlab.com/qemu-project/qemu.git
synced 2026-10-28 14:04:39 +08:00
Marc-André Lureau
3c0c7bfeba
Convert the qemu-io command infrastructure to use QEMU's Error API
(Error **errp) for error propagation instead of printing directly to
stdout/stderr via printf/fprintf.
The cfunc_t typedef, all ~35 command functions, the dispatcher chain
(command/init_check_command/qemuio_command), and helper functions
(parse_pattern, create_iovec, qemu_io_alloc_from_file) all gain an
Error **errp parameter. Async completion callbacks (aio_read_done,
aio_write_done, aio_discard_done) use error_report() since they have
no Error path back to the caller.
Update tests:
- error_report_err() prepends qemu-io: prefix
- copy-before-write: check the HMP return value, rather than stdio
- other tests: update to check JSON {"return": "Error: error text"}
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-ID: <20260828-qemu-no-hmp-v5-21-9227de146347@redhat.com>
156 lines
7.6 KiB
Plaintext
156 lines
7.6 KiB
Plaintext
wrote 4096/4096 bytes at offset 0
|
|
4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
|
|
=== Launch VM ===
|
|
{"execute": "nbd-server-start", "arguments": {"addr": {"data": {"path": "SOCK_DIR/PID-socket"}, "type": "unix"}}}
|
|
{"return": {}}
|
|
{"execute": "query-block-exports", "arguments": {}}
|
|
{"return": []}
|
|
|
|
=== Create a read-only NBD export ===
|
|
{"execute": "block-export-add", "arguments": {"id": "export0", "node-name": "fmt", "type": "nbd"}}
|
|
{"return": {}}
|
|
{"execute": "query-block-exports", "arguments": {}}
|
|
{"return": [{"id": "export0", "node-name": "fmt", "shutting-down": false, "type": "nbd"}]}
|
|
exports available: 1
|
|
export: 'fmt'
|
|
size: 67108864
|
|
flags: 0x158f ( readonly flush fua df multi cache block-status-payload )
|
|
min block: XXX
|
|
opt block: XXX
|
|
max block: XXX
|
|
transaction size: 64-bit
|
|
available meta contexts: 1
|
|
base:allocation
|
|
|
|
|
|
=== Try a few invalid things ===
|
|
{"execute": "block-export-add", "arguments": {"id": "#invalid", "node-name": "fmt", "type": "nbd"}}
|
|
{"error": {"class": "GenericError", "desc": "Invalid block export id"}}
|
|
{"execute": "block-export-add", "arguments": {"id": "export0", "node-name": "fmt", "type": "nbd"}}
|
|
{"error": {"class": "GenericError", "desc": "Block export id 'export0' is already in use"}}
|
|
{"execute": "block-export-add", "arguments": {"id": "export1", "node-name": "ro", "type": "nbd", "writable": true}}
|
|
{"error": {"class": "GenericError", "desc": "Cannot export read-only node as writable"}}
|
|
{"execute": "block-export-del", "arguments": {"id": "export1"}}
|
|
{"error": {"class": "GenericError", "desc": "Export 'export1' is not found"}}
|
|
{"execute": "query-block-exports", "arguments": {}}
|
|
{"return": [{"id": "export0", "node-name": "fmt", "shutting-down": false, "type": "nbd"}]}
|
|
|
|
=== Move export to an iothread ===
|
|
{"execute": "device_add", "arguments": {"drive": "fmt", "driver": "scsi-hd", "id": "sda"}}
|
|
{"return": {}}
|
|
{"execute": "query-block-exports", "arguments": {}}
|
|
{"return": [{"id": "export0", "node-name": "fmt", "shutting-down": false, "type": "nbd"}]}
|
|
exports available: 1
|
|
export: 'fmt'
|
|
size: 67108864
|
|
flags: 0x158f ( readonly flush fua df multi cache block-status-payload )
|
|
min block: XXX
|
|
opt block: XXX
|
|
max block: XXX
|
|
transaction size: 64-bit
|
|
available meta contexts: 1
|
|
base:allocation
|
|
|
|
|
|
=== Add export with conflicting iothread ===
|
|
{"execute": "device_add", "arguments": {"drive": "null", "driver": "scsi-hd", "id": "sdb"}}
|
|
{"return": {}}
|
|
{"execute": "block-export-add", "arguments": {"fixed-iothread": true, "id": "export1", "iothread": "iothread1", "node-name": "null", "type": "nbd", "writable": true}}
|
|
{"error": {"class": "GenericError", "desc": "Cannot change iothread of active block backend"}}
|
|
{"execute": "block-export-add", "arguments": {"fixed-iothread": false, "id": "export1", "iothread": "iothread1", "node-name": "null", "type": "nbd", "writable": true}}
|
|
{"error": {"class": "GenericError", "desc": "Permission conflict on node 'null': permissions 'write' are both required by an unnamed block device (uses node 'null' as 'root' child) and unshared by block device 'sdb' (uses node 'null' as 'root' child)."}}
|
|
|
|
=== Add a writable export ===
|
|
{"execute": "block-export-add", "arguments": {"description": "This is the writable second export", "id": "export1", "name": "export1", "node-name": "fmt", "type": "nbd", "writable": true, "writethrough": true}}
|
|
{"error": {"class": "GenericError", "desc": "Permission conflict on node 'fmt': permissions 'write' are both required by an unnamed block device (uses node 'fmt' as 'root' child) and unshared by block device 'sda' (uses node 'fmt' as 'root' child)."}}
|
|
{"execute": "device_del", "arguments": {"id": "sda"}}
|
|
{"return": {}}
|
|
{"data": {"device": "sda", "path": "/machine/peripheral/sda"}, "event": "DEVICE_DELETED", "timestamp": {"microseconds": "USECS", "seconds": "SECS"}}
|
|
{"execute": "device_add", "arguments": {"drive": "fmt", "driver": "scsi-hd", "id": "sda", "share-rw": true}}
|
|
{"return": {}}
|
|
{"execute": "block-export-add", "arguments": {"description": "This is the writable second export", "id": "export1", "name": "export1", "node-name": "fmt", "type": "nbd", "writable": true, "writethrough": true}}
|
|
{"return": {}}
|
|
{"execute": "query-block-exports", "arguments": {}}
|
|
{"return": [{"id": "export1", "node-name": "fmt", "shutting-down": false, "type": "nbd"}, {"id": "export0", "node-name": "fmt", "shutting-down": false, "type": "nbd"}]}
|
|
exports available: 2
|
|
export: 'fmt'
|
|
size: 67108864
|
|
flags: 0x158f ( readonly flush fua df multi cache block-status-payload )
|
|
min block: XXX
|
|
opt block: XXX
|
|
max block: XXX
|
|
transaction size: 64-bit
|
|
available meta contexts: 1
|
|
base:allocation
|
|
export: 'export1'
|
|
description: This is the writable second export
|
|
size: 67108864
|
|
flags: 0x1ded ( flush fua trim zeroes df multi cache fast-zero block-status-payload )
|
|
min block: XXX
|
|
opt block: XXX
|
|
max block: XXX
|
|
transaction size: 64-bit
|
|
available meta contexts: 1
|
|
base:allocation
|
|
|
|
|
|
=== Connect qemu-io to export1, try removing exports ===
|
|
read 4096/4096 bytes at offset 0
|
|
4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
|
|
wrote 4096/4096 bytes at offset 4096
|
|
4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
|
|
{"execute": "block-export-del", "arguments": {"id": "export1"}}
|
|
{"error": {"class": "GenericError", "desc": "export 'export1' still in use"}}
|
|
{"execute": "block-export-del", "arguments": {"id": "export0"}}
|
|
{"return": {}}
|
|
[{"data": {"id": "export0"}, "event": "BLOCK_EXPORT_DELETED", "timestamp": {"microseconds": "USECS", "seconds": "SECS"}}]
|
|
{"execute": "query-block-exports", "arguments": {}}
|
|
{"return": [{"id": "export1", "node-name": "fmt", "shutting-down": false, "type": "nbd"}]}
|
|
exports available: 1
|
|
export: 'export1'
|
|
description: This is the writable second export
|
|
size: 67108864
|
|
flags: 0x1ded ( flush fua trim zeroes df multi cache fast-zero block-status-payload )
|
|
min block: XXX
|
|
opt block: XXX
|
|
max block: XXX
|
|
transaction size: 64-bit
|
|
available meta contexts: 1
|
|
base:allocation
|
|
|
|
|
|
=== Connect qemu-io again, try force removing ===
|
|
{"execute": "block-export-del", "arguments": {"id": "export1"}}
|
|
{"error": {"class": "GenericError", "desc": "export 'export1' still in use"}}
|
|
{"execute": "block-export-del", "arguments": {"id": "export1", "mode": "hard"}}
|
|
{"return": {}}
|
|
qemu-io: read failed: Input/output error
|
|
|
|
{"execute": "query-block-exports", "arguments": {}}
|
|
{"return": []}
|
|
exports available: 0
|
|
|
|
|
|
=== Using multi-thread with NBD ===
|
|
{"execute": "block-export-add", "arguments": {"id": "export0", "iothread": ["iothread0", "iothread1"], "node-name": "fmt", "type": "nbd"}}
|
|
{"error": {"class": "GenericError", "desc": "NBD export does not support multi-threading"}}
|
|
{"execute": "block-export-add", "arguments": {"id": "export0", "iothread": ["iothread0"], "node-name": "fmt", "type": "nbd"}}
|
|
{"error": {"class": "GenericError", "desc": "NBD export does not support multi-threading"}}
|
|
|
|
=== Empty thread list
|
|
{"execute": "block-export-add", "arguments": {"id": "export0", "iothread": [], "node-name": "fmt", "type": "nbd"}}
|
|
{"error": {"class": "GenericError", "desc": "The set of I/O threads must not be empty"}}
|
|
|
|
=== Non-existent thread name in list
|
|
{"execute": "block-export-add", "arguments": {"id": "export0", "iothread": ["iothread0", "nothread", "iothread1"], "node-name": "fmt", "type": "nbd"}}
|
|
{"error": {"class": "GenericError", "desc": "iothread \"nothread\" not found"}}
|
|
|
|
=== Multi-thread with fixed-iothread
|
|
{"execute": "block-export-add", "arguments": {"fixed-iothread": true, "id": "export0", "iothread": ["iothread0", "iothread1"], "node-name": "fmt", "type": "nbd"}}
|
|
{"error": {"class": "GenericError", "desc": "Cannot use fixed-iothread for a multi-threaded export"}}
|
|
|
|
=== Shut down QEMU ===
|