Files
sl b0f312ba48 logging: fix rule and block fields in JSON logs (#19572)
* logging: preserve rule, block, and target values in JSON logs

---------

Signed-off-by: shilohlee98 <shilohlee98@gmail.com>
2026-09-14 17:53:29 +02:00

159 lines
4.1 KiB
Go

// Copyright The Prometheus Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package rules
import (
"bytes"
"context"
"encoding/json"
"errors"
"testing"
"time"
"github.com/prometheus/common/promslog"
"github.com/stretchr/testify/require"
"github.com/prometheus/prometheus/model/labels"
"github.com/prometheus/prometheus/promql"
)
func TestGroupEvalJSONLoggerRule(t *testing.T) {
expr, err := testParser.ParseExpr("up")
require.NoError(t, err)
for _, tc := range []struct {
name string
rule Rule
want string
}{
{
name: "recording",
rule: NewRecordingRule("recorded_metric", expr, labels.EmptyLabels()),
want: "record: recorded_metric\nexpr: up\n",
},
{
name: "alerting",
rule: NewAlertingRule("TestAlert", expr, 0, 0, labels.EmptyLabels(), labels.EmptyLabels(), labels.EmptyLabels(), "", false, promslog.NewNopLogger()),
want: "alert: TestAlert\nexpr: up\n",
},
} {
t.Run(tc.name, func(t *testing.T) {
var output bytes.Buffer
format := promslog.NewFormat()
require.NoError(t, format.Set("json"))
logger := promslog.New(&promslog.Config{Writer: &output, Format: format})
queryErr := errors.New("query failed")
group := NewGroup(GroupOptions{
Name: "test-group",
File: "test.rules",
Interval: time.Minute,
Rules: []Rule{tc.rule},
Opts: &ManagerOptions{
Logger: logger,
QueryFunc: func(context.Context, string, time.Time) (promql.Vector, error) {
return nil, queryErr
},
},
})
group.Eval(t.Context(), time.Unix(0, 0))
require.ErrorIs(t, tc.rule.LastError(), queryErr)
var entry struct {
Rule string `json:"rule"`
}
require.NoError(t, json.Unmarshal(output.Bytes(), &entry))
require.Equal(t, tc.want, entry.Rule)
})
}
}
func TestGroup_Equals(t *testing.T) {
tests := map[string]struct {
first *Group
second *Group
expected bool
}{
"no query offset set on both groups": {
first: &Group{
name: "group-1",
file: "file-1",
interval: time.Minute,
},
second: &Group{
name: "group-1",
file: "file-1",
interval: time.Minute,
},
expected: true,
},
"query offset set only on the first group": {
first: &Group{
name: "group-1",
file: "file-1",
interval: time.Minute,
queryOffset: pointerOf[time.Duration](time.Minute),
},
second: &Group{
name: "group-1",
file: "file-1",
interval: time.Minute,
},
expected: false,
},
"query offset set on both groups to the same value": {
first: &Group{
name: "group-1",
file: "file-1",
interval: time.Minute,
queryOffset: pointerOf[time.Duration](time.Minute),
},
second: &Group{
name: "group-1",
file: "file-1",
interval: time.Minute,
queryOffset: pointerOf[time.Duration](time.Minute),
},
expected: true,
},
"query offset set on both groups to different value": {
first: &Group{
name: "group-1",
file: "file-1",
interval: time.Minute,
queryOffset: pointerOf[time.Duration](time.Minute),
},
second: &Group{
name: "group-1",
file: "file-1",
interval: time.Minute,
queryOffset: pointerOf[time.Duration](2 * time.Minute),
},
expected: false,
},
}
for testName, testData := range tests {
t.Run(testName, func(t *testing.T) {
require.Equal(t, testData.expected, testData.first.Equals(testData.second))
require.Equal(t, testData.expected, testData.second.Equals(testData.first))
})
}
}
func pointerOf[T any](value T) *T {
return &value
}