* Run brew update in macOS CI
* Drop intel macOS from CI
* Fix build on Apple Clang 17+ (#18629)
Fixing "invalid cpu feature string for builtin" errors that started to appear on Apple Clang 17.0.0
(cherry picked from commit 772479ea2f)
* Cleanup macOS job in test-suite.yml
---------
Co-authored-by: Máté Kocsis <kocsismate@woohoolabs.com>
This reverts commit fa47ae16a1.
On macOS in GitHub Actions, pthread_jit_write_protect_supported_np() returns
false. So, there's really no point in running JIT with it in the first place.
We'll still need to tweak some tests when they explicitly enable the JIT.
This build is not useful for multiple reasons:
- Legitimate API changes keep making the build red. Frequently it takes 3rd
party extension developers months to fix these issues.
- Once we're annoyed enough by the red build we skip it and then don't revert it
way after it has been fixed.
- True accidental API changes are incredibly rare. I don't believe I've
experienced one yet.
- This build only runs for master, which is also the branch where accidental
changes are least problematic.
Closes GH-21980
git rev-parse fails with the long GH ref, but we need github.ref to check out
branches from PRs. Hence, use github.ref only for PRs, and the ref_name for
everything else.
Closes GH-21255
