0 Fork 0

mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2026-10-28 10:45:18 +08:00

Files

T

History

Om Kulkarni 8fa4bdc773 exporters/prometheus: preserve exemplar trace/span IDs over filtered attribute labels (#9031 )

## Summary

Fixes #6718.

prometheus client-go rejects exemplars whose combined label runes exceed
`prometheus.ExemplarMaxRunes` (128). `addExemplars` let that error
propagate up from `prometheus.NewMetricWithExemplars` and dropped every
exemplar for the data point when the limit was hit, even though the
trace and span ID labels alone are well within the limit and are the
most valuable part of an exemplar.

This checks each exemplar's combined label length against the limit
before building the exemplar. When it would exceed the limit, the
filtered-attribute-derived labels are dropped and only the trace and
span IDs are kept, with a warning logged via `global.Warn` so the
truncation is visible instead of silent.

## Test plan

- [x] Added `TestExemplarsExceedingLabelLimit`, verified it fails
without the fix (exemplar dropped entirely) and passes with it
(trace/span IDs preserved, filtered attributes dropped).
- [x] `go test ./... -race`
- [x] `make precommit`

2026-10-26 09:39:36 +00:00

internal

Release 1.47.0/0.69.0/0.23.0/0.1.0 (#9024 )

2026-10-02 10:10:46 +02:00

testdata

prometheus exporter ignores metrics from the Prometheus bridge (#7688 )

2025-12-09 13:50:55 -05:00

benchmark_test.go

Improve benchmark coverage in exporters/prometheus (#9240 )

2026-10-20 09:29:15 +00:00

config_test.go

Remove vanity import tooling (#8609 )