openssl

0 Fork 0

mirror of https://github.com/openssl/openssl.git synced 2026-10-29 08:56:08 +08:00

Files

T

History

Adel-Ayoub 05b65fcb22 crypto/pkcs12/p12_decr.c: fix EVP_CIPHER_CTX_ctrl error checks

EVP_CIPHER_CTX_ctrl() reports failure of the EVP_CTRL_AEAD_TLS1_AAD
and EVP_CTRL_AEAD_SET_TAG controls as 0, not as a negative value,
so the "< 0" checks on the cipher-with-MAC path cannot detect any
failure.  A return of 0 means a failed or unsupported control, or
for EVP_CTRL_AEAD_TLS1_AAD a zero MAC length, none of which is
usable here.

Change both checks to "<= 0", matching the EVP_CTRL_AEAD_GET_TAG
check fixed by commit 674c23d265 in this function.

Follow-up to https://github.com/openssl/openssl/pull/30923.

Fixes: ea0add4a82 "New GOST PKCS12 standard support"

CLA: trivial

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Andrew Dinh <andrewd@openssl.org>
Reviewed-by: Jakub Zelenka <jakub.zelenka@openssl.foundation>
MergeDate: Mon Jul 27 10:21:13 2026
(Merged from https://github.com/openssl/openssl/pull/31848)

2026-07-27 12:21:09 +02:00

aes

Further improve the decryption performance of AES-128-CBC on the RISC-V architecture

2026-06-18 14:21:37 +02:00

aria

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

asn1

use safe_math on do_name_ex

2026-07-23 10:24:01 +02:00

async

Remove direct includes of windows.h where possible

2026-06-20 07:00:32 -04:00

Move common macro definitions to internal/common.h and fix comments.

2026-06-11 17:51:31 +02:00

bio

Make sure we always check return of CRYPTO_UP_REF which can fail.

2026-07-20 13:13:57 +02:00

Avoid undefined behavior adding or subtracting two BN_zero() values

2026-07-10 16:54:46 +02:00

buffer

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

camellia

Convert use of artisinally made hand crafted integer types

2026-05-27 11:08:08 +02:00

cast

Move common macro definitions to internal/common.h and fix comments.

2026-06-11 17:51:31 +02:00

chacha

We no longer need to test for GCC versions this old

2026-07-10 07:47:13 -04:00

cmac

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

cmp

Convert internal use of ASN1_STRING_set and ASN1_STRING_length

2026-07-18 15:01:13 +02:00

cms

Convert internal use of ASN1_STRING_set and ASN1_STRING_length

2026-07-18 15:01:13 +02:00

comp

Remove direct includes of windows.h where possible

2026-06-20 07:00:32 -04:00

conf

Guard output of keysets.pl

2026-05-06 13:35:41 +02:00

crmf

Fix potential NULL dereference in OSSL_CRMF_ENCRYPTEDVALUE_decrypt()

2026-06-11 17:08:41 +02:00

Convert internal use of ASN1_STRING_set and ASN1_STRING_length

2026-07-18 15:01:13 +02:00

des

We no longer need to test for GCC versions this old

2026-07-10 07:47:13 -04:00

Make sure we always check return of CRYPTO_UP_REF which can fail.

2026-07-20 13:13:57 +02:00

dsa

Make sure we always check return of CRYPTO_UP_REF which can fail.

2026-07-20 13:13:57 +02:00

dso

Make sure we always check return of CRYPTO_UP_REF which can fail.

2026-07-20 13:13:57 +02:00

Make sure we always check return of CRYPTO_UP_REF which can fail.

2026-07-20 13:13:57 +02:00

encode_decode

Add return check to OSSL_DECODER_up_ref

2026-07-23 10:24:01 +02:00

err

errors: fix stale string overrides in openssl.txt for renamed SSL error codes

2026-07-21 10:28:19 -04:00

ess

2026-03-10 14:37:52 +00:00

evp

Make sure we always check return of CRYPTO_UP_REF which can fail.

2026-07-20 13:13:57 +02:00

ffc

Consistenly zeroize public parameters based on OPENSSL_PEDANTIC_ZEROIZATION

2026-06-10 14:52:07 +02:00

hashtable

Optimize hashtable without rcu freeing

2026-05-21 11:09:28 +02:00

hmac

s390x: Fix return code handling in HMAC_Init_ex()

2026-06-30 22:48:43 +02:00

hpke

crypto/hpke/hpke_util: Fixes redundant mdname is valid check.

2026-06-03 13:30:02 +02:00

http

http_lib.c: add check that host_end is not past authority_end

2026-06-10 08:26:54 +02:00

idea

Move common macro definitions to internal/common.h and fix comments.

2026-06-11 17:51:31 +02:00

kdf

Deprecate ERR_load_KDF_strings()

2019-11-12 13:30:35 +01:00

lhash

Make the crypto includes self-contained

2026-05-06 13:35:41 +02:00

lms

lms: free previous encoded public key in ossl_lms_pubkey_decode

2026-06-25 18:58:41 +02:00

md2

Fix broken hex data by reformatting

2026-06-03 09:46:03 +02:00

md4

Add missing header guards in local crypto includes.

2026-05-06 13:35:24 +02:00

md5

crypto: use void * in RISC-V digest shims

2026-07-23 17:43:21 +02:00

mdc2

Move common macro definitions to internal/common.h and fix comments.

2026-06-11 17:51:31 +02:00

ml_dsa

ML-DSA: Add AVX512VL SHAKE x4 multi-buffer integration

2026-07-13 17:55:51 +02:00

ml_kem

ml_kem: Add a check for shared_secret

2026-07-20 13:21:13 +02:00

modes

ghash-armv4.pl: add missing alignment for gcm_gmult_4bit

2026-06-10 09:51:13 +02:00

objects

Fix DSA with SHA-384 / SHA-512 X.509 verification (issue openssl#30432)

2026-07-20 13:10:45 +02:00

ocsp

Guard against NULL data in empty ASN1_STRINGs

2026-07-21 14:54:46 +02:00

pem

crypto/pem/pem_info.c: avoid switching on PEM_INFO_NONE

2026-07-02 09:26:18 +02:00

perlasm

Updated broken documentation links in various files

2026-04-03 17:17:33 +02:00

pkcs7

Convert internal use of ASN1_STRING_set and ASN1_STRING_length

2026-07-18 15:01:13 +02:00

pkcs12

crypto/pkcs12/p12_decr.c: fix EVP_CIPHER_CTX_ctrl error checks

2026-07-27 12:21:09 +02:00

poly1305

Remove unused source files poly1305_ieee754.c and poly1305_base2_44.c

2026-07-08 13:15:52 +02:00

property

Don't take reference counts on cache lookups

2026-06-25 17:25:05 -04:00

rand

rand: factor out seed source creation and fix store race

2026-07-27 11:13:05 +02:00

rc2

Move common macro definitions to internal/common.h and fix comments.

2026-06-11 17:51:31 +02:00

rc4

Fix typos

2026-07-08 12:45:09 +02:00

rc5

We no longer need to test for GCC versions this old

2026-07-10 07:47:13 -04:00

ripemd

Add missing header guards in local crypto includes.

2026-05-06 13:35:24 +02:00

rsa

Make sure we always check return of CRYPTO_UP_REF which can fail.

2026-07-20 13:13:57 +02:00

seed

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

sha

crypto: use void * in LoongArch SHA shim

2026-07-23 17:43:21 +02:00

siphash

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

slh_dsa

Eliminate/fix repeated word usage

2026-07-08 12:07:53 +02:00

sm2

Convert internal use of ASN1_STRING_set and ASN1_STRING_length

2026-07-18 15:01:13 +02:00

sm3

Fix nasm version check for sm3 & sm4 perlasm files

2026-07-13 17:46:52 +02:00

sm4

Fix nasm version check for sm3 & sm4 perlasm files

2026-07-13 17:46:52 +02:00

srp

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

stack

stack: use a copy thunk for typed stack deep copies

2026-05-20 11:53:32 -04:00

store

Make sure we always check return of CRYPTO_UP_REF which can fail.

2026-07-20 13:13:57 +02:00

thread

Remove direct includes of windows.h where possible

2026-06-20 07:00:32 -04:00

Convert internal use of ASN1_STRING_set and ASN1_STRING_length

2026-07-18 15:01:13 +02:00

txt_db

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

Drop Windows CE support.

2026-06-25 09:26:55 +02:00

whrlpool

We no longer need to test for GCC versions this old

2026-07-10 07:47:13 -04:00

x509

x509: keep RFC 3779 stacks hole-free after a failed canonize

2026-07-27 09:59:20 +02:00

aligned_alloc.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

alphacpuid.pl

2025-09-02 13:05:45 +00:00

arm64cpuid.pl

Move *_arch.h to include/arch

2026-05-10 11:53:33 +02:00

armcap.c

Added Nvidia/Olympus CPU dispatch for SHA3/EOR3 AES GCM on Vera CPU

2026-07-23 10:26:05 +02:00

armv4cpuid.pl

armv4cpuid.pl: add missing function alignment

2026-06-10 09:51:13 +02:00

array_alloc.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

asn1_dsa.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

bsearch.c

ossl_bsearch: Fix possible integer overflow bug

2026-03-13 09:35:23 +01:00

build.info

Drop Windows-on-Itanium (VC-WIN64I) support.

2026-07-10 13:39:24 -04:00

c64xpluscpuid.pl

2025-09-02 13:05:45 +00:00

comp_methods.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

context.c

delay method store free in context_deinit_objs

2026-06-25 17:25:43 -04:00

core_algorithm.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

core_fetch.c

Extend refcounting on evp objects to provider requesed no-caching

2026-07-02 10:24:10 -04:00

core_namemap.c

Simplify ossl_namemap_name2num with ossl_namemap_name2num_n

2026-03-24 18:47:53 +01:00

cpt_err.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

cpuid.c

Add constant-time validation for CRYPTO_memcmp

2026-06-11 18:11:57 +02:00

cryptlib.c

Drop Watcom C compiler support.

2026-07-10 07:46:53 -04:00

ctype.c

crypto/ctype.c: fix off-by-one OOB in ossl_toascii()/ossl_fromascii()

2026-06-25 09:19:25 +02:00

cversion.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

defaults.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

der_writer.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

deterministic_nonce.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

dllmain.c

Revert "Make cpuid_setup non-constructor"

2026-04-02 09:17:47 +02:00

ebcdic.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

ex_data.c

2026-03-10 14:37:52 +00:00

getenv.c

Drop Windows CE support.

2026-06-25 09:26:55 +02:00

ia64cpuid.S

2025-09-02 13:05:45 +00:00

indicator_core.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

info.c

Clean up the cpu id stuff by hoisting the append into a helper

2026-06-30 13:02:49 +02:00

init.c

Move *_arch.h to include/arch

2026-05-10 11:53:33 +02:00

initthread.c

Update NEWS.md

2025-12-19 12:06:38 -05:00

loongarch64cpuid.pl

2025-03-12 13:35:59 +00:00

loongarchcap.c

Move *_arch.h to include/arch

2026-05-10 11:53:33 +02:00

LPdir_nyi.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

LPdir_unix.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

LPdir_vms.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

LPdir_win32.c

Disable clang format around .c includes

2025-12-03 14:40:56 +01:00

LPdir_win.c

Drop Windows CE support.

2026-06-25 09:26:55 +02:00

mem_clr.c

Following the license change, modify the boilerplates in crypto/

2018-12-06 15:32:17 +01:00

mem_sec.c

Remove direct includes of windows.h where possible

2026-06-20 07:00:32 -04:00

mem.c

crypto/mem.c: perform the fail check right after counting calls

2026-04-30 06:58:48 +00:00

o_dir.c

Drop Windows CE support.

2026-06-25 09:26:55 +02:00

o_fopen.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

o_init.c

Update copyright year

2022-05-03 13:34:51 +01:00

o_str.c

Drop Windows CE support.

2026-06-25 09:26:55 +02:00

packet.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

param_build_set.c

Handle NULL-buffer size probe in ossl_param_build_set_bn_pad()

2026-04-26 15:35:31 +02:00

param_build.c

OSSL_PARAM_BLD_push_octet_*(): Allow NULL buffer with 0 bsize

2026-04-13 09:47:42 +02:00

params_dup.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

params_from_text.c

2026-03-10 14:37:52 +00:00

params.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

pariscid.pl

2025-09-02 13:05:45 +00:00

passphrase.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

ppccap.c

We no longer need to test for GCC versions this old

2026-07-10 07:47:13 -04:00

ppccpuid.pl

2025-09-02 13:05:45 +00:00

provider_child.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

provider_conf.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

provider_core.c

Make sure we always check return of CRYPTO_UP_REF which can fail.

2026-07-20 13:13:57 +02:00

provider_local.h

Add missing header guards in local crypto includes.

2026-05-06 13:35:24 +02:00

provider_predefined.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

provider.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

punycode.c

2026-03-10 14:37:52 +00:00

quic_vlint.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

rcu_internal.h

Make the crypto includes self-contained

2026-05-06 13:35:41 +02:00

README-sparse_array.md

Fix many MarkDown issues in {NOTES*,README*,HACKING,LICENSE}.md files

2020-07-05 11:29:43 +02:00

riscv32cpuid.pl

RISC-V: Use address for vlenb CSR

2025-09-09 11:18:42 +02:00

riscv64cpuid.pl

RISC-V: Use address for vlenb CSR

2025-09-09 11:18:42 +02:00

riscvcap.c

We no longer need to test for GCC versions this old

2026-07-10 07:47:13 -04:00

s390xcap.c

s390x: Selectively re-format s390xcap.c

2026-06-01 09:49:19 +02:00

s390xcpuid.pl

Move *_arch.h to include/arch

2026-05-10 11:53:33 +02:00

self_test_core.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

sleep.c

Remove direct includes of windows.h where possible

2026-06-20 07:00:32 -04:00

sparccpuid.S

Revert "Make cpuid_setup non-constructor"

2026-04-02 09:17:47 +02:00

sparcv9cap.c

We no longer need to test for GCC versions this old

2026-07-10 07:47:13 -04:00

sparse_array.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

ssl_err.c

errors: fix stale string overrides in openssl.txt for renamed SSL error codes

2026-07-21 10:28:19 -04:00

sslerr.h

errors: fix stale string overrides in openssl.txt for renamed SSL error codes

2026-07-21 10:28:19 -04:00

threads_common.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

threads_lib.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

threads_none.c

Provide independent lock failure signal on cmp_exch_ptr

2026-06-09 13:46:05 -04:00

threads_pthread.c

Fix persniketyness in tsan

2026-06-09 14:02:45 -04:00

threads_win.c

ensure writes are syncronized on windows in CRYPTO_THREAD_run_once

2026-06-30 10:51:14 +02:00

time.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

trace.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

uid.c

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09 00:28:19 -07:00

vms_rms.h

Add missing header guards in local crypto includes.

2026-05-06 13:35:24 +02:00

x86_64cpuid.pl

Revert "Make cpuid_setup non-constructor"

2026-04-02 09:17:47 +02:00

x86cpuid.pl

Revert "Make cpuid_setup non-constructor"

2026-04-02 09:17:47 +02:00