Files
Peter Steinberger 2f0b6a71dd test: remove low-value tests (batch d581) (#184029)
* test(memory): deslop s0999 tests

Remove the shared-root replay covered by file-watcher.lifecycle.test.ts (shares roots across agents, fans out selected events, and joins the last release) and local-file-watcher.integration.test.ts (restores shared subscriptions after a worker crash and joins its final exit). Preserve the started-health assertion in the health protocol case and remove unused event cursor plumbing.

Keep discovery cancellation, fallback/capacity event delivery, port-loss retirement and failed shutdown settlement. Static-only validation: oxfmt, plain oxlint, and git diff --check; runtime tests deferred to hosted CI per campaign instructions. Lines: 213 to 194; cases: 5 to 4. Below the 25% line target to retain distinct lifecycle and protocol checks.

* test(memory): consolidate s0999 worker assertions

Unify event matching and fixture reset, remove redundant close-call counts, and retain real worker lifecycle settlement assertions.

Fallback payload formatting remains covered by file-watcher.lifecycle.test.ts: reports fallback polling once with reason. Ready health remains covered by local-file-watcher.integration.test.ts: restores shared subscriptions after a worker crash and joins its final exit. Keep capacity, unavailable, and dirty delivery at the worker port boundary.

Shard lines: 213 original, 194 prior commit, 159 final (-25.4%). Four remaining cases unchanged in count. CI-only validation: oxfmt, plain oxlint and git diff --check; no test or coverage runs.

* test(cli): deslop s1000 tests

* test(cli): consolidate s1000 command boundary cases

* test(secrets): deslop s0998 tests

Share dialog and input setup and reuse the Gateway hello fixture. Preserve all three lifecycle cases and their assertions: stale reconnect reads and unmount cleanup, failed-save retry and replacement, and route retirement during an admitted save. These protect distinct presentation boundaries introduced in d9e63d0471.

* test(secrets): consolidate s0998 lifecycle scenarios

Share the connection-scoped read, draft, failed save and retry flow across reconnect and route retirement cases. Keep distinct pending-save retirement and unmount assertions. Reuse change listeners and the UI harness cleanup; replace hand-written input dispatch with fireEvent.

Remove duplicate list call-shape checks. Cancel-dialog coverage remains in secrets.e2e.test.ts: validates and saves protected, environment, and mixed bulk entries. That case also retains the environment-save path while this lifecycle flow verifies protected-name normalization and draft retention.

* test(ui): deslop s1001 tests

Share stale lookup retirement setup across initial and retry ID changes and client replacement, retaining all nine cases and their lifecycle assertions. Factor repeated question replies and panel input helpers; remove the duplicate q3 text assertion already checked by waitForSolid.

* test(ui): consolidate s1001 question lifecycle coverage

Combine same-turn ID coalescing with held lookup retirement while retaining ID/client retry cases and standalone collapse-focus regression d3359fe448. Remove duplicate request-shape assertions and redundant settling before observable waits.

Reopen focus remains covered by chat-question-card.test.tsx: honors initial autofocus opt-out and focuses the panel when expanded. Draft retention remains covered by keeps a typed answer distinct from an identical option across remounts. Typed submission is covered by uses Ctrl+Enter in Other to submit a multiline answer; this page retains reconnect, retry and answer-summary proof.

* test(browser): deslop s1002 tests

* test(openshell): deslop s1004 tests

Share registry registration and teardown across lifecycle cases and compact the File Transfer config fixture. Preserve all global/scoped cleanup, discovery, live binding, and unstarted-retirement assertions. CI-only campaign: formatting, diff check, and plain oxlint verified; runtime proof deferred to hosted CI.

* test(openshell): consolidate s1004 lifecycle coverage

Exercise scoped and global cleanup in one reason table while retaining empty scope identifiers, reset preservation, repeated registration, and idempotent retirement. Keep discovery, live binding, and unstarted retirement contracts separate.

Drop the copied manager method inventory; manager presence/restoration remains asserted here, with describeRuntime and removeRuntime behavior covered by extensions/openshell/src/openshell-core.test.ts. Consolidate SDK imports and use test-finalization cleanup for registry restoration. CI-only: plain oxlint, oxfmt, and diff checks pass; no tests run.

* test(daemon): deslop s1007 tests

Share the native launcher path across registration, probe, and file mapping fixtures. Consolidate process-query marker matching without changing its same-argument requirement. Preserve all fixture exports and lifecycle behavior.

* test(gateway): deslop s1005 tests

Trim unused auth context and transport construction for plugin-owned routes. Keep instance cleanup with the owning fixture instead of a suite-global registry.

Retain all eight ownership cases from regression b25510f18d: transport-specific shared callbacks, static/dynamic/anonymous projection, upgrade callback ownership, in-flight disposal ordering, and host retry handoff. These distinct lifecycle and authority behaviors prevent reaching the 25 percent line target safely.

CI-only validation: oxfmt, plain oxlint, and git diff --check passed; no runtime tests or coverage run.

* test(gateway): consolidate s1005 ownership lifecycle proof

Combine shared-callback retirement and selected-owner drain into one lifecycle scenario per HTTP/WebSocket transport. Keep nested static/dynamic/anonymous projection, untracked upgrade rejection, and host retry handoff checks.

Drop internal callback identity and diagnostic-log assertions, inline the two dynamic registrations, and use fixture-owned cleanup plus the existing typed logger helper. No production or helper files changed.

Shard lines: 209 baseline -> 195 prior commit -> 156 (25.4% total reduction). Declarations 5 -> 4; expanded cases 8 -> 7. CI-only: formatting, plain oxlint, and diff checks passed; no tests run.

* test(advisor): deslop s1006 tests

Collapse the setup/start harness and use the existing runtime config default for built-in review guidance. Keep all eight declarations and twelve expanded cases: tool thresholds, real/native receipts, raw-child ordering and shared IDs, dispatch rechecks, malformed/no-change replies, user-only admission, both cancellation paths, and disabled registration each protect distinct behavior. The suite is already tight, so retain those checks rather than forcing the 25% line target. CI-only validation: oxlint, oxfmt, and diff checks; no test execution.

* test(advisor): consolidate s1006 event harness

Combine threshold, queued-dispatch, and post-review native completion checks into one continuous owner flow. Preserve explicit zero/one/two-review checkpoints and session-targeted correction assertions. Exercise both raw call kinds with the stronger shared-ID collision fixture. Keep malformed/no-change replies, user admission, normal/aborted cancellation, and disabled registration independently covered.

Replace redundant event wrappers with one send/checkpoint helper, reuse SDK mock defaults, and drop the prompt assertion that repeated its imported implementation constant. Shard test LOC: 208 original -> 200 prior -> 155 now. Static validation: oxlint, oxfmt, git diff --check. No tests run under CI-only instructions.

* test(lobsterdex): deslop s1008 tests

Keep one discovery flow for the shared per-palette branches and retain all three hash lifecycle cases. Consolidate fixture setup and DOM assertions.

Artwork presence remains covered by lobster-pet-look.browser.test.ts (Clawnstantine sash); copy-link controls remain covered by lobsterdex-page.e2e.test.ts (fallback and newest-copy feedback).

* test(document-extract): deslop s1009 tests

Consolidate text, Unicode, page selection and pixel-budget truncation into one extraction scenario. Retain all four PNG geometry cases, both cancellation stages and distinct error outcomes.

Drop duplicate PNG signature and input-buffer checks: document-extractor.test.ts covers them in renders real pages within the aggregate pixel budget and extracts explicit pages. Keep image metadata in the combined budget case and ordering in the selection case.

* test(qa-lab): deslop s1010 tests

Keep all eight auth isolation, rejection, merge, and replacement cases. Replace indexed parallel staging fixtures with self-contained results and reuse fixed credential fixtures for complete round-trip assertions. No production changes; runtime proof deferred to batch CI.

* test(qa-lab): consolidate s1010 auth store fixtures

Unify old/future/invalid host isolation in one concurrent-staging table and retain rejection plus byte-preservation checks for each bad auth source. Share the credential merge/replace lifecycle fixture while retaining stale metadata clearing assertions. The requested-agent/provider config mapping is already covered by gateway-child-auth-profiles.test.ts: stages mock profiles only for the requested agents and providers when callers override the defaults. Drop its duplicate config shape and display-name wording assertion here. Reduce the shard from its original 206 lines to 154; static checks only per CI-only mode.

* test(outbound): deslop s1011 tests

Remove duplicate SQLite observer calibration; the same observer is calibrated by session-logical-entry-read.worker.test.ts (preserves logical and physical owners without parent SQLite calls). Retain both real routing cases and all four native owner/database invalidation cases, including the ingress retry regression from 15a39da700. Share repeated dispatch arguments without changing admission ordering.

* test(outbound): consolidate s1011 binding fixtures

Share native binding setup and owner cleanup without removing any of the six cases. Use the real default route builder, retain worker SQL and admission invalidation checks, and make retry age deterministic. Projection-only record/availability assertions remain covered by src/channels/plugins/binding-routing.test.ts in routes %s within its owner scope. Total shard reduction: 206 to 154 lines.

* test(vllm): deslop s1012 tests

Share model and payload assertion setup and table equivalent template-default checks. Preserve Qwen bypass, effort mapping and disablement, DeepSeek cleanup and explicit kwargs, and Nemotron alias and composition assertions. No behavior cases deleted; hosted CI owns runtime proof.

* test(vllm): consolidate s1012 payload coverage

Remove mapping replays covered by provider-policy-api.test.ts (maps compat/model keys to wire labels) and packages/ai/src/providers/openai-request-reasoning.test.ts (request-boundary native-case and mapping cases). Retain vLLM effort forwarding and explicit disablement. Exercise alias matching in the malformed-template cases, share fixtures, and assert ignored request params through the unchanged payload rather than wrapper identity. Static checks only; runtime proof deferred to hosted CI.

* test(agents): deslop s1013 tests

Reuse the session family fixture and supported question gateway injection. Preserve all six answer/timeout and own-before/own-in-flight/foreign rewrite cases, including stale-writer rejection and transcript integrity assertions.

* test(agents): finish structural cuts for s1013

Keep all six settlement scenarios and the rewrite-command interleaving. Trim fixture construction, worker forwarding, and artificial result wrappers. Persisted rewritten ancestry and unchanged foreign snapshots retain the integrity proof without the internal mutation counter. Exact default timeout arguments remain covered by ask-user-tool.test.ts: returns answered details plus readable answer lines.

* test(memory-core): deslop s1016 tests

Remove the redundant daily write/read follow-on; dreaming-phases.test.ts covers daily persistence in 'retains current unvisited daily checkpoints and prunes notes outside lookback'. Keep all three distinct Doctor migration cases and the independently encoded July envelope, immutable store snapshots, rollback file checks, and current-reader assertions.

* test(memory-core): trim s1016 migration fixture layer

Keep independently encoded July envelopes, exact store preservation, workspace readback, retired-file bytes, and all three migration decisions. Use minimal opaque row payloads because Doctor only checks presence.

Domain readers remain covered in dreaming-phases.test.ts by 'retains current unvisited daily checkpoints and prunes notes outside lookback' and 'checkpoints session transcript ingestion and skips unchanged transcripts'; short-term-promotion.test.ts covers 'records short-term recall for notes stored in spaced and Unicode memory subdirectories' and 'boosts deep ranking when light/rem phase signals reinforce a candidate'; short-term-promotion-store.test.ts retains the phase string-field read contract.

* test: preserve distinct contracts in d581 consolidation

* test: repair d581 fixture CI gates

* test: prune retired node CLI mock allowances
2026-10-26 02:04:53 +00:00
..