Trivikram Kamat 41e9ab96cd watch: escape quotes and backslashes in NODE_OPTIONS ...

When stripping watch flags, NODE_OPTIONS is tokenized and rejoined
for the child process. Values were only re-quoted if they contained
a space, and nothing inside the quotes was escaped. A value with a
double quote made the child fail with "unterminated string", and a
backslash inside a quoted value was silently dropped.

Quote values that contain a space or a double quote, and escape
backslashes and double quotes inside the quotes, so the child
tokenizes the string back to the same values.

Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
Assisted-by: claude:opus-5.5
PR-URL: https://github.com/nodejs/node/pull/66363
Fixes: https://github.com/nodejs/node/issues/66362
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

2026-10-06 01:43:12 +02:00

..

sequential.status

test: deflake http server mixed request timeouts

2026-10-03 17:30:23 +02:00

test-async-wrap-getasyncid.js

src: remove orphaned js_udp_wrap test binding

2026-10-03 17:30:26 +02:00

test-buffer-creation-regression.js

test: prepare for consistent comma-dangle lint rule

2021-04-01 23:14:29 -07:00

test-child-process-emfile.js

test: add escapePOSIXShell util

2024-09-29 20:44:52 +00:00

test-child-process-execsync.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-child-process-exit.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-child-process-pass-fd.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-cli-syntax-bad.js

module: fix --check on ambiguous ESM files

2026-08-26 00:56:00 +02:00

test-cli-syntax-file-not-found.js

test: add escapePOSIXShell util

2024-09-29 20:44:52 +00:00

test-cli-syntax-good.js

test: add escapePOSIXShell util

2024-09-29 20:44:52 +00:00

test-cli-syntax-require.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-cluster-inspect-brk.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-cluster-net-listen-ipv6only-none.js

lib,src: update cluster to use Parent

2021-01-05 15:41:45 -05:00

test-cluster-net-listen-ipv6only-rr.js

lib,src: update cluster to use Parent

2021-01-05 15:41:45 -05:00

test-cluster-port-reuse-between-workers.js

cluster: fix port reuse between cluster

2026-01-14 10:39:15 +00:00

test-cluster-send-handle-large-payload.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-cpu-prof-default.js

test: use spawnSync helpers in cpu-prof tests

2026-09-28 23:54:49 +02:00

test-cpu-prof-dir-absolute.js

test: use spawnSync helpers in cpu-prof tests

2026-09-28 23:54:49 +02:00

test-cpu-prof-dir-and-name.js

test: use spawnSync helpers in cpu-prof tests

2026-09-28 23:54:49 +02:00

test-cpu-prof-dir-relative.js

test: use spawnSync helpers in cpu-prof tests

2026-09-28 23:54:49 +02:00

test-cpu-prof-dir-worker.js

test: use spawnSync helpers in cpu-prof tests

2026-09-28 23:54:49 +02:00

test-cpu-prof-drained.js

test: use spawnSync helpers in cpu-prof tests

2026-09-28 23:54:49 +02:00

test-cpu-prof-exit.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-cpu-prof-invalid-options.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-cpu-prof-kill.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-cpu-prof-name.js

test: use spawnSync helpers in cpu-prof tests

2026-09-28 23:54:49 +02:00

test-cpu-prof-worker-argv.js

test: use spawnSync helpers in cpu-prof tests

2026-09-28 23:54:49 +02:00

test-crypto-timing-safe-equal-fast.js

crypto: fix argument validation in crypto.timingSafeEqual fast path

2025-11-03 22:18:51 +00:00

test-crypto-timing-safe-equal.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-debug-prompt.js

test: unflake debugger and REPL tests

2026-08-05 11:15:09 +02:00

test-debugger-custom-port.js

test: update startCLI to set --port=0 by default

2025-07-20 17:37:28 +00:00

test-debugger-debug-brk.js

process: move DEP0062 (node --debug) to end-of-life

2019-02-02 05:45:05 +08:00

test-debugger-invalid-args.js

test: update startCLI to set --port=0 by default

2025-07-20 17:37:28 +00:00

test-debugger-launch.mjs

test: forbid use of named imports for fixtures

2026-01-01 23:48:26 +00:00

test-debugger-pid.js

test: deflake debugger PID attachment and cleanup

2026-10-03 17:30:22 +02:00

test-debugger-quit-after-exit.js

test: deflake debugger PID attachment and cleanup

2026-10-03 17:30:22 +02:00

test-deprecation-flags.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-dgram-bind-shared-ports.js

lib,src: update cluster to use Parent

2021-01-05 15:41:45 -05:00

test-dgram-implicit-bind-failure.js

dgram: skip dns.lookup() for literal IP addresses

2026-07-03 16:05:17 +00:00

test-dgram-pingpong.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-diagnostic-dir-cpu-prof.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-diagnostic-dir-heap-prof.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-dtls-interop-openssl-client.mjs

net: improve dtls cert verification

2026-09-15 10:49:06 +02:00

test-dtls-interop-openssl-server.mjs

src,lib: add dtls interop tests

2026-09-15 10:49:06 +02:00

test-error-serdes.js

lib: improve node:bench stream handling

2026-09-15 10:49:33 +02:00

test-fs-opendir-recursive.js

test: ensure assertions are reached on more tests

2025-11-11 09:56:18 +00:00

test-fs-readdir-recursive.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-fs-stat-sync-overflow.js

test: use spawn and spawnPromisified instead of exec

2023-08-05 07:29:53 +00:00

test-fs-watch.js

test: rely less on duplicative common test harness utilities

2025-01-25 07:23:09 +00:00

test-gc-http-client-onerror.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-gc-http-client-timeout.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-gc-http-client.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-get-heapsnapshot-options.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-heapdump-flag-custom-dir.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-heapdump-flag.js

test: use assert.match instead of regexp.test

2021-08-31 18:50:16 +02:00

test-heapdump.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-http2-large-file.js

test: optimize test-http2-large-file

2019-03-20 09:50:52 -07:00

test-http2-max-session-memory.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-http2-ping-flood.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-http2-settings-flood.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-http2-timeout-large-write-file.js

test: implement low-risk test optimizations

2026-09-16 23:37:11 +02:00

test-http2-timeout-large-write.js

test: implement low-risk test optimizations

2026-09-16 23:37:11 +02:00

test-http-econnrefused.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-http-keep-alive-large-write.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-http-keepalive-maxsockets.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-http-regr-gh-2928.js

test: reduce the number of requests and parsers

2023-10-20 12:56:44 +00:00

test-http-server-keep-alive-timeout-slow-client-headers.js

test: move timing-dependent tests to sequential

2017-07-22 07:53:27 +03:00

test-http-server-keep-alive-timeout-slow-server.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-http-server-request-timeouts-mixed.js

test: deflake http server mixed request timeouts

2026-10-03 17:30:23 +02:00

test-https-connect-localport.js

test: implement low-risk test optimizations

2026-09-16 23:37:11 +02:00

test-https-server-keep-alive-timeout.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-init.js

test: rely less on duplicative common test harness utilities

2025-01-25 07:23:09 +00:00

test-inspector-network-resource.js

test: make test-inspector-network-resource sequential

2025-07-28 13:29:23 +00:00

test-inspector-open-dispose.mjs

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-inspector-port-cluster.js

test: enforce better never-settling-promise detection

2025-12-10 23:55:36 +00:00

test-module-loading.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-net-better-error-messages-port.js

net: enable autoSelectFamily by default

2023-04-05 08:31:56 -07:00

test-net-connect-econnrefused.js

test: improve sequential test performance

2026-09-16 21:12:15 +02:00

test-net-connect-handle-econnrefused.js

net: remove redundant connecting assignment

2022-07-09 17:10:16 +01:00

test-net-connect-local-error.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-net-GH-5504.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-net-listen-ipv6only.js

test: deflake test-net-listen-ipv6only

2026-08-26 00:56:17 +02:00

test-net-listen-shared-ports.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-net-localport.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-net-reconnect-error.js

net: enable autoSelectFamily by default

2023-04-05 08:31:56 -07:00

test-net-response-size.js

test: enable no-empty ESLint rule

2022-02-05 12:58:32 +00:00

test-net-server-address.js

dns: accept 'IPv4' and 'IPv6' for family

2022-06-15 18:02:01 -04:00

test-net-server-bind.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-net-server-listen-ipv6-link-local.js

test: use valid hostnames

2024-08-25 22:16:25 +00:00

test-next-tick-error-spin.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-perf-hooks-histogram-heapdump.js

test: expand histogram test coverage

2026-09-17 17:24:34 +02:00

test-perf-hooks.js

test: fix incorrect calculation in test-perf-hooks.js

2025-10-18 12:21:44 +00:00

test-performance-eventloopdelay.js

test: avoid timer race in event loop delay test

2026-08-26 00:56:09 +02:00

test-pipe.js

test: improve sequential test performance

2026-09-16 21:12:15 +02:00

test-process-title.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-process-warnings.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-repl-timeout-throw.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-require-cache-without-stat.js

test: forbid use of named imports for fixtures

2026-01-01 23:48:26 +00:00

test-resolution-inspect-brk.js

module: ignore resolution failures for inspect-brk

2019-12-04 23:30:25 -05:00

test-runner-run-inspect.mjs

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-stream2-fs.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-stream2-stderr-sync.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-timers-block-eventloop.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-timers-set-interval-excludes-callback-duration.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-tls-connect.js

test: update tls/crypto behaviour expectations when using BoringSSL

2026-05-19 21:38:38 +02:00

test-tls-lookup.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-tls-psk-client.js

test,benchmark: use OpenSSL feature helpers

2026-09-16 23:06:51 +02:00

test-tls-session-timeout.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-util-debug.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-vm-break-on-sigint.js

test: move test-vm-break-on-sigint to sequential

2022-08-07 12:26:59 +00:00

test-vm-timeout-escape-promise-module-2.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-vm-timeout-rethrow.js

test: use assert.match instead of regexp.test

2021-08-31 18:50:16 +02:00

test-watch-mode-inspect.mjs

test: fix flaky test-watch-mode-inspect timeout

2026-05-19 14:08:25 +02:00

test-watch-mode-process-timeout.mjs

src: add --process-timeout=N

2026-09-29 00:33:14 +02:00

test-watch-mode-restart-esm-loading-error.mjs

test: deflake test-watch-mode-restart-esm-loading-error

2026-09-08 22:03:35 +02:00

test-watch-mode-watch-flags.mjs

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-watch-mode-worker.mjs

watch: print name of changed file that triggers restart

2026-06-22 08:58:18 +02:00

test-watch-mode.mjs

watch: escape quotes and backslashes in NODE_OPTIONS

2026-10-06 01:43:12 +02:00

test-without-async-context-frame.mjs

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-worker-eventlooputil.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-worker-fshandles-error-on-termination.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-worker-fshandles-open-close-on-termination.js

test: move tests with many workers to sequential

2022-08-07 12:44:33 +00:00

test-worker-heapsnapshot-options.js

lib: add options to the heap snapshot APIs

2022-11-08 16:19:54 +01:00

test-worker-prof.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-write-heapsnapshot-options.js

tools: enforce trailing commas in test/sequential

2025-12-03 14:17:37 +01:00

test-zlib-crc32-fast-api.js

zlib: implement fast path for crc32

2025-09-14 00:39:58 +00:00

testcfg.py

test: split test in parallel/sequential

2014-12-17 20:45:02 +07:00