mirror of
https://github.com/nodejs/node.git
synced 2026-10-28 10:15:07 +08:00
David Evans
c558c8e81a
This adds new tests to codify the existing behaviour of throwing ENODATA when there are no matching DNS records. It also updates an existing test which was broken by https://github.com/nodejs/node/pull/64355 - previously requesting DNS records for a domain which has a CNAME to another domain, neither of which contain the requested type of record, would return an empty array. Since #64355, it will instead throw ENODATA. Finally, this updates the trigger for the relevant pipeline so that the internet tests will run if the cares_wrap.cc (and various other related files) are changed, which should reduce the chance of similar changes breaking main in the future. Refs: https://github.com/nodejs/node/pull/64355 Signed-off-by: David Evans <davidje13@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/64624 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Tim Perry <pimterry@gmail.com>