mirror of
https://github.com/nodejs/node.git
synced 2026-10-28 10:15:07 +08:00
Delete test-crypto-ecb.js, which can no longer run anywhere: Blowfish is available only from OpenSSL's legacy provider and is absent from BoringSSL. The addon and cctest version guards become OPENSSL_IS_BORINGSSL checks. Remove legacy digest-alias coverage and unreachable OpenSSL 1.x branches. JavaScript test and benchmark gates, skip reasons, and TLS error expectations that distinguished OpenSSL 1.x from provider-backed OpenSSL now distinguish BoringSSL, including PKCS12 parsing, named DH groups, private-key serialization, RSA-PSS parameters, consolidated provider caches, FIPS availability, and empty KMAC output. Keep the CCM alternate finalization error only for BoringSSL. Provider-only test skips use version-neutral terminology or state the actual minimum OpenSSL version. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex PR-URL: https://github.com/nodejs/node/pull/64777 Fixes: https://github.com/nodejs/node/issues/56733 Refs: https://github.com/nodejs/node/pull/64211 Refs: https://github.com/nodejs/node/pull/63966 Refs: https://github.com/nodejs/node/pull/53329 Refs: https://github.com/nodejs/node/pull/48950 Refs: https://github.com/nodejs/node/issues/45465 Refs: https://github.com/nodejs/node/issues/42827 Refs: https://github.com/nodejs/node/issues/47076 Refs: https://github.com/nodejs/node/pull/62862 Refs: https://github.com/nodejs/node/pull/38512 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
70 lines
1.9 KiB
JavaScript
70 lines
1.9 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const assert = require('assert');
|
|
const {
|
|
createPrivateKey,
|
|
generateKeyPair,
|
|
} = require('crypto');
|
|
const {
|
|
hasFIPS,
|
|
testSignVerify,
|
|
isBoringSSL,
|
|
} = require('../common/crypto');
|
|
|
|
const fips4 = hasFIPS(4);
|
|
|
|
// Passing an empty passphrase string should not cause OpenSSL's default
|
|
// passphrase prompt in the terminal.
|
|
// See https://github.com/nodejs/node/issues/35898.
|
|
for (const type of ['pkcs1', 'pkcs8']) {
|
|
generateKeyPair('rsa', {
|
|
modulusLength: hasFIPS(3) ? 2048 : 1024,
|
|
privateKeyEncoding: {
|
|
type,
|
|
format: 'pem',
|
|
cipher: 'aes-256-cbc',
|
|
passphrase: ''
|
|
}
|
|
}, common.mustCall((err, publicKey, privateKey) => {
|
|
if (hasFIPS(3) && type === 'pkcs1') {
|
|
assert.strictEqual(err?.code, 'ERR_OSSL_EVP_UNSUPPORTED');
|
|
return;
|
|
}
|
|
if (fips4) {
|
|
assert.strictEqual(
|
|
err?.code,
|
|
'ERR_OSSL_PASSWORD_STRENGTH_TOO_WEAK',
|
|
);
|
|
return;
|
|
}
|
|
assert.ifError(err);
|
|
assert.strictEqual(publicKey.type, 'public');
|
|
|
|
for (const passphrase of ['', Buffer.alloc(0)]) {
|
|
const privateKeyObject = createPrivateKey({
|
|
passphrase,
|
|
key: privateKey
|
|
});
|
|
assert.strictEqual(privateKeyObject.asymmetricKeyType, 'rsa');
|
|
}
|
|
|
|
// Encrypting with an empty passphrase is not the same as not encrypting
|
|
// the key, and not specifying a passphrase should fail when decoding it.
|
|
assert.throws(() => {
|
|
return testSignVerify(publicKey, privateKey);
|
|
}, isBoringSSL ? {
|
|
name: 'TypeError',
|
|
code: 'ERR_MISSING_PASSPHRASE',
|
|
message: 'Passphrase required for encrypted key'
|
|
} : {
|
|
name: 'Error',
|
|
code: 'ERR_OSSL_CRYPTO_INTERRUPTED_OR_CANCELLED',
|
|
message: 'error:07880109:common libcrypto routines::interrupted or cancelled'
|
|
});
|
|
}));
|
|
}
|