mirrors/node
0
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-10-28 18:25:13 +08:00
Code Activity
Files
v17.x
node/lib
T
History
Livia Medeiros 8009cb0a78 fs: fix write methods param validation and docs 
The FS docs wrongfully indicated support for passing object with an own
`toString` function property to `FileHandle.prototype.appendFile`,
`FileHandle.prototype.writeFile`, `FileHandle.prototype.write`,
`fsPromises.writeFile`, and `fs.writeSync`. This commit fixes that, and
adds some test to ensure the actual behavior is aligned with the docs.
It also fixes a bug that makes the process crash if a non-buffer object
was passed to `FileHandle.prototype.write`.

Refs: https://github.com/nodejs/node/pull/34993
PR-URL: https://github.com/nodejs/node/pull/41677
Backport-PR-URL: https://github.com/nodejs/node/pull/42631
Refs: https://github.com/nodejs/node/issues/41666
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2022-04-07 00:20:46 -05:00
..
assert
assert: add assert/strict alias module
2020-06-25 08:37:48 -07:00
dns
dns: add dns/promises alias
2020-05-24 03:26:21 +02:00
fs
fs: add fs/promises alias module
2020-02-18 22:15:50 -08:00
internal
fs: fix write methods param validation and docs
2022-04-07 00:20:46 -05:00
path
path: add path/posix and path/win32 alias modules
2020-10-20 14:27:31 +00:00
readline
readline: propagate signal.reason in awaitable question
2021-12-13 17:14:08 -05:00
stream
stream: add reduce
2022-02-07 12:33:44 -05:00
timers
tools: add timers functions to the list of restricted globals
2022-02-22 11:38:55 -05:00
util
util: add util/types alias module
2020-10-21 01:26:34 +02:00
_http_agent.js
http: add default argument for Agent.prototype.getName
2022-03-07 17:41:06 +00:00
_http_client.js
http: trace http client by perf_hooks
2022-03-20 23:04:31 -04:00
_http_common.js
http: remove CRLF variable
2021-09-16 09:44:12 -04:00
_http_incoming.js
lib: fix typos in lib code comments
2021-11-21 16:07:35 +01:00
_http_outgoing.js
http: don't write empty data on req/res end()
2021-12-13 17:14:18 -05:00
_http_server.js
http: trace http client by perf_hooks
2022-03-20 23:04:31 -04:00
_stream_duplex.js
stream: do not use _stream_* anymore
2021-01-05 19:02:04 +01:00
_stream_passthrough.js
stream: do not use _stream_* anymore
2021-01-05 19:02:04 +01:00
_stream_readable.js
stream: do not use _stream_* anymore
2021-01-05 19:02:04 +01:00
_stream_transform.js
stream: do not use _stream_* anymore
2021-01-05 19:02:04 +01:00
_stream_wrap.js
lib: assign missed deprecation code
2019-03-07 15:48:55 +01:00
_stream_writable.js
stream: do not use _stream_* anymore
2021-01-05 19:02:04 +01:00
_tls_common.js
tls: fix handling of x509 subject and issuer
2022-01-08 00:39:19 +00:00
_tls_wrap.js
tls: avoid throw in onerror for bad TLSSocket obj
2022-02-22 11:38:52 -05:00
.eslintrc.yaml
lib: add legacy built-in functions to primordials
2022-03-07 17:23:19 +00:00
assert.js
lib: refactor to use primordials in lib/assert.js
2022-03-20 23:04:30 -04:00
async_hooks.js
lib: fix AsyncResource.bind not using 'this' from the caller by default
2022-03-20 17:30:23 -04:00
buffer.js
buffer: fix atob input validation
2022-04-06 12:25:51 -05:00
child_process.js
child_process: add env contents types in JSDoc
2022-04-06 12:20:13 -05:00
cluster.js
lib,src: update cluster to use Parent
2021-01-05 15:41:45 -05:00
console.js
console: split console into global.js and constructor.js
2018-12-02 04:51:18 +08:00
constants.js
lib: flatten access to primordials
2019-11-25 10:28:15 +01:00
crypto.js
crypto: clarify require("crypto").getRandomValues is Node.js specific
2022-03-07 17:23:21 +00:00
dgram.js
src: properly report exceptions from AddressToJS()
2022-04-06 12:20:10 -05:00
diagnostics_channel.js
lib: add unsubscribe method to non-active DC channels
2021-10-23 08:37:19 +02:00
dns.js
net,dns: trace tcp connection and dns by perf_hooks
2022-04-06 12:20:12 -05:00
domain.js
domain: pass opts to EventEmitter.init
2022-01-24 17:35:45 +00:00
events.js
lib: add internal genericNodeError() function
2022-02-21 00:37:30 -05:00
fs.js
fs: fix write methods param validation and docs
2022-04-07 00:20:46 -05:00
http2.js
http2: add support for sensitive headers
2020-07-16 00:25:47 +02:00
http.js
lib,test,tools: use consistent JSDoc types
2021-12-13 17:14:01 -05:00
https.js
lib: update JSDoc for linting
2022-04-06 12:20:11 -05:00
inspector.js
typings: add JSDoc typings for inspector
2021-11-06 10:57:07 +01:00
module.js
module: add API for interacting with source maps
2020-01-14 12:39:06 -08:00
net.js
net,dns: trace tcp connection and dns by perf_hooks
2022-04-06 12:20:12 -05:00
os.js
os: avoid unnecessary usage of var
2022-04-06 12:25:54 -05:00
path.js
lib: fix typos in lib code comments
2021-11-21 16:07:35 +01:00
perf_hooks.js
perf_hooks: fix performance timeline wpt failures
2021-07-30 07:29:44 -07:00
process.js
…
punycode.js
punycode: add pending deprecation
2021-04-30 10:59:28 -07:00
querystring.js
lib: include return types in JSDoc
2021-12-13 17:14:20 -05:00
readline.js
readline: propagate signal.reason in awaitable question
2021-12-13 17:14:08 -05:00
repl.js
repl: remove preview when press escape
2022-03-07 17:23:21 +00:00
stream.js
stream: port more test262 tests
2022-03-07 17:31:47 +00:00
string_decoder.js
string_decoder: fix crash when calling __proto__.write()
2022-03-20 17:27:04 -04:00
sys.js
benchmark,doc,lib,test: capitalize comments
2019-03-10 00:44:40 +01:00
timers.js
timers: use ref counts to count timers
2022-01-14 16:19:46 +01:00
tls.js
src: add cve reverts and associated tests
2022-01-08 00:39:44 +00:00
trace_events.js
lib: refactor to use validateObject
2021-01-28 12:53:50 +01:00
tty.js
tty: enable buffering
2021-07-07 14:50:47 +02:00
url.js
url: trim leading and trailing C0 control chars
2022-03-20 17:27:04 -04:00
util.js
util: expose stripVTControlCharacters()
2021-10-01 22:56:58 -04:00
v8.js
lib,test,tools: use consistent JSDoc types
2021-12-13 17:14:01 -05:00
vm.js
vm: add support for import assertions in dynamic imports
2021-10-09 08:44:53 +00:00
wasi.js
wasi: use missing validator
2021-06-26 16:31:30 +02:00
worker_threads.js
worker: add setEnvironmentData/getEnvironmentData
2021-03-15 07:40:26 -07:00
zlib.js
lib: add internal genericNodeError() function
2022-02-21 00:37:30 -05:00