mirror of
https://github.com/nodejs/node.git
synced 2026-10-28 10:15:07 +08:00
Ved Chaudhari
28b50fb016
On Windows, configure.py returns from check_compiler() before it gets to the cargo and rustc check, so Temporal stays enabled even when no Rust toolchain is installed. The build then runs for a long time and fails in node_crates.vcxproj with MSB8066. Check for cargo in vcbuild.bat before configuring and building, in the same places deps/crates/cargo_build.py looks, and stop with a message pointing to BUILDING.md. The check is skipped for nobuild, clean, and when Temporal is disabled or provided as a shared library. Assisted-by: a closed-source coding agent Signed-off-by: vedchaudhari <vedc2853@gmail.com> PR-URL: https://github.com/nodejs/node/pull/66858 Fixes: https://github.com/nodejs/node/issues/66848 Refs: https://github.com/nodejs/node/issues/63451 Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>