mirror of
https://github.com/nodejs/node.git
synced 2026-10-28 18:25:13 +08:00
Junhwan Choi
d78337f085
The cpu-prof tests hand-rolled a partial version of what test/common/child_process already provides: log the child's stderr when the status is non-zero, then assert the status. That manual version never shows stdout, the signal, or the command that ran, so a CI failure gives less information than the helper would. Replace those blocks with spawnSyncAndExitWithoutError(). Every existing expectation is preserved -- status 0 is still required, and signal null is now checked as well, matching the helper defaults. Only success-path blocks whose assertions map one-to-one onto the helper defaults are converted. Refs: https://github.com/nodejs/node/pull/65351 Refs: https://github.com/nodejs/node/pull/65552 Assisted-by: claude:opus-5 Signed-off-by: Junhwan Choi <devjunsday@gmail.com> PR-URL: https://github.com/nodejs/node/pull/65694 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
51 lines
1.4 KiB
JavaScript
51 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
// This tests that --cpu-prof-dir works for workers.
|
|
|
|
const common = require('../common');
|
|
const fixtures = require('../common/fixtures');
|
|
common.skipIfInspectorDisabled();
|
|
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const { spawnSyncAndExitWithoutError } = require('../common/child_process');
|
|
|
|
const tmpdir = require('../common/tmpdir');
|
|
const {
|
|
getCpuProfiles,
|
|
kCpuProfInterval,
|
|
env,
|
|
getFrames,
|
|
} = require('../common/cpu-prof');
|
|
|
|
// --cpu-prof-dir with worker
|
|
{
|
|
tmpdir.refresh();
|
|
const { child: output } = spawnSyncAndExitWithoutError(process.execPath, [
|
|
'--cpu-prof-interval',
|
|
kCpuProfInterval,
|
|
'--cpu-prof-dir',
|
|
'prof',
|
|
'--cpu-prof',
|
|
fixtures.path('workload', 'fibonacci-worker.js'),
|
|
], {
|
|
cwd: tmpdir.path,
|
|
env,
|
|
});
|
|
const dir = tmpdir.resolve('prof');
|
|
assert(fs.existsSync(dir));
|
|
const profiles = getCpuProfiles(dir);
|
|
assert.strictEqual(profiles.length, 2);
|
|
const profile1 = getFrames(profiles[0], 'fibonacci.js');
|
|
const profile2 = getFrames(profiles[1], 'fibonacci.js');
|
|
if (profile1.frames.length === 0 && profile2.frames.length === 0) {
|
|
// Show native debug output and the profile for debugging.
|
|
console.log(output.stderr.toString());
|
|
console.log('CPU path: ', profiles[0]);
|
|
console.log(profile1.nodes);
|
|
console.log('CPU path: ', profiles[1]);
|
|
console.log(profile2.nodes);
|
|
}
|
|
assert(profile1.frames.length > 0 || profile2.frames.length > 0);
|
|
}
|