Files
node/test/parallel/test-tls-set-default-ca-certificates-reset-https-request.js
Filip Skokan a2ce2c6def tls,tools: update BoringSSL pin and TLS errors
Use BoringSSL 0.20261020.0 for shared-library builds and expose the
package wrapper's version to the matrix updater.

The new verifier no longer emits UNABLE_TO_VERIFY_LEAF_SIGNATURE
after Node's verification callback accepts a missing-issuer error.
Expect UNABLE_TO_GET_ISSUER_CERT_LOCALLY for the affected leaf
certificates and suggest --use-system-ca for that error.

Drop the SSL_get_server_tmp_key() fallback now that BoringSSL supplies
SSL_get_peer_tmp_key() as a compatibility stub.

Refs: https://boringssl-review.googlesource.com/c/boringssl/+/103849
Refs: https://github.com/electron/electron/pull/55110/changes/b457e70e339e8bb3066b210edfb6f96582cdb374
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Codex
PR-URL: https://github.com/nodejs/node/pull/66922
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2026-10-24 22:04:13 +00:00

64 lines
1.9 KiB
JavaScript

'use strict';
// This tests that tls.setDefaultCACertificates() affects actual HTTPS connections
const common = require('../common');
if (!common.hasCrypto) common.skip('missing crypto');
const assert = require('assert');
const https = require('https');
const tls = require('tls');
const fixtures = require('../common/fixtures');
const { untrustedLeafErrorCode } = require('../common/tls');
// Test HTTPS connection succeeds with proper CA, fails after removing it
const server = https.createServer({
cert: fixtures.readKey('agent8-cert.pem'),
key: fixtures.readKey('agent8-key.pem'),
}, common.mustCall((req, res) => {
res.writeHead(200);
res.end('hello world');
}, 1));
server.listen(0, common.mustCall(() => {
const port = server.address().port;
// First, set the correct CA certificate - connection should succeed.
tls.setDefaultCACertificates([fixtures.readKey('fake-startcom-root-cert.pem')]);
const req1 = https.request({
hostname: 'localhost',
port: port,
path: '/',
method: 'GET'
}, common.mustCall((res) => {
assert.strictEqual(res.statusCode, 200);
let data = '';
res.on('data', (chunk) => data += chunk);
res.on('end', common.mustCall(() => {
assert.strictEqual(data, 'hello world');
// Now set empty CA store - connection should fail.
tls.setDefaultCACertificates([]);
const req2 = https.request({
hostname: '127.0.0.1', // Use a different hostname to skip session cache.
port: port,
path: '/',
method: 'GET'
}, common.mustNotCall('Should not succeed with empty CA'));
req2.on('error', common.mustCall((err) => {
// Should fail with certificate verification error.
assert.strictEqual(err.code, untrustedLeafErrorCode);
server.close();
}));
req2.end();
}));
}));
req1.on('error', common.mustNotCall('Should not error with correct CA'));
req1.end();
}));